Repository navigation
๐จ Palette: [UX improvement] ์๊ฐ์ ์ผ๋ก ์จ๊ฒจ์ง ํ ์คํธ๋ก ์ธํด ๊นจ์ง hover ๋ฐ์ค ํจ๊ณผ ์์ - #898
seonghobae wants to merge 2 commits into
Conversation
|
๐ Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a ๐ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
No actionable comments were generated in the recent review. ๐ โน๏ธ Recent review infoโ๏ธ Run configuration
๐ Files selected for processing (4)
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review. ๐ WalkthroughWalkthrough๋งํฌ์ hover ๋ฐ ํค๋ณด๋ ํฌ์ปค์ค ๋ฐ์ค ์ ํ์๋ฅผ Changes๋งํฌ ๋ฐ์ค ๋์
Priority: โฌ๏ธ Low Estimated code review effort: 1 (Trivial) | ~5 minutes Change: Bug fix ยท Severity of issue fixed: Low Possibly related PRs
Merge Risk: โช Minimal ยท up to The selector targets the visible link label rather than the appended screen-reader text, restoring the intended hover and focus underline. No supported merge-blocking risk remains. Pre-merge checks |
|
๐ก What:
.dir-link) hover ๋ฐ focus ์ ํ์ผ๋ช /๋๋ ํ ๋ฆฌ๋ช ํ ์คํธ ๋ถ๋ถ์ ๋ฐ์ค์ ๊ทธ์ด์ฃผ๋ CSS ์ ํ์๋ฅผa:hover span:last-child์์a:hover span:nth-child(2)๋ก ์์ ํ์ต๋๋ค.๐ฏ Why:
<span class="visually-hidden">...</span>)๊ฐ ๋งํฌ ๋ด ๋ง์ง๋ง ์์ ์์๋ก ์ถ๊ฐ๋๋ฉด์,:last-child์ ํ์๊ฐ ์๋ํ๋ ๋ณด์ด๋ ํ ์คํธ๊ฐ ์๋ ์จ๊ฒจ์ง ํ ์คํธ๋ฅผ ํ๊ฒํ ํ๊ฒ ๋์์ต๋๋ค. ์ด๋ก ์ธํด ๋ง์ฐ์ค๋ฅผ ์ฌ๋ฆฌ๊ฑฐ๋ ํค๋ณด๋ ํฌ์ปค์ค๊ฐ ๊ฐ์ ๋ ์๊ฐ์ ์ธ ๋ฐ์ค ํผ๋๋ฐฑ์ด ๋ํ๋์ง ์์ ์ฌ์ฉ์ฑ์ด ์ ํ๋๋ ๋ฌธ์ ๊ฐ ๋ฐ์ํ์ต๋๋ค. ๋ช ์์ ์ธ:nth-child(2)์ ํ์๋ฅผ ์ฌ์ฉํด ๊ตฌ์กฐ๊ฐ ๋ณ๊ฒฝ๋์ด๋ ์๊ฐ์ ํจ๊ณผ๊ฐ ์ฌ๋ฐ๋ฅด๊ฒ ์๋ํ๋๋ก ๋ณต์ํ์ต๋๋ค.๐ธ Before/After:
โฟ Accessibility:
visually-hiddenํ ์คํธ ์ถ๊ฐ๊ฐ ๊ธฐ์กด ์๊ฐ์ ํผ๋๋ฐฑ์ ํผ์ํ์ง ์๋๋ก ๊ฐ์ ํ์ต๋๋ค.PR created automatically by Jules for task 453784850231406071 started by @seonghobae
Summary by CodeRabbit