Repository navigation
[codex] enterprise readiness contract - #5
Conversation
5a3bd50 to
c3f3b74
Compare
OpenCode Review Overview
Pull request overviewOpenCode reviewed the current-head bounded evidence and found no blocking issues. FindingsNo blocking findings. SummaryApproval sufficiency: bounded evidence supplied affirmative approval evidence for changed files, coverage/docstring posture, risk surfaces, and current-head verification; approval is not based merely on the absence of known blockers.
Changed-File Evidence Mapflowchart LR
PR["PR changed files"] --> Evidence["OpenCode bounded evidence"]
Evidence --> S1["Changed file (37 files)"]
S1 --> I1["repository behavior"]
I1 --> R1["Review risk: Changed file (37 files)"]
R1 --> V1["required checks"]
Evidence --> S2["Docs (3 files)"]
S2 --> I2["operator or user guidance"]
I2 --> R2["Review risk: Docs (3 files)"]
R2 --> V2["docs review"]
Evidence --> S3["Test (2 files)"]
S3 --> I3["regression suite"]
I3 --> R3["Review risk: Test (2 files)"]
R3 --> V3["targeted test run"]
|
7ef47e1 to
b151c47
Compare
![opencode-agent[bot]](https://avatars.githubusercontent.com/in/1549082?s=60&v=4){kind=small}
There was a problem hiding this comment.
Pull request overview
OpenCode reviewed the current-head bounded evidence and found no blocking issues.
Findings
No blocking findings.
Summary
Approval sufficiency: bounded evidence supplied affirmative approval evidence for changed files, coverage/docstring posture, risk surfaces, and current-head verification; approval is not based merely on the absence of known blockers.
Verification posture: CodeGraph evidence was initialized and bounded current-head evidence reviewed for changed-file evidence including Dockerfile, README.md, docker-compose.yml, docs/design-tokens.md, docs/enterprise-readiness.md, and 30 more.
Linter/static: workflow/static review evidence is bounded by the current-head GitHub Checks gate and changed-file evidence.
TDD/regression: coverage execution evidence and focused changed hunks were reviewed from bounded-review-evidence.md.
Coverage: coverage execution evidence reports supported repository test suites passed.
Docstring coverage: coverage execution evidence reports configured repository docstring gates passed or docstring coverage was advisory.
DAG: CodeGraph/source-backed behavior map connects Dockerfile to the affected review, runtime, or workflow path and required checks.
PoC/execution: coverage-evidence job executed on the current head and reported PASS.
DDD/domain: workflow and repository-governance invariants were reviewed against changed files in bounded evidence.
CDD/context: CodeGraph evidence, changed-file history, and focused hunks were reviewed from bounded-review-evidence.md.
Similar issues: changed-file history evidence was reviewed for comparable local precedents.
Claim/concept check: bounded evidence, repository source, current-head workflow evidence, and, where numeric, scientific, statistical, or literature-backed claims are affected, original-paper/formula evidence and parameter-recovery expectations were used for claims.
Standards search: standards and external-source checks are delegated to configured OpenCode web_search/Context7/DeepWiki sources when applicable; no evidence-backed standards blocker is present in bounded evidence.
Compatibility/convention: changed workflow/script conventions, object naming, and reserved-word safety for schema/API/config/code surfaces were checked in bounded evidence.
Breaking-change/backcompat: deployment evidence and changed-file history were checked for backward-compatibility risk.
Performance: changed surfaces were checked for performance risk in bounded evidence.
Developer experience: changed automation, review, test, setup, and maintenance surfaces were checked for helpful or obstructive DX impact in bounded evidence.
User experience: connected user, operator, API, CLI, documentation, review-comment, status-check, rendering, and workflow-reader behavior was checked for contradictions against code, docs, and tests in bounded evidence.
Visual/DOM: Playwright visual, DOM locator, ARIA snapshot, console, and responsive evidence were checked when a web UI surface was present; for non-web surfaces, API/CLI/log/docs/workflow interaction evidence was reviewed instead.
Accessibility/i18n: accessibility, localization, and human-readable text surfaces were checked where UI, CLI, API message, docs, logs, or review text changed.
Supply-chain/license: dependency, package, model, container, and external-tool changes were checked in bounded evidence.
Packaging: package, build, test, lint, and security contracts were checked in bounded evidence.
Security/privacy: workflow-token, review-gate, and repository-automation security/privacy boundaries were checked in bounded evidence.
- Result: APPROVE
- Reason: PR meets all test, coverage, and build requirements with no unresolved issues.
- Head SHA:
51783267c7d5ed2f188d7eeb3243ca5892a3fe05 - Workflow run: 28654687207
- Workflow attempt: 1
Changed-File Evidence Map
flowchart LR
PR["PR changed files"] --> Evidence["OpenCode bounded evidence"]
Evidence --> S1["Changed file (31 files)"]
S1 --> I1["repository behavior"]
I1 --> R1["Review risk: Changed file (31 files)"]
R1 --> V1["required checks"]
Evidence --> S2["Docs (3 files)"]
S2 --> I2["operator or user guidance"]
I2 --> R2["Review risk: Docs (3 files)"]
R2 --> V2["docs review"]
Evidence --> S3["Test (2 files)"]
S3 --> I3["regression suite"]
I3 --> R3["Review risk: Test (2 files)"]
R3 --> V3["targeted test run"]
Pull request was closed
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool. What Enabling Code Scanning Means:
For more information about GitHub Code Scanning, check out the documentation. |
The Dockerfile ran the container as root, triggering Trivy misconfiguration DS-0002 (HIGH), which failed the trivy-fs / Trivy code-scanning checks on PR #5. Add a system user (uid/gid 10001), chown /app and the writable /data dir, and switch to USER 10001 before runtime. Verified with `trivy config`: 0 HIGH/CRITICAL misconfigurations remain (was 1 FAILURE). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RTAMs4bpSZS77Xe3RQjv9P
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
|
Security/code-scanning follow-up pushed in What changed:
Verification run locally:
Local Docker image build was attempted and failed because this Windows host has no Docker daemon available: I also resolved the now-outdated review threads for the Dockerfile pinning/hash install comments and the readiness protocol no-op comments. The code-scanning API still reports the old alerts from prior merge commit |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Pull request overview
OpenCode cannot approve yet because required coverage evidence did not pass.
Review outcome
1. HIGH .github/workflows/opencode-review.yml:1 - Coverage evidence did not prove required test/docstring evidence
-
Problem: The required coverage-evidence job result was
failure, so OpenCode cannot establish approval sufficiency for this head. -
Root cause: Automated approval is only valid when the same-head coverage-evidence job proves supported repository test suites passed and configured docstring gates passed or were advisory, or reports not applicable because no supported source files or package manifests exist. Missing, failed, skipped, unavailable, or unsupported-tooling test evidence is a blocker.
-
Fix: Install or configure the repository test/docstring evidence tooling when source files or package manifests exist, rerun the current-head coverage-evidence job, and approve only after it reports
successwith required evidence or explicit no-source not-applicable evidence. -
Regression test: Keep the approval branch checking
needs.coverage-evidence.result == successbefore posting APPROVE, and publish REQUEST_CHANGES when coverage-evidence blocker states such as cancelled, skipped, failed, unsupported-tooling, or below-100 evidence are present. -
Result: REQUEST_CHANGES
-
Reason: coverage-evidence result was
failure, so required test/docstring evidence was not proven for current head99722ec2a790398d4e003efaf27311f9b46b0b84. -
Head SHA:
99722ec2a790398d4e003efaf27311f9b46b0b84 -
Workflow run: 29034439935
-
Workflow attempt: 1
Coverage evidence
Coverage Evidence
- Head SHA:
99722ec2a790398d4e003efaf27311f9b46b0b84 - Required test evidence: supported repository test suites must pass.
- Required docstring evidence: repository-owned docstring gates must pass when configured; otherwise docstring coverage is advisory.
Python project dependencies (requirements.txt)
Defaulting to user installation because normal site-packages is not writeable
Collecting annotated-doc==0.0.4 (from -r requirements.txt (line 3))
Downloading annotated_doc-0.0.4-py3-none-any.whl (5.3 kB)
Collecting annotated-types==0.7.0 (from -r requirements.txt (line 7))
Downloading annotated_types-0.7.0-py3-none-any.whl (13 kB)
Collecting anyio==4.14.1 (from -r requirements.txt (line 11))
Downloading anyio-4.14.1-py3-none-any.whl (124 kB)
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 124.9/124.9 kB 7.8 MB/s eta 0:00:00
Collecting cffi==2.1.0 (from -r requirements.txt (line 15))
Downloading cffi-2.1.0-cp312-cp312-manylinux2014_x86_64.manylinux_2_17_x86_64.whl (221 kB)
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 221.8/221.8 kB 25.2 MB/s eta 0:00:00
Collecting click==8.4.2 (from -r requirements.txt (line 117))
Downloading click-8.4.2-py3-none-any.whl (119 kB)
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 119.2/119.2 kB 34.7 MB/s eta 0:00:00
Requirement already satisfied: colorama==0.4.6 in /usr/lib/python3/dist-packages (from -r requirements.txt (line 121)) (0.4.6)
Collecting cryptography==49.0.0 (from -r requirements.txt (line 125))
Downloading cryptography-49.0.0-cp311-abi3-manylinux_2_34_x86_64.whl (4.7 MB)
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 4.7/4.7 MB 139.6 MB/s eta 0:00:00
Collecting fastapi==0.139.0 (from -r requirements.txt (line 173))
Downloading fastapi-0.139.0-py3-none-any.whl (130 kB)
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 130.3/130.3 kB 42.7 MB/s eta 0:00:00
Collecting h11==0.16.0 (from -r requirements.txt (line 177))
Downloading h11-0.16.0-py3-none-any.whl (37 kB)
Collecting idna==3.18 (from -r requirements.txt (line 181))
Downloading idna-3.18-py3-none-any.whl (65 kB)
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 65.5/65.5 kB 23.9 MB/s eta 0:00:00
Collecting psycopg==3.3.4 (from -r requirements.txt (line 185))
Downloading psycopg-3.3.4-py3-none-any.whl (213 kB)
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 213.0/213.0 kB 66.6 MB/s eta 0:00:00
Collecting psycopg-binary==3.3.4 (from -r requirements.txt (line 189))
Downloading psycopg_binary-3.3.4-cp312-cp312-manylinux2014_x86_64.manylinux_2_17_x86_64.whl (5.2 MB)
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 5.2/5.2 MB 151.1 MB/s eta 0:00:00
Collecting pycparser==3.0 (from -r requirements.txt (line 246))
Downloading pycparser-3.0-py3-none-any.whl (48 kB)
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 48.2/48.2 kB 15.5 MB/s eta 0:00:00
Collecting pydantic==2.13.4 (from -r requirements.txt (line 250))
Downloading pydantic-2.13.4-py3-none-any.whl (472 kB)
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 472.3/472.3 kB 50.9 MB/s eta 0:00:00
Collecting pydantic-core==2.46.4 (from -r requirements.txt (line 256))
Downloading pydantic_core-2.46.4-cp312-cp312-manylinux_2_17_x86_64.manylinux2014_x86_64.whl (2.1 MB)
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 2.1/2.1 MB 135.6 MB/s eta 0:00:00
Collecting pyjwt==2.13.0 (from -r requirements.txt (line 378))
Downloading pyjwt-2.13.0-py3-none-any.whl (31 kB)
Collecting starlette==1.3.1 (from -r requirements.txt (line 382))
Downloading starlette-1.3.1-py3-none-any.whl (73 kB)
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 73.6/73.6 kB 23.4 MB/s eta 0:00:00
Collecting typing-extensions==4.16.0 (from -r requirements.txt (line 386))
Downloading typing_extensions-4.16.0-py3-none-any.whl (45 kB)
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 45.6/45.6 kB 6.6 MB/s eta 0:00:00
Collecting typing-inspection==0.4.2 (from -r requirements.txt (line 394))
Downloading typing_inspection-0.4.2-py3-none-any.whl (14 kB)
Collecting tzdata==2026.2 (from -r requirements.txt (line 400))
Downloading tzdata-2026.2-py2.py3-none-any.whl (349 kB)
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 349.3/349.3 kB 80.2 MB/s eta 0:00:00
Collecting uvicorn==0.51.0 (from -r requirements.txt (line 404))
Downloading uvicorn-0.51.0-py3-none-any.whl (73 kB)
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 73.2/73.2 kB 26.3 MB/s eta 0:00:00
Installing collected packages: tzdata, typing-extensions, pyjwt, pycparser, psycopg-binary, idna, h11, click, annotated-types, annotated-doc, uvicorn, typing-inspection, pydantic-core, psycopg, cffi, anyio, starlette, pydantic, cryptography, fastapi
Successfully installed annotated-doc-0.0.4 annotated-types-0.7.0 anyio-4.14.1 cffi-2.1.0 click-8.4.2 cryptography-49.0.0 fastapi-0.139.0 h11-0.16.0 idna-3.18 psycopg-3.3.4 psycopg-binary-3.3.4 pycparser-3.0 pydantic-2.13.4 pydantic-core-2.46.4 pyjwt-2.13.0 starlette-1.3.1 typing-extensions-4.16.0 typing-inspection-0.4.2 tzdata-2026.2 uvicorn-0.51.0
- Result: PASS
Python project dependencies (.)
Using CPython 3.12.3 interpreter at: /usr/bin/python3
Creating virtual environment at: .venv
Resolved 32 packages in 215ms
Building semantic-data-portal @ file:///home/runner/work/semantic-data-portal/semantic-data-portal/pr-head
Downloading pydantic-core (2.0MiB)
Downloading cryptography (4.5MiB)
Downloading pygments (1.2MiB)
Downloading psycopg-binary (4.9MiB)
Downloaded pydantic-core
Downloaded psycopg-binary
Downloaded cryptography
Downloaded pygments
Built semantic-data-portal @ file:///home/runner/work/semantic-data-portal/semantic-data-portal/pr-head
Prepared 28 packages in 920ms
Installed 28 packages in 34ms
+ annotated-doc==0.0.4
+ annotated-types==0.7.0
+ anyio==4.14.1
+ certifi==2026.6.17
+ cffi==2.1.0
+ click==8.4.2
+ cryptography==49.0.0
+ fastapi==0.139.0
+ h11==0.16.0
+ httpcore==1.0.9
+ httpx==0.28.1
+ idna==3.18
+ iniconfig==2.3.0
+ packaging==26.2
+ pluggy==1.6.0
+ psycopg==3.3.4
+ psycopg-binary==3.3.4
+ pycparser==3.0
+ pydantic==2.13.4
+ pydantic-core==2.46.4
+ pygments==2.20.0
+ pyjwt==2.13.0
+ pytest==9.1.1
+ semantic-data-portal==0.1.0 (from file:///home/runner/work/semantic-data-portal/semantic-data-portal/pr-head)
+ starlette==1.3.1
+ typing-extensions==4.16.0
+ typing-inspection==0.4.2
+ uvicorn==0.51.0
- Result: PASS
Python project dependencies (./requirements.txt in uv env)
Resolved 21 packages in 10ms
Prepared 2 packages in 129ms
Installed 2 packages in 11ms
+ colorama==0.4.6
+ tzdata==2026.2
- Result: PASS
Python coverage with missing-line report (.)
Installed 6 packages in 9ms
........................................................................ [ 91%]
....... [100%]
=============================== warnings summary ===============================
.venv/lib/python3.12/site-packages/fastapi/testclient.py:1
/home/runner/work/semantic-data-portal/semantic-data-portal/pr-head/.venv/lib/python3.12/site-packages/fastapi/testclient.py:1: StarletteDeprecationWarning: Using `httpx` with `starlette.testclient` is deprecated; install `httpx2` instead.
from starlette.testclient import TestClient as TestClient # noqa
src/sdp_core/contracts.py:46
/home/runner/work/semantic-data-portal/semantic-data-portal/pr-head/src/sdp_core/contracts.py:46: UserWarning: Field name "schema" in "Dataset" shadows an attribute in parent "BaseModel"
class Dataset(BaseModel):
src/sdp_core/contracts.py:219
/home/runner/work/semantic-data-portal/semantic-data-portal/pr-head/src/sdp_core/contracts.py:219: UserWarning: Field name "schema" in "DatasetCreateRequest" shadows an attribute in parent "BaseModel"
class DatasetCreateRequest(BaseModel):
-- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html
79 passed, 3 warnings in 3.20s
Installed 1 package in 3ms
Name Stmts Miss Cover Missing
--------------------------------------------------------------
src/sdp/__init__.py 0 0 100%
src/sdp/api.py 347 62 82% 103, 108, 186, 190, 210, 214, 218, 319-320, 340, 350-353, 376-377, 402-403, 414-415, 420-423, 430-431, 436-439, 444, 452-453, 468, 473, 484, 489-492, 501, 512-513, 547, 560, 565, 589, 606-609, 621-624, 631, 642, 651, 657, 689-690, 703
src/sdp/authz.py 101 23 77% 53, 56, 68-71, 76, 78, 84-85, 88, 115-117, 122, 125, 129, 145, 147, 149-151, 157
src/sdp/browse.py 41 6 85% 11, 13, 15, 104, 108-117
src/sdp/catalog.py 283 33 88% 102, 107, 155, 168, 209, 221, 223, 225, 227, 229, 231, 235, 237, 249, 252, 259-261, 265-266, 279, 291, 310-311, 382, 387, 435, 441, 472-481, 548, 586-587
src/sdp/connectors.py 133 21 84% 33, 35, 56, 58, 72, 74, 78-87, 132, 134, 148, 150, 154-163, 206, 208, 222, 224, 228-237, 273
src/sdp/console.py 5 0 100%
src/sdp/credentials.py 24 1 96% 36
src/sdp/demo_smoke.py 28 4 86% 81-83, 87
src/sdp/design_tokens.py 42 1 98% 205
src/sdp/domain.py 2 0 100%
src/sdp/enterprise_evidence.py 31 1 97% 22
src/sdp/evidence.py 41 4 90% 18, 53, 59, 71
src/sdp/observability.py 111 22 80% 30, 40-42, 53, 57, 59, 102-105, 131-142, 146-151, 157
src/sdp/ontology.py 129 11 91% 103, 109, 118, 140, 146, 162-163, 187, 241, 247, 254
src/sdp/orchestrator.py 142 35 75% 33, 35, 37, 45-46, 53-54, 66, 70, 72, 74, 78, 82, 88, 95, 102, 106, 113-118, 122, 133, 137, 144, 212-213, 221-222, 229-230, 238-239, 283
src/sdp/policy.py 50 8 84% 60, 69, 85, 93, 101, 109, 136-137
src/sdp/semantic_validation.py 25 4 84% 32, 37, 48, 58
src/sdp/steward_review.py 15 0 100%
src/sdp_core/__init__.py 9 0 100%
src/sdp_core/contracts.py 196 0 100%
src/sdp_core/demo_seed.py 64 3 95% 378, 411, 419
src/sdp_core/enterprise.py 25 0 100%
src/sdp_core/kpis.py 21 0 100%
src/sdp_core/production.py 25 0 100%
src/sdp_core/rbac.py 16 0 100%
src/sdp_core/readiness.py 105 10 90% 19, 22, 25, 32, 35, 38, 45, 48, 58, 61
src/sdp_core/stores.py 141 9 94% 15-17, 97, 167-169, 179-180, 310
tests/test_api.py 822 7 99% 44, 46, 645, 653-654, 657, 660
tests/test_design_tokens.py 67 0 100%
--------------------------------------------------------------
TOTAL 3041 265 91%
- Result: PASS
Python docstring coverage advisory
RESULT: FAILED (minimum: 80.0%, actual: 4.6%)
- Result: PASS
Docker runtime version
Client: Docker Engine - Community
Version: 28.0.4
API version: 1.48
Go version: go1.23.7
Git commit: b8034c0
Built: Tue Mar 25 15:07:16 2025
OS/Arch: linux/amd64
Context: default
Server: Docker Engine - Community
Engine:
Version: 28.0.4
API version: 1.48 (minimum version 1.24)
Go version: go1.23.7
Git commit: 6430e49
Built: Tue Mar 25 15:07:16 2025
OS/Arch: linux/amd64
Experimental: false
containerd:
Version: v2.2.5
GitCommit: e53c7c1516c3b2bff98eb76f1f4117477e6f4e66
runc:
Version: 1.3.6
GitCommit: v1.3.6-0-g491b69ba
docker-init:
Version: 0.19.0
GitCommit: de40ad0
- Result: PASS
Docker build (.clusterfuzzlite/Dockerfile)
#0 building with "default" instance using docker driver
## Changed-File Evidence Map
```mermaid
flowchart LR
PR["PR changed files"] --> Evidence["OpenCode bounded evidence"]
Evidence --> S1["Changed file (37 files)"]
S1 --> I1["repository behavior"]
I1 --> R1["Review risk: Changed file (37 files)"]
R1 --> V1["required checks"]
Evidence --> S2["Docs (3 files)"]
S2 --> I2["operator or user guidance"]
I2 --> R2["Review risk: Docs (3 files)"]
R2 --> V2["docs review"]
Evidence --> S3["Test (2 files)"]
S3 --> I3["regression suite"]
I3 --> R3["Review risk: Test (2 files)"]
R3 --> V3["targeted test run"]
There was a problem hiding this comment.
Pull request overview
OpenCode reviewed the current-head bounded evidence and found no blocking issues.
Findings
No blocking findings.
Summary
Approval sufficiency: bounded evidence supplied affirmative approval evidence for changed files, coverage/docstring posture, risk surfaces, and current-head verification; approval is not based merely on the absence of known blockers.
Verification posture: CodeGraph evidence was initialized and bounded current-head evidence reviewed for changed-file evidence including .clusterfuzzlite/Dockerfile, Dockerfile, README.md, docker-compose.yml, docs/design-tokens.md, and 35 more.
Linter/static: workflow/static review evidence is bounded by the current-head GitHub Checks gate and changed-file evidence.
TDD/regression: coverage execution evidence and focused changed hunks were reviewed from bounded-review-evidence.md.
Coverage: coverage execution evidence reports supported repository test suites passed.
Docstring coverage: coverage execution evidence reports configured repository docstring gates passed or docstring coverage was advisory.
DAG: CodeGraph/source-backed behavior map connects .clusterfuzzlite/Dockerfile to the affected review, runtime, or workflow path and required checks.
PoC/execution: coverage-evidence job executed on the current head and reported PASS.
DDD/domain: workflow and repository-governance invariants were reviewed against changed files in bounded evidence.
CDD/context: CodeGraph evidence, changed-file history, and focused hunks were reviewed from bounded-review-evidence.md.
Similar issues: changed-file history evidence was reviewed for comparable local precedents.
Claim/concept check: bounded evidence, repository source, current-head workflow evidence, and, where numeric, scientific, statistical, or literature-backed claims are affected, original-paper/formula evidence and parameter-recovery expectations were used for claims.
Standards search: standards and external-source checks are delegated to configured OpenCode web_search/Context7/DeepWiki sources when applicable; no evidence-backed standards blocker is present in bounded evidence.
Compatibility/convention: changed workflow/script conventions, object naming, and reserved-word safety for schema/API/config/code surfaces were checked in bounded evidence.
Breaking-change/backcompat: deployment evidence and changed-file history were checked for backward-compatibility risk.
Performance: changed surfaces were checked for performance risk in bounded evidence.
Developer experience: changed automation, review, test, setup, and maintenance surfaces were checked for helpful or obstructive DX impact in bounded evidence.
User experience: connected user, operator, API, CLI, documentation, review-comment, status-check, rendering, and workflow-reader behavior was checked for contradictions against code, docs, and tests in bounded evidence.
Visual/DOM: Playwright visual, DOM locator, ARIA snapshot, console, and responsive evidence were checked when a web UI surface was present; for non-web surfaces, API/CLI/log/docs/workflow interaction evidence was reviewed instead.
Accessibility/i18n: accessibility, localization, and human-readable text surfaces were checked where UI, CLI, API message, docs, logs, or review text changed.
Supply-chain/license: dependency, package, model, container, and external-tool changes were checked in bounded evidence.
Packaging: package, build, test, lint, and security contracts were checked in bounded evidence.
Security/privacy: workflow-token, review-gate, and repository-automation security/privacy boundaries were checked in bounded evidence.
- Result: APPROVE
- Reason: No blocking issues found in the current-head bounded evidence.
- Head SHA:
71c35ad2c2d1a957bf944440f278f5e880c9b6d1 - Workflow run: 29089438896
- Workflow attempt: 2
Changed-File Evidence Map
flowchart LR
PR["PR changed files"] --> Evidence["OpenCode bounded evidence"]
Evidence --> S1["Changed file (37 files)"]
S1 --> I1["repository behavior"]
I1 --> R1["Review risk: Changed file (37 files)"]
R1 --> V1["required checks"]
Evidence --> S2["Docs (3 files)"]
S2 --> I2["operator or user guidance"]
I2 --> R2["Review risk: Docs (3 files)"]
R2 --> V2["docs review"]
Evidence --> S3["Test (2 files)"]
S3 --> I3["regression suite"]
I3 --> R3["Review risk: Test (2 files)"]
R3 --> V3["targeted test run"]
Superseded by current-head OpenCode approval on 71c35ad after coverage-evidence, Trivy, OSV, dependency-review, CodeQL, and Strix checks passed.
Summary
This PR moves Semantic Data Portal from MVP API surface toward a 2B KRW enterprise saleability package. It keeps the library boundary internal (
sdp_core+ currentsdpapp) rather than adding a submodule, because no second independent consumer exists yet.Implemented in this branch:
sdp_corecontracts, buyer demo seed fixtures, KPI/readiness/control/RBAC manifests, and evidence-store implementations.SDP_DATABASE_URLprecedence over SQLite fallback.--profile postgrespaid-pilot profile.Current head
84e2a3a67281bcc982564f3fd8e23ad9bc162dceVerification
PYTHONPATH=src python3 -m pytest -q-> 68 passedPYTHONPATH=src python3 -m sdp.demo_smoke->ready: true,production_paid_pilot_ready: true,production_paid_pilot_blockers: 0docker compose --profile postgres config-> validgit diff --check-> cleanpostgresql://sdp:sdp@127.0.0.1:54329/sdp-> schema migration, policy decision write/read, audit event write/read, and tenant/resource/decision_id/created_at row checks passedSDP_DATABASE_URL-> configured Postgres store, preview audit write, persisted policy/audit reads, and/enterprise/production-readinesspaid-pilot ready passedLive PR state notes