Support thread-safe async conversions #22

Activity

1. danhorst commented on Jun 14, 2023

   

   danhorst

   on Jun 14, 2023

   Last edited by danhorst

   Author

   More actions

   A quick and dirty solution would be extending ConvertApi::Task#run to be something like this:

       def run
         params = normalize_params(@params).merge(
           Timeout: @conversion_timeout,
           StoreFile: true,
         )
   
         from_format = @from_format || detect_format(params)
         read_timeout = @conversion_timeout + config.conversion_timeout_delta if @conversion_timeout
         converter = params[:converter] ? "/converter/#{params[:converter]}" : ''
         async = params[:async] ? 'async/' : ''
   
         response = ConvertApi.client.post(
           "#{async}convert/#{from_format}/to/#{@to_format}#{converter}",
           params,
           read_timeout: read_timeout,
         )
   
         Result.new(response)
       end

   There's already a lot going on in that method and I hesitate to overload it even more.