feat(guardrails): アンチパターン10件のガードを実装 - #285
Merged
Merged
Conversation
|
This PR doesn't fully meet our contributing guidelines and PR template. What needs to be fixed:
Please edit this PR description to address the above within 2 hours, or it will be automatically closed. If you believe this was flagged incorrectly, please let a maintainer know. |
|
The following comment was made by an LLM, it may be inaccurate: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
specs/ai-guardrails-anti-patterns.mdに基づき、パターン A〜J をpackages/guardrails/profile/の仕組み(plugin / permission / command / skill)と CI 層化で実装OPENCODE_*_GUARD=offで危険操作が通る）と 過剰制限しない陰性テスト（読み取り git /highワード非発火 / 権限対称）を同梱実装対応
removal-guard.ts—git rm/git add -Aの逆被参照ブロックopencode.json+implementの読み取り git allow / force-push deny、対称性テスト/plan-light+lean-pipelineskill/env-checkhygiene-warning.ts+/repo-hygienefalsifiable-change/self-checkskillsimpact-analysistest/typecheck/nix-evalの docs skip +docs-lint.yml+ci-change-scope.tsTest plan
cd packages/opencode && bun test test/plugin/anti-pattern-guards.test.ts（19 pass）guardrail*.test.tsgreenbun run local:deploy/bun run local:checkgreengit rmブロック、OPENCODE_REMOVAL_GUARD=offで通過docs-lintのみになることを確認Closes #284
Made with Cursor