Show the remaining shared examples in both backend languages - #2709
Merged
Merged
Conversation
Thirteen examples still showed only C#. Seven were on the page about using current state in a command, which had been set aside on the belief that the JVM had no way to say which thing a command acts on — that came from reading its documentation rather than its source, and both @CommandKey and CommandKeyProvider have been there all along. The other six sat on frontend pages, showing the backend that produced a proxy as though only one kind of backend could. Where the two genuinely differ the prose says so: C# resolves a read model into a validator's constructor while the JVM resolves it for the handler, C# accepts an EventSourceId-typed property where the JVM reads the command key, and the client-projected validation subsets are not the same. The frontend overview loses its full-stack tab wrapper. It was hardwired to a slot labelled "C# — backend", so a Kotlin tab would have sat inside a tab called C#. The TypeScript is a consequence of either backend rather than an alternative to one, so it reads better flat. Compiling the two Chronicle scenario examples needs the Chronicle testing project, which was not referenced; without it they were unchecked strings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on
docs/arc-multi-implementation(#2708). Review that first; this branch contains only the commits below.Thirteen shared examples still showed C# only.
Changed
@CommandKeyandCommandKeyProviderhave been there all along.C# — backend, so a Kotlin tab would have sat inside a tab called C#. The TypeScript is a consequence of either backend rather than an alternative to one, so it reads better flat.EventSourceId<T>-typed property where the JVM reads the command key; and the two client-projected validation subsets are not the same.Fixed
Not included
The tutorial chapters. They are buildable scaffolds against two pinned toolchains, and nine more snippets plus per-backend setup prose is the highest-stakes onboarding path to change in the same breath. Worth its own change.