Fix false-positive DAP018 (and rev deps/TFMs) - #174
Merged
Merged
Conversation
mgravell
commented
May 16, 2026
mgravell
commented
Member
- net9 -> net10
- fix Parameters missing? Dapper#2203
- update tests with current xunit bits
- fix DapperLib/Dapper#2203 - update tests with current xunit bits
This was referenced Aug 20, 2026
mgravell
added a commit
that referenced
this pull request
Aug 20, 2026
…203) Npgsql 10 changed reader.GetValue() for a 'date' column to return DateOnly rather than DateTime; DateOnly does not implement IConvertible, so the As<DateTime[?]> fallback through Convert.ToDateTime threw InvalidCastException. Bisected empirically: the DateOnlyTimeOnly Postgres tests pass on Npgsql 9.0.2 and fail on 10.0.2, which arrived with #174 - unseen because the Postgres integration tests need local Docker. As<DateTime[?]> now converts via ToDateTime(TimeOnly.MinValue), and As<TimeOnly[?]> answers default for a date - the same answer a zero-time DateTime gives, which is the contract the integration test documents. New docker-free unit tests cover the matrix directly, so this coverage no longer depends on a live container. Fixes #202
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.