chore: add PR size guidance to AGENTS.md by lym953 · Pull Request #1331 · DataDog/datadog-lambda-extension

lym953 · 2026-08-17T19:15:25Z

Overview

Adds a line to AGENTS.md asking agents to keep PRs small — usually no more than 300 lines of core code, excluding tests, dependency updates, and other generated changes — so reviews stay manageable.

Testing

Docs-only change; no code affected.

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

datadog-datadog-prod-us1 · 2026-08-17T19:19:02Z

✨ Unblock PR with BitsAI

⚠️ Warnings

❌ Your PR has failed checks. Please review the issues below and take necessary action before merging.

🚦 3 Pipeline jobs failed

DataDog/datadog-lambda-extension | integration-suite: [payload-size] — 🔧 Needs a code fix, caused by this PR

View more details · View in GitLab

DataDog/datadog-lambda-extension | bottlecap (amd64, fips, alpine)

View more details · View in GitLab

DataDog/datadog-lambda-extension | publish layer e2e sandbox (amd64, fips)

View more details · View in GitLab

Useful? React with 👍 / 👎

_{This comment will be updated automatically if new data arrives.

🔗 Commit SHA: 215e000 | Docs | View more details | Give us feedback!}

Copilot

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Updates contributor guidance to encourage smaller pull requests for easier reviews.

Changes:

Adds a guideline recommending PRs stay under ~1000 changed lines (including tests).

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

litianningdatadog · 2026-08-18T16:08:15Z

 ## Pull Requests

 - When creating a PR, follow the PR template at `.github/pull_request_template.md`.
+- Try to keep PRs small — usually no more than 1000 changed lines, including tests — to make review easier.


More practically we may want to limit the size of the non-test changes instead of applying a blanket 1k-line limit.

Changed to "usually no more than 300 lines of core code"

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

* fix(deps): bump h2 to 0.4.18 to fix RUSTSEC-2026-0258 (DataDog#1335) The **Audit** check (`cargo-audit`) is failing on `main`: [RUSTSEC-2026-0258](https://rustsec.org/advisories/RUSTSEC-2026-0258) — `h2` accepts and queues empty DATA frames without limit, which can lead to unbounded memory usage or a panic on length overflow. Low severity, patched in `h2` 0.4.16. This bumps `h2` 0.4.13 → 0.4.18 in `bottlecap/Cargo.lock`. Lockfile-only; no source changes. Notes on the diff: - The diff is restricted to the two `h2` lines. Running `cargo update -p h2` locally also re-resolved six unrelated `windows-sys` entries downward (0.61.2 → 0.52.0/0.60.2); that churn was reverted, and `cargo metadata --locked` confirms the lockfile is still self-consistent. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com> * [SVLS-8070] Remove dormant GHCR publisher (DataDog#1330) ## Overview * Removes the dormant GHCR publisher; companion to https://github.com/DataDog/serverless-init-ci/pull/51 * Updates Bottlecap's locked `h2` dependency from 0.4.13 to 0.4.16 to resolve [RUSTSEC-2026-0258](https://rustsec.org/advisories/RUSTSEC-2026-0258), which is blocking `main` and unrelated PRs ## Testing * `cargo check --workspace --locked` * chore: add PR size guidance to AGENTS.md (DataDog#1331) ## Overview Adds a line to `AGENTS.md` asking agents to keep PRs small — usually no more than 300 lines of core code, excluding tests, dependency updates, and other generated changes — so reviews stay manageable. ## Testing Docs-only change; no code affected. 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com> * feat(dsm): Add support for automatic DSM context extraction inside the extension (DataDog#1265) **Please include Jira ticket in title.** Update the trace context propagation support in universal instrumentation to include the automatic extraction of Data Streams Monitoring context for SQS, SNS, Kinesis and EventBridge. Added unit tests. Manually tested the functionality for Java, Go and .NET. Java and Go work correctly. [The .NET tracer needs updating to support the 2.x version of `Amazon.Lambda.RuntimeSupport`](DataDog/dd-trace-dotnet#8797) so can't test that manually yet. * feat(traces): use DD_SERVICE for inferred spans when integration service names are removed (DataDog#1343) ## Summary - Adds `DD_TRACE_REMOVE_INTEGRATION_SERVICE_NAMES_ENABLED` (default `false`). When it is set **and** `DD_SERVICE` is configured, inferred (synthetic) event-source spans report the function's base service instead of the AWS resource/instance representation. - An explicit `DD_SERVICE_MAPPING` entry still takes precedence. - Applies to the wrapped inferred spans too (SQS→SNS, SQS→EventBridge, SNS→EventBridge). ## Motivation Customers currently need one `DD_SERVICE_MAPPING` entry per trigger type per function to get their event-source spans onto their own service name. This gives them a single setting that consolidates all of them at once. Tracked by [FRSLES-869](https://datadoghq.atlassian.net/browse/FRSLES-869). This repo is the **only** inferred-span implementation for Go, Java, .NET, and Ruby, which delegate inference to the extension entirely. Companion PRs: [datadog-lambda-python#834](DataDog/datadog-lambda-python#834), [datadog-lambda-js#814](DataDog/datadog-lambda-js#814). ## Implementation note Rather than thread two more parameters through `Trigger::enrich_span` and `resolve_service_name` (a ~200-line mechanical change across all 13 trigger modules and their tests), the override is applied in `span_inferrer.rs` immediately after enrichment. To keep `DD_SERVICE_MAPPING` precedence expressed in one place, `Trigger` gains a default `has_service_mapping_entry` method that reuses the same specific/generic identifiers `resolve_service_name` looks up. Happy to switch to the full parameter-threading approach if reviewers prefer a single resolution ladder. The override lowercases `DD_SERVICE` to match the invocation span built in `processor.rs`, so both spans land on the same service. ## Scope Service-name resolution only. `complete_inferred_spans` still sets `peer.service` to the invocation span's service as it does today; revisiting that pairing is deliberately left to a follow-up. ## Test plan - [x] 6 new tests in `span_inferrer.rs`: override applies, disabled by default, yields to `DD_SERVICE_MAPPING`, no-op without `DD_SERVICE`, lowercases `DD_SERVICE`, applies to wrapped spans - [x] 3 new config tests: default off, from env, from YAML - [x] `cargo test --lib` — 550 passed - [x] `cargo clippy --lib --tests -- -D warnings` clean - [x] `cargo fmt --check` clean [FRSLES-869]: https://datadoghq.atlassian.net/browse/FRSLES-869?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ * chore(deps): update `libdatadog` to `72fa8685` and `serverless-components` to `9daae40` (DataDog#1332) --------- Co-authored-by: Yiming Luo <10097700+lym953@users.noreply.github.com> Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com> Co-authored-by: E. Lewis <lewis.lewis@datadoghq.com> Co-authored-by: James Eastham <dev@jameseastham.co.uk> Co-authored-by: Zarir Hamza <zarir.hamza@datadoghq.com> Co-authored-by: Lucas Pimentel <lucas.pimentel@datadoghq.com>

docs(agents): add PR size guidance

f4defc6

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

lym953 changed the title ~~docs(agents): add PR size guidance to AGENTS.md~~ chore: add PR size guidance to AGENTS.md Aug 17, 2026

lym953 marked this pull request as ready for review August 17, 2026 19:20

lym953 requested a review from a team as a code owner August 17, 2026 19:20

lym953 requested review from shreyamalpani and a lite review from Copilot August 17, 2026 19:20

Copilot AI reviewed Aug 17, 2026

View reviewed changes

litianningdatadog approved these changes Aug 18, 2026

View reviewed changes

lym953 and others added 2 commits August 25, 2026 17:33

docs(agents): limit PR size guidance to core code

68d8b94

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

Merge branch 'main' into docs/agents-pr-size-guidance

215e000

gh-worker-dd-devflow-36fce6 Bot added mergequeue-status: waiting mergequeue-status: queued mergequeue-status: in_progress mergequeue-status: rejected and removed mergequeue-status: waiting mergequeue-status: queued mergequeue-status: in_progress labels Aug 26, 2026

lym953 merged commit fec395f into main Aug 26, 2026
58 of 62 checks passed

lym953 deleted the docs/agents-pr-size-guidance branch August 26, 2026 15:21

smithclay mentioned this pull request Aug 31, 2026

chore: merge upstream main (through #1332) into fork main usetero/datadog-lambda-extension#29

Merged

Navigation Menu

Repository navigation

chore: add PR size guidance to AGENTS.md - #1331

chore: add PR size guidance to AGENTS.md#1331
lym953 merged 3 commits into
mainfrom
docs/agents-pr-size-guidance

lym953 commented Aug 17, 2026 •

edited

Loading

Uh oh!

datadog-datadog-prod-us1 Bot commented Aug 17, 2026 •

edited by datadog-prod-us1-3 Bot

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

litianningdatadog Aug 18, 2026

Uh oh!

lym953 Aug 25, 2026

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

lym953 commented Aug 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Overview

Testing

Uh oh!

datadog-datadog-prod-us1 Bot commented Aug 17, 2026 • edited by datadog-prod-us1-3 Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ Warnings

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

litianningdatadog Aug 18, 2026

Choose a reason for hiding this comment

Uh oh!

lym953 Aug 25, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

lym953 commented Aug 17, 2026 •

edited

Loading

datadog-datadog-prod-us1 Bot commented Aug 17, 2026 •

edited by datadog-prod-us1-3 Bot

Loading