fix(deps): pin import-in-the-middle to 3.4.0 - #835
Merged
Conversation
import-in-the-middle 3.5.0 breaks esbuild, so dd-trace-js pinned the dependency to 3.4.0. Mirror that pin here. This repo has no direct dependency on the package — it arrives through dd-trace, which declares `^3.3.2` on both the v5 and v6 lines, so a `resolutions` entry is the lever. The live exposure was the daily `yarn upgrade` in .github/workflows/update-deps.yml, which would have floated the lockfile to 3.5.0 on its own. Verified the pin survives a bare `yarn upgrade`, and that the Node 18/20 layer path (install_deps.sh, which re-resolves the v5 line without a frozen lockfile) still lands on 3.4.0. `resolutions` only governs builds in this repo — the layer and CI. npm consumers resolve dd-trace as a peer dependency and pick up import-in-the-middle themselves. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
litianningdatadog
approved these changes
Sep 9, 2026
ojproductions
approved these changes
Sep 9, 2026
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
import-in-the-middle 3.5.0 breaks esbuild, so dd-trace-js pinned the dependency to 3.4.0. Mirror that pin here.
This repo has no direct dependency on the package — it arrives through dd-trace, which declares
^3.3.2on both the v5 and v6 lines, so aresolutionsentry is the lever. The live exposure was the dailyyarn upgradein .github/workflows/update-deps.yml, which would have floated the lockfile to 3.5.0 on its own.Verified the pin survives a bare
yarn upgrade, and that the Node 18/20 layer path (install_deps.sh, which re-resolves the v5 line without a frozen lockfile) still lands on 3.4.0.resolutionsonly governs builds in this repo — the layer and CI. npm consumers resolve dd-trace as a peer dependency and pick up import-in-the-middle themselves.What does this PR do?
Motivation
Testing Guidelines
Additional Notes
Types of Changes
Check all that apply