This repository was archived by the owner on May 6, 2025. It is now read-only.
Create config sync request - #164
Merged
estringana merged 13 commits intoDec 19, 2022
Merged
Conversation
estringana
force-pushed
the
estringana/create-config-sync-request
branch
from
November 30, 2022 09:15
4fd6ce9 to
dd4cbf0
Compare
estringana
force-pushed
the
estringana/create-config-sync-request
branch
from
December 7, 2022 12:22
dd4cbf0 to
369468a
Compare
Codecov Report
@@ Coverage Diff @@
## develop/remote-config #164 +/- ##
=========================================================
- Coverage 63.40% 63.23% -0.18%
=========================================================
Files 76 76
Lines 4495 4561 +66
Branches 1359 1391 +32
=========================================================
+ Hits 2850 2884 +34
- Misses 834 842 +8
- Partials 811 835 +24
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
estringana
force-pushed
the
estringana/create-config-sync-request
branch
from
December 13, 2022 12:34
27492ee to
9640d82
Compare
estringana
commented
Dec 13, 2022
estringana
commented
Dec 13, 2022
estringana
force-pushed
the
estringana/create-config-sync-request
branch
from
December 14, 2022 11:50
4f328d3 to
923a803
Compare
estringana
force-pushed
the
estringana/create-config-sync-request
branch
from
December 14, 2022 14:57
5df2924 to
45d630f
Compare
estringana
marked this pull request as ready for review
December 15, 2022 09:12
Anilm3
previously approved these changes
Dec 16, 2022
Anilm3
left a comment
Collaborator
There was a problem hiding this comment.
As a preliminary PR to introduce multiple responses it seems fine although I think it's quite far from a final version of this concept as we'd ideally want the message queue to be in an abstraction, perhaps in the broker, then flushed by the client somehow.
Anilm3
approved these changes
Dec 19, 2022
Anilm3
pushed a commit
that referenced
this pull request
Jan 19, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR:
config_syncresquest/responseconfig_featuresresponseMotivation
Additional Notes
Describe how to test your changes
Readiness checklist
Release checklist