feat(telemetry): report AppSec product state - #364
Closed
e-n-0 wants to merge 2 commits into
Closed
Conversation
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
app-startedtelemetry with a disabled default statedd-trace-cppdoes not own the AppSec lifecycle, so the fallback is disabled. Integrations with AppSec support can populatetelemetry.productswith their actual enabled, version, and error state; that supplied state takes precedence.Motivation
C++ tracer
app-startedevents currently omitproducts.appsec, unlike the telemetry expected by system-tests and other Datadog tracers. This leaves product registration and startup state unavailable to telemetry consumers.Validation
cmake --build build -j4./build/test/tests(199862 assertions in 135 test cases)products.appsecas{"enabled":false,"version":"v2.2.1"}