fix(tracing): avoid unresolved round symbol - #367
Conversation
BenchmarksBenchmark execution time: 2026-09-03 18:14:01 Comparing candidate commit f9c2f73 in PR branch Found 0 performance improvements and 2 performance regressions! Performance is the same for 6 metrics, 0 unstable metrics.
|
|
Closing this workaround because the fix now lives at the correct compatibility boundary in DataDog/nginx-datadog#426. The exact x86_64 artifact from nginx-datadog head 4550c26474cae6e63af88de98ebc68a8a26d9ccc loads successfully in nginx:1.31.3-alpine, and its dynamic symbol table has no unresolved round, ceil, or ceilf symbols. |
Summary
std::roundin OpenTelemetry sampling threshold calculation with equivalent non-negative arithmetic0and1sampling-rate boundariesroundsymbolRoot cause
nginx-datadogremoves its musl libc dependency after linking. Thestd::roundcall introduced by #354 remained undefined in the module, causing nginx to fail at startup withundefined symbol: round.Validation
trace_segment.cpp.ohas no undefinedroundsymbol