Skip to content

Avoid error logging when parsing optional sections in codeowners file#11881

Open
daniel-mohedano wants to merge 2 commits into
masterfrom
daniel.mohedano/codeowners-optional-section
Open

Avoid error logging when parsing optional sections in codeowners file#11881
daniel-mohedano wants to merge 2 commits into
masterfrom
daniel.mohedano/codeowners-optional-section

Conversation

@daniel-mohedano

@daniel-mohedano daniel-mohedano commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

What Does This Do

  • Improves codeowners file parsing to consider ^[... as section headers, which define optional sections in Gitlab. This avoids logging an error when parsing the line.

Additional Notes

test-environment-trigger: skip

Contributor Checklist

  • Format the title according to the contribution guidelines
  • Assign the type: and (comp: or inst:) labels in addition to any other useful labels
  • Avoid using close, fix, or any linking keywords when referencing an issue
    Use solves instead, and assign the PR milestone to the issue
  • Update the CODEOWNERS file on source file addition, migration, or deletion
  • Update public documentation with any new configuration flags or behaviors
  • Add your completed PR to the merge queue by commenting /merge. You can also:
    • Customize the commit message associated with the merge with /merge --commit-message "..."
    • Remove your PR from the merge queue with /merge -c
    • Skip all merge queue checks with /merge -f --reason "reason"; please use this judiciously, as some checks do not run at the PR-level (note: the PR still needs to be mergeable, this will only skip the pre-merge build)
    • Get more information in this doc

Jira ticket: [PROJ-IDENT]

@daniel-mohedano daniel-mohedano added type: feature Enhancements and improvements comp: ci visibility Continuous Integration Visibility labels Jul 8, 2026
@daniel-mohedano daniel-mohedano marked this pull request as ready for review July 8, 2026 08:19
@daniel-mohedano daniel-mohedano requested a review from a team as a code owner July 8, 2026 08:19

@datadog-prod-us1-5 datadog-prod-us1-5 Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Datadog Autotest: PASS

More details

PR correctly fixes GitLab CODEOWNERS optional section parsing by recognizing ^[...] headers. Synthetic validation confirms all scenarios work: new optional sections are skipped, regular patterns parse correctly, bounds are safe, and no regressions detected.

Was this helpful? React 👍 or 👎

📊 Validated against 17 scenarios · Open Bits AI session

🤖 Datadog Autotest · Commit 7ba8b8e · What is Autotest? · Any feedback? Reach out in #autotest

@datadog-prod-us1-5

This comment has been minimized.

@dd-octo-sts

dd-octo-sts Bot commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

🟢 Java Benchmark SLOs — All performance SLOs passed

Suite Status
Startup 🟢 pass

SLO thresholds are defined here based on automatically generated metrics. A warning is raised when results are within 5% of the threshold.

PR vs. master results
Scenario Candidate master Δ (95% CI of mean)
startup:insecure-bank:iast:Agent 13.95 s 14.00 s [-1.0%; +0.4%] (no difference)
startup:insecure-bank:tracing:Agent 12.88 s 12.93 s [-1.1%; +0.2%] (no difference)
startup:petclinic:appsec:Agent 16.93 s 16.64 s [+0.7%; +2.7%] (maybe worse)
startup:petclinic:iast:Agent 16.84 s 16.85 s [-1.0%; +0.8%] (no difference)
startup:petclinic:profiling:Agent 16.73 s 16.78 s [-1.6%; +1.1%] (no difference)
startup:petclinic:sca:Agent 16.29 s 16.58 s [-6.1%; +2.6%] (no difference)
startup:petclinic:tracing:Agent 16.04 s 16.08 s [-1.2%; +0.6%] (no difference)

Commit: ce5947cd · CI Pipeline · Benchmarking Platform UI


Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion.

@daniel-mohedano

Copy link
Copy Markdown
Contributor Author

/merge

@gh-worker-devflow-routing-ef8351

gh-worker-devflow-routing-ef8351 Bot commented Jul 8, 2026

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2026-07-08 13:19:01 UTC ℹ️ Start processing command /merge
Use /merge -c to cancel this operation!


2026-07-08 13:19:06 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in master is approximately 1h (p90).

Use /merge -c to cancel this operation!


⏳ Processing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp: ci visibility Continuous Integration Visibility type: feature Enhancements and improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants