Enable Pekko HTTP forked tests - #12310
Conversation
This comment has been minimized.
This comment has been minimized.
🟢 Java Benchmark SLOs — All performance SLOs passed
PR vs. master results
Commit: Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion. |
31827e8 to
6edf27b
Compare
6edf27b to
e563c17
Compare
Add proxy-aware feature flag intake authentication Route direct feature flag intake through standard HTTPS proxy settings and attach the canonical fixed-width API key fingerprint. Environment: Datadog workspace Separate direct intake proxying from API key fingerprinting Keep this PR focused on proxy-aware direct Event Platform intake and leave fingerprinting to an independent change. Environment: Datadog workspace Merge live Java master after EVP split Restore Java formatting after the fingerprint split Keep the direct-intake diff free of fingerprint-only formatting artifacts. Environment: Datadog workspace Update direct-intake tests after fingerprint removal Use the original two-argument direct intake factory now that the unrelated fingerprint header plumbing has moved out of this PR. Environment: Datadog workspace Remove unnecessary Groovy imports fix(feature-flags): handle ambiguous EVP failures safely fix(feature-flags): validate direct EVP intake site Reject URL authority confusion before adding DD-API-KEY. Environment: Datadog workspace fix(config): align proxy configuration validation Read standard proxy environment variables without registering them as Datadog configuration aliases, and use the existing non-regex parser for no-proxy hosts. Environment: Datadog workspace fix(feature-flags): reject direct intake redirects Disable HTTP and HTTPS redirects for Feature Flags direct EVP intake so DD-API-KEY remains bound to the configured origin. Environment: Datadog workspace fix(feature-flags): harden proxy configuration Preserve one-character NO_PROXY entries and prevent HTTPS proxy URLs from exposing credentials through configuration telemetry. Environment: Datadog workspace Merge remote-tracking branch 'origin/master' into leo.romanovsky/ffe-agentless-evp-java-hardening # Conflicts: # utils/config-utils/src/main/java/datadog/trace/api/ConfigSetting.java # utils/config-utils/src/test/java/datadog/trace/api/ConfigSettingTest.java refactor(feature-flags): narrow direct intake hardening Keep direct intake origin and redirect protections while removing proxy and runtime failover changes. Environment: Datadog workspace Merge branch 'master' into leo.romanovsky/ffe-agentless-evp-java-hardening\n\nEnvironment: Datadog workspace Co-authored-by: devflow.devflow-routing-intake <devflow.devflow-routing-intake@kubernetes.us1.ddbuild.io>
53cace0 to
8adad42
Compare
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
More details
The forked tasks use each custom Pekko test source set. The null request guard stops context injection and does not change normal requests.
🤖 Datadog Autotest · Commit 8adad42 · What is Autotest? · @DataDog review to ask questions · Any feedback? Reach out in #autotest
ygree
left a comment
There was a problem hiding this comment.
Good catch! I wonder if there are other cases like this one where tests were mistakenly excluded from the bulk run.
bric3
left a comment
There was a problem hiding this comment.
Approving for the build.gradle changes
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
|
What Does This Do
Enables the six existing Pekko HTTP
*ForkedTestclasses across the base, latest Pekko 1.0.x, and latest dependency test suites.It also fixes the failures exposed by that coverage:
singleRequestreceives a null request;Motivation
Pekko's tests live in custom source sets, so the default
forkedTesttask used the emptytestsource set. The six forked classes were compiled but never executed.Enabling them exposed a suppressed Data Streams injection failure when the existing exception test calls
singleRequest(null):The context-propagation advice now returns before injection when there is no carrier. Normal requests are unchanged.
Additional Notes
This PR is stacked on #12308, which is stacked on #12147.
Validation:
The forked-test matrix ran 894 cases across 18 isolated class executions: 0 failures, 0 errors, and 402 conditionally skipped cases.
muzzlecould not complete locally because Maven Central range metadata resolution returned no versions for the existingpekko-http_2.12:[1.0.0,)range after retries. This PR does not change the muzzle configuration.Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]