Skip to content

Pin system-tests for transitioning to dd-sts - #7984

Closed
nccatoni wants to merge 3 commits into
masterfrom
nccatoni/system-tests-dd-sts
Closed

nccatoni wants to merge 3 commits into
masterfrom
nccatoni/system-tests-dd-sts

Conversation

@nccatoni

@nccatoni nccatoni commented Apr 13, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Pins the system-tests reusable workflow to `1e5d6b7096279ca43ce4826fda3cc805635b63c1` (current `main`) for a controlled rollout of DataDog/system-tests#6726.

system-tests#6726 updates `push_to_test_optim` to handle dd-sts internally using a shared `system-tests` policy (see
dd-source#408172). Pinning here ensures the workflow is not affected by that change until this repo is ready to update.

How to review

The only change is the pinned SHA and removing the secrets — no functional impact at this ref.

@github-actions

github-actions Bot commented Apr 13, 2026 •

Copy link
Copy Markdown
Contributor

Overall package size

Self size: 5.48 MB
Deduped: 6.32 MB
No deduping: 6.32 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | import-in-the-middle | 3.0.1 | 82.56 kB | 817.39 kB | | dc-polyfill | 0.1.10 | 26.73 kB | 26.73 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@datadog-prod-us1-4

datadog-prod-us1-4 Bot commented Apr 13, 2026 •

Copy link
Copy Markdown

✅ Tests

🎉 All green!

❄️ No new flaky tests detected
🧪 All tests passed

🎯 Code Coverage (details)
• Patch Coverage: 100.00%
• Overall Coverage: 68.24% (+0.00%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: ac5eca7 | Docs | Datadog PR Page | Was this helpful? React with 👍/👎 or give us feedback!

@codecov

codecov Bot commented Apr 13, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.82%. Comparing base (b4740a3) to head (ac5eca7).
⚠️ Report is 26 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #7984   +/-   ##
=======================================
  Coverage   73.82%   73.82%           
=======================================
  Files         773      773           
  Lines       35983    35983           
=======================================
  Hits        26566    26566           
  Misses       9417     9417           
Flag Coverage Δ
aiguard-macos 36.42% <ø> (-0.09%) ⬇️
aiguard-ubuntu 36.53% <ø> (-0.09%) ⬇️
aiguard-windows 36.33% <ø> (-0.09%) ⬇️
apm-capabilities-tracing-macos 48.42% <ø> (ø)
apm-capabilities-tracing-ubuntu 48.46% <ø> (ø)
apm-capabilities-tracing-windows 48.24% <ø> (ø)
apm-integrations-child-process 36.06% <ø> (-0.10%) ⬇️
apm-integrations-couchbase-18 34.98% <ø> (-0.09%) ⬇️
apm-integrations-couchbase-eol 35.06% <ø> (-0.07%) ⬇️
apm-integrations-oracledb 35.03% <ø> (-0.09%) ⬇️
appsec-express 52.79% <ø> (-0.10%) ⬇️
appsec-fastify 49.27% <ø> (-0.07%) ⬇️
appsec-graphql 49.53% <ø> (-0.07%) ⬇️
appsec-kafka 42.10% <ø> (-0.07%) ⬇️
appsec-ldapjs 41.39% <ø> (-0.08%) ⬇️
appsec-lodash 41.42% <ø> (-0.08%) ⬇️
appsec-macos 56.75% <ø> (-0.07%) ⬇️
appsec-mongodb-core 46.00% <ø> (-0.11%) ⬇️
appsec-mongoose 46.60% <ø> (-0.07%) ⬇️
appsec-mysql 48.73% <ø> (-0.07%) ⬇️
appsec-node-serialize 40.59% <ø> (-0.08%) ⬇️
appsec-passport 44.55% <ø> (-0.08%) ⬇️
appsec-postgres 48.31% <ø> (-0.07%) ⬇️
appsec-sourcing 40.05% <ø> (-0.08%) ⬇️
appsec-stripe 42.31% <ø> (-0.08%) ⬇️
appsec-template 40.75% <ø> (-0.08%) ⬇️
appsec-ubuntu 56.82% <ø> (-0.07%) ⬇️
appsec-windows 56.64% <ø> (-0.05%) ⬇️
instrumentations-instrumentation-bluebird 29.79% <ø> (-0.10%) ⬇️
instrumentations-instrumentation-body-parser 37.64% <ø> (-0.09%) ⬇️
instrumentations-instrumentation-child_process 35.44% <ø> (-0.10%) ⬇️
instrumentations-instrumentation-cookie-parser 31.73% <ø> (-0.09%) ⬇️
instrumentations-instrumentation-express 31.95% <ø> (-0.09%) ⬇️
instrumentations-instrumentation-express-mongo-sanitize 31.85% <ø> (-0.09%) ⬇️
instrumentations-instrumentation-express-session 37.27% <ø> (-0.09%) ⬇️
instrumentations-instrumentation-fs 29.46% <ø> (-0.10%) ⬇️
instrumentations-instrumentation-generic-pool 31.14% <ø> (ø)
instrumentations-instrumentation-http 36.88% <ø> (-0.09%) ⬇️
instrumentations-instrumentation-knex 29.76% <ø> (-0.10%) ⬇️
instrumentations-instrumentation-mongoose 30.88% <ø> (-0.09%) ⬇️
instrumentations-instrumentation-multer 37.42% <ø> (-0.09%) ⬇️
instrumentations-instrumentation-mysql2 35.38% <ø> (-0.09%) ⬇️
instrumentations-instrumentation-passport 41.17% <ø> (-0.08%) ⬇️
instrumentations-instrumentation-passport-http 40.86% <ø> (-0.08%) ⬇️
instrumentations-instrumentation-passport-local 41.36% <ø> (-0.08%) ⬇️
instrumentations-instrumentation-pg 34.90% <ø> (-0.09%) ⬇️
instrumentations-instrumentation-promise 29.72% <ø> (-0.10%) ⬇️
instrumentations-instrumentation-promise-js 29.73% <ø> (-0.10%) ⬇️
instrumentations-instrumentation-q 29.76% <ø> (-0.10%) ⬇️
instrumentations-instrumentation-url 29.72% <ø> (-0.10%) ⬇️
instrumentations-instrumentation-when 29.74% <ø> (-0.10%) ⬇️
llmobs-ai 38.38% <ø> (-0.09%) ⬇️
llmobs-anthropic 37.84% <ø> (-0.09%) ⬇️
llmobs-bedrock 37.11% <ø> (-0.08%) ⬇️
llmobs-google-genai 37.53% <ø> (-0.08%) ⬇️
llmobs-langchain 37.10% <ø> (+0.03%) ⬆️
llmobs-openai 41.22% <ø> (-0.08%) ⬇️
llmobs-vertex-ai 37.70% <ø> (-0.09%) ⬇️
platform-core 31.10% <ø> (ø)
platform-esbuild 33.97% <ø> (ø)
platform-instrumentations-misc 40.97% <ø> (ø)
platform-shimmer 37.00% <ø> (ø)
platform-unit-guardrails 32.49% <ø> (ø)
platform-webpack 20.84% <ø> (ø)
plugins-azure-durable-functions 25.87% <ø> (ø)
plugins-azure-event-hubs 26.03% <ø> (ø)
plugins-azure-service-bus 25.40% <ø> (ø)
plugins-bullmq 40.71% <ø> (-0.10%) ⬇️
plugins-cassandra 35.17% <ø> (-0.09%) ⬇️
plugins-cookie 27.06% <ø> (ø)
plugins-cookie-parser 26.85% <ø> (ø)
plugins-crypto 26.55% <ø> (ø)
plugins-dd-trace-api 35.42% <ø> (-0.10%) ⬇️
plugins-express-mongo-sanitize 26.99% <ø> (ø)
plugins-express-session 26.81% <ø> (ø)
plugins-fastify 39.35% <ø> (-0.09%) ⬇️
plugins-fetch 35.71% <ø> (-0.09%) ⬇️
plugins-fs 35.67% <ø> (-0.10%) ⬇️
plugins-generic-pool 25.92% <ø> (ø)
plugins-google-cloud-pubsub 43.02% <ø> (-0.08%) ⬇️
plugins-grpc 38.02% <ø> (-0.09%) ⬇️
plugins-handlebars 27.03% <ø> (ø)
plugins-hapi 37.23% <ø> (-0.09%) ⬇️
plugins-hono 37.50% <ø> (-0.09%) ⬇️
plugins-ioredis 35.61% <ø> (-0.09%) ⬇️
plugins-knex 26.67% <ø> (ø)
plugins-langgraph 35.05% <ø> (-0.09%) ⬇️
plugins-ldapjs 24.45% <ø> (ø)
plugins-light-my-request 26.41% <ø> (ø)
plugins-limitd-client 30.00% <ø> (-0.10%) ⬇️
plugins-lodash 26.00% <ø> (ø)
plugins-mariadb 36.48% <ø> (-0.09%) ⬇️
plugins-memcached 35.26% <ø> (-0.09%) ⬇️
plugins-microgateway-core 36.31% <ø> (-0.09%) ⬇️
plugins-moleculer 38.03% <ø> (-0.09%) ⬇️
plugins-mongodb 36.37% <ø> (-0.09%) ⬇️
plugins-mongodb-core 36.07% <ø> (-0.09%) ⬇️
plugins-mongoose 36.01% <ø> (-0.17%) ⬇️
plugins-multer 26.81% <ø> (ø)
plugins-mysql 36.35% <ø> (-0.09%) ⬇️
plugins-mysql2 36.33% <ø> (-0.09%) ⬇️
plugins-node-serialize 27.10% <ø> (ø)
plugins-opensearch 34.93% <ø> (-0.09%) ⬇️
plugins-passport-http 26.85% <ø> (ø)
plugins-postgres 34.32% <ø> (-0.09%) ⬇️
plugins-process 26.55% <ø> (ø)
plugins-pug 27.06% <ø> (ø)
plugins-redis 35.82% <ø> (-0.08%) ⬇️
plugins-router 39.98% <ø> (-0.09%) ⬇️
plugins-sequelize 25.68% <ø> (ø)
plugins-test-and-upstream-amqp10 35.63% <ø> (-0.09%) ⬇️
plugins-test-and-upstream-amqplib 40.83% <ø> (-0.09%) ⬇️
plugins-test-and-upstream-apollo 36.50% <ø> (-0.08%) ⬇️
plugins-test-and-upstream-avsc 35.52% <ø> (-0.09%) ⬇️
plugins-test-and-upstream-bunyan 31.16% <ø> (-0.10%) ⬇️
plugins-test-and-upstream-connect 37.83% <ø> (-0.09%) ⬇️
plugins-test-and-upstream-graphql 37.17% <ø> (-0.09%) ⬇️
plugins-test-and-upstream-koa 37.44% <ø> (-0.09%) ⬇️
plugins-test-and-upstream-protobufjs 35.73% <ø> (-0.09%) ⬇️
plugins-test-and-upstream-rhea 41.07% <ø> (+0.07%) ⬆️
plugins-undici 36.52% <ø> (-0.09%) ⬇️
plugins-url 26.55% <ø> (ø)
plugins-valkey 35.29% <ø> (-0.09%) ⬇️
plugins-vm 26.55% <ø> (ø)
plugins-winston 31.60% <ø> (+0.04%) ⬆️
plugins-ws 38.92% <ø> (-0.09%) ⬇️
profiling-macos 37.94% <ø> (-0.09%) ⬇️
profiling-ubuntu 38.10% <ø> (-0.09%) ⬇️
profiling-windows 39.47% <ø> (-0.09%) ⬇️
serverless-azure-functions-client 25.75% <ø> (ø)
serverless-azure-functions-eventhubs 25.75% <ø> (ø)
serverless-azure-functions-servicebus 25.75% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pr-commenter

pr-commenter Bot commented Apr 13, 2026 •

Copy link
Copy Markdown

Benchmarks

Benchmark execution time: 2026-04-13 15:41:11

Comparing candidate commit ac5eca7 in PR branch nccatoni/system-tests-dd-sts with baseline commit b4740a3 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 233 metrics, 27 unstable metrics.

@nccatoni nccatoni added the dev-ex Developer Experience label Apr 13, 2026
@nccatoni
nccatoni marked this pull request as ready for review April 13, 2026 14:01
@nccatoni
nccatoni requested a review from a team as a code owner April 13, 2026 14:01

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 4024554684

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread .github/workflows/system-tests.yml Resolved
@nccatoni nccatoni closed this Apr 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dev-ex Developer Experience semver-patch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants