Skip to content

test(molten): unflake route snapshot - #21585

Draft
KowalskiThomas wants to merge 1 commit into
mainfrom
dd/kowalski/molten-snapshot-duration
Draft

KowalskiThomas wants to merge 1 commit into
mainfrom
dd/kowalski/molten-snapshot-duration

Conversation

@KowalskiThomas

@KowalskiThomas KowalskiThomas commented Nov 9, 2026 •

Copy link
Copy Markdown
Collaborator

Description

The emitted span structure and metadata match the baseline, but sub-millisecond durations vary enough across runners to fail the snapshot comparison.

Proposed change: Ignore the volatile duration field in the existing route-success snapshot.

CI Visibility

Flaky Management codes: DD_W4D29Y, DD_ZLZFUV, DD_0SVDZA, DD_QCJBAZ, DD_6Z273F.

Representative failure:

At snapshot compare of span 'molten.components.UploadedFileComponent.can_handle_parameter' at position 16 in trace:
- Expected span:
{'duration': 55042,
- Received span:
{'duration': 21036,

@datadog-official datadog-official Bot added Bits AI changelog/no-changelog A changelog entry is not required for this PR. labels Nov 9, 2026
@datadog-official

Copy link
Copy Markdown
Contributor

View session in Datadog

Bits Code status: ✅ Done

CI Auto-fix: Disabled | Enable

Comment @DataDog to request changes

@cit-pr-commenter-54b7da

Copy link
Copy Markdown

Codeowners resolved as

Resolved from the full PR diff against main using the target branch CODEOWNERS file.
CODEOWNERS team requests not listed below are not required by the current file set.

tests/contrib/molten/test_molten.py                                     @DataDog/python-guild @DataDog/apm-idm-python

@cit-pr-commenter-54b7da

cit-pr-commenter-54b7da Bot commented Nov 9, 2026 •

Copy link
Copy Markdown

Dependency direction analysis

⚠️ Existing dependency direction violations

There are 83 dependency direction violations that already exist on the base branch and have not been changed by this PR.

Show existing violations (showing 5 of 83 highest severity)
ddtrace.internal.tracemethods -×-> ddtrace.trace  (internal-core -> product:tracing, score=120)
ddtrace.llmobs._integrations.typesafe -×-> ddtrace.trace  (product:llmobs -> product:tracing, score=118)
ddtrace.llmobs._integrations.crewai -×-> ddtrace.trace  (product:llmobs -> product:tracing, score=118)
ddtrace.llmobs._integrations.openai_agents -×-> ddtrace.trace  (product:llmobs -> product:tracing, score=118)
ddtrace.llmobs._evaluators.runner -×-> ddtrace.trace  (product:llmobs -> product:tracing, score=118)

To see all violations, download the layers-base.json and layers-pr.json artifacts from this CI job and run:

uv run --script scripts/import-analysis/layers.py compare layers-base.json layers-pr.json

@datadog-official

datadog-official Bot commented Nov 9, 2026 •

Copy link
Copy Markdown
Contributor

Pipelines  Tests

🎉 All green!

🧪 All tests passed
❄️ No new flaky tests detected

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 61848a5 | Docs | View more details | Give us feedback!

@KowalskiThomas
KowalskiThomas force-pushed the dd/kowalski/molten-snapshot-duration branch from 3aac55e to 61848a5 Compare November 9, 2026 08:12
@KowalskiThomas KowalskiThomas added testing ci-reliability The PR is related to the CI reliability of dd-trace-py integrations labels Nov 9, 2026
@KowalskiThomas KowalskiThomas changed the title test(molten): stabilize route snapshot test(molten): unflake route snapshot Nov 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bits AI changelog/no-changelog A changelog entry is not required for this PR. ci-reliability The PR is related to the CI reliability of dd-trace-py integrations testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant