test: semver operators support 1 to 5 version parts - #31
Merged
Conversation
greghuels
requested review from
leoromanovsky and
pavlokhrebto
and removed request for
a team
August 18, 2026 20:23
dd-oleksii
approved these changes
Aug 18, 2026
dd-oleksii
left a comment
Member
There was a problem hiding this comment.
other than not rejecting 6-part version, this looks good
Remove the six-part-input runtime attribute case and the six-part configured comparand rejection case. For now we are not limiting the number of parts a version can have, so these invalid-rejection expectations no longer hold. - remove six-part-input case from test-case-semver-version-parts.json - remove invalid-too-many-parts case and its flag from test-case-semver-invalid-comparand-categories.json / ufc-config.json - update README descriptions to drop the six-part rejection language
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
18-- now allowed, treated as18.0.018.0-- now allowed, treated as18.0.018.0.0-- still allowed (valid semver)18.0.0-prerelease.1-- still allowed (valid semver)18.0.0.0-- now allowed18.0.0.0.0-- now allowed18.0.0.0.0.0(and beyond) -- not limited; for now we are not capping the number of parts a version can haveChanges
Validation