[FFL-2914] Reject inline Unicode targeting regex flags - #32
Open
btthomas wants to merge 2 commits into
Open
Conversation
btthomas
marked this pull request as ready for review
August 20, 2026 17:37
btthomas
requested review from
danyal002,
dd-oleksii and
sameerank
and removed request for
a team
August 20, 2026 17:37
4 tasks
sameerank
approved these changes
Aug 20, 2026
dd-oleksii
reviewed
Aug 21, 2026
| "expectedMatch": null, | ||
| "engineExpectations": { | ||
| "go": { "compile": true, "match": true }, | ||
| "re2js": { "compile": true, "match": true }, |
Member
There was a problem hiding this comment.
major: why do we even have re2js here? We don't use it. And plain js rejects (?i) groups completely
Comment on lines
+631
to
+632
| "rustRulesBased": { "compile": false, "match": null }, | ||
| "rustRkyv": { "compile": false, "match": null } |
Member
There was a problem hiding this comment.
minor: I think I mentioned this somewhere else but Rust evaluators should behave the same — they are using the same regex library, so we don't need separate rows for them
dd-oleksii
reviewed
Aug 21, 2026
Comment on lines
339
to
349
| { | ||
| "id": "accepted-inline-case-insensitive", | ||
| "description": "The case-insensitive inline flag is portable.", | ||
| "category": "inline-flag", | ||
| "contract": "accepted", | ||
| "rawPattern": "(?i)^alice$", | ||
| "normalizedPattern": "(?i)^alice$", | ||
| "expectedCompile": true, | ||
| "input": "ALICE", | ||
| "expectedMatch": true | ||
| }, |
Member
There was a problem hiding this comment.
major: we want to reject this one (and all of the (?x) flags) because JS does not support it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FFL-2914
Motivation
Inline Unicode flags and repeated inline flags are not accepted consistently by every shipped targeting-regex engine. The portable authoring contract should reject them instead of requiring consumers to normalize or reinterpret the pattern.
Changes
-.Validation
jq empty ufc-config.json evaluation-cases/*.json regex-conformance/targeting-regex-conformance.jsonpython3 ci/validate-fixtures.py(307 evaluation cases across 41 files)Blast Radius
This changes the authoring decision for one existing case and adds two rejected cases. The expanded Snowflake/Iceberg inventory fetched on 2026-08-20 contained 535 distinct regexes and found no inline Unicode or repeated inline flags.
QA
No application QA is required because this PR changes shared test data only. Downstream consumers should update their fixture pin after this PR merges.