Auto-activate java easy wins for debugger - #7142
Conversation
|
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 40927558f9
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| spring-boot-undertow: v1.38.0 | ||
| spring-boot-wildfly: v1.38.0 | ||
| uds-spring-boot: v1.38.0 | ||
| vertx4: v1.63.0 # TODO: a lower version might be supported |
There was a problem hiding this comment.
Keep non-Spring variants disabled until they expose the target
Activating this class for the non-Spring Java weblogs makes the test passable without exercising the intended code path. The probe is rewritten for Java to target DebuggerController.logProbe in tests/debugger/utils.py, and the setup triggers /debugger/log; a repo-wide search under utils/build/docker/java only finds that controller and route in the Spring Boot app. On vertx4 and the following newly enabled variants, an ERROR diagnostic can therefore come from an unresolved target (and no snapshot is guaranteed because the route is absent), so the test can report green without validating invalid-DSL rejection. Keep these variants disabled until they implement the same debugger endpoint/controller or the test targets code common to those apps.
Useful? React with 👍 / 👎.
4092755 to
b581b59
Compare
|
PRApprover will approve and merge this PR, FAQ, #dx-source-code-management 🛠️ PRApproval Status
➡️ Current phase: approved - manual merge required (this rule does not auto-merge) |
b581b59 to
a87d9b0
Compare
new commit added, dismiss all previous approvals
a87d9b0 to
af86fd1
Compare
new commit added, dismiss all previous approvals
af86fd1 to
0e0df67
Compare
new commit added, dismiss all previous approvals
0e0df67 to
afc6333
Compare
new commit added, dismiss all previous approvals
|
✅ All CI checks and tests passed. 🎉 All green!🧪 All tests passed 🔗 Commit SHA: 38c529f | Docs | View more details | Give us feedback! |
afc6333 to
f4f58df
Compare
new commit added, dismiss all previous approvals
f4f58df to
42d6e12
Compare
42d6e12 to
409341a
Compare
new commit added, dismiss all previous approvals
409341a to
85aa229
Compare
new commit added, dismiss all previous approvals
85aa229 to
6241173
Compare
new commit added, dismiss all previous approvals
6241173 to
7ec1921
Compare
new commit added, dismiss all previous approvals
7ec1921 to
87c8ac4
Compare
new commit added, dismiss all previous approvals
87c8ac4 to
ef7cea7
Compare
new commit added, dismiss all previous approvals
ef7cea7 to
3b08da5
Compare
new commit added, dismiss all previous approvals
2c947ed to
ca41eae
Compare
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ca41eae to
38c529f
Compare
Automated activation of easy-win tests for
javaowned bydebuggerView nightly workflow run