Auto-activate python easy wins for apm-lang-platform - #7468
Auto-activate python easy wins for apm-lang-platform#7468dd-octo-sts[bot] wants to merge 1 commit into
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
PRApprover will approve and merge this PR, FAQ, #dx-source-code-management 🛠️ PRApproval Status
➡️ Current phase: approved - manual merge required (this rule does not auto-merge) |
|
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 688c993060
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| tests/parametric/test_otlp_trace_metrics.py::Test_FR01_Enablement_Configuration::test_fr01_6_disabled_when_apm_tracing_disabled: # TODO: a lower version might be supported | ||
| - declaration: missing_feature (OTLP trace metrics are still emitted when DD_APM_TRACING_ENABLED=false) | ||
| component_version: <4.12.2 |
There was a problem hiding this comment.
This change tries to enable test_fr01_6_disabled_when_apm_tracing_disabled starting at Python 4.12.2, but the existing file-level entry tests/parametric/test_otlp_trace_metrics.py: v4.13.0-dev still matches every nodeid in this file. Manifest.get_declarations accumulates all prefix-matching declarations rather than letting the more specific method entry override the file entry, so for 4.12.2 the test still receives the parent missing_feature skip and the easy-win activation has no effect until 4.13.0-dev.
Useful? React with 👍 / 👎.
| tests/parametric/test_otlp_trace_metrics.py::Test_FR01_Enablement_Configuration::test_fr01_6_disabled_when_apm_tracing_disabled: missing_feature (OTLP trace metrics are still emitted when DD_APM_TRACING_ENABLED=false) | ||
| tests/parametric/test_otlp_trace_metrics.py::Test_FR01_Enablement_Configuration::test_fr01_6_disabled_when_apm_tracing_disabled: # TODO: a lower version might be supported | ||
| - declaration: missing_feature (OTLP trace metrics are still emitted when DD_APM_TRACING_ENABLED=false) | ||
| component_version: <4.12.2 |
There was a problem hiding this comment.
This new component_version value starts with <, but the manifest review rules require values containing special YAML characters such as < to be quoted. Keeping it unquoted violates the repository’s manifest syntax convention and can be avoided by writing the range as '<4.12.2'. .cursor/rules/pr-review.mdcL61-L65
Useful? React with 👍 / 👎.
|
✅ All CI checks and tests passed. 🎉 All green!🧪 All tests passed 🔗 Commit SHA: a192fd0 | Docs | View more details | Give us feedback! |
d44963e to
4e80deb
Compare
![dd-prapprover-prod-77c48c[bot]](https://avatars.githubusercontent.com/u/244837012?s=60&v=4){kind=small}
4e80deb to
92ae8bb
Compare
new commit added, dismiss all previous approvals
92ae8bb to
bb13e16
Compare
new commit added, dismiss all previous approvals
bb13e16 to
d9bd069
Compare
new commit added, dismiss all previous approvals
d9bd069 to
2974eb7
Compare
fa68d95 to
7493831
Compare
new commit added, dismiss all previous approvals
96a69b0 to
1bf2357
Compare
1bf2357 to
effac1e
Compare
new commit added, dismiss all previous approvals
effac1e to
7e91849
Compare
7e91849 to
35c2f09
Compare
new commit added, dismiss all previous approvals
35c2f09 to
e80ed35
Compare
new commit added, dismiss all previous approvals
e80ed35 to
238746b
Compare
new commit added, dismiss all previous approvals
238746b to
fae8638
Compare
new commit added, dismiss all previous approvals
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
fae8638 to
a192fd0
Compare
new commit added, dismiss all previous approvals
Automated activation of easy-win tests for
pythonowned byapm-lang-platformView nightly workflow run