Skip to content

[python] enable passing OTLP ot.th/ot.rv tracestate sampling scenarios - #7653

Merged
vpellan merged 1 commit into
mainfrom
vpellan/activate-python-otlp-sampling-support
Sep 7, 2026
Merged

[python] enable passing OTLP ot.th/ot.rv tracestate sampling scenarios#7653
vpellan merged 1 commit into
mainfrom
vpellan/activate-python-otlp-sampling-support

Conversation

@vpellan

@vpellan vpellan commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

Motivation

Enables the Python entries that pass against dd-trace-py's OTLP implementation (DataDog/dd-trace-py#19794), verified locally against a python@4.15.0-dev build across every impacted scenario

Changes

Flips tests/otel/test_tracing_otlp.py entries from missing_feature to v4.15.0-dev in manifests/python.yml:

  • Test_Otlp_Carries_Ot
  • Test_Otlp_Forwards_Inherited_Ot

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed and the CI green, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • Anything but tests/ or manifests/ is modified ? I have the approval from R&P team
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added, removed or renamed?

@vpellan
vpellan requested a review from a team as a code owner September 4, 2026 14:45
@vpellan
vpellan requested review from etayyosefdd and removed request for a team September 4, 2026 14:45
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 4, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-04T14:48:14.532456Z d4b07b6 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@github-actions

github-actions Bot commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

CODEOWNERS have been resolved as:

manifests/python.yml                                                    @DataDog/system-tests-reviewers

@datadog-datadog-prod-us1-2

datadog-datadog-prod-us1-2 Bot commented Sep 4, 2026

Copy link
Copy Markdown

Tests

All CI checks and tests passed.

🎉 All green!

🧪 All tests passed
❄️ No new flaky tests detected

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 91e8008 | Docs | View more details | Give us feedback!

Base automatically changed from vpellan/activate-python-otel-sampling-support to main September 7, 2026 09:48
@vpellan
vpellan force-pushed the vpellan/activate-python-otlp-sampling-support branch from d4b07b6 to 91e8008 Compare September 7, 2026 09:48
@vpellan
vpellan merged commit 7f388eb into main Sep 7, 2026
52 checks passed
@vpellan
vpellan deleted the vpellan/activate-python-otlp-sampling-support branch September 7, 2026 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants