Repository navigation
Revert "[debugger] Test that debugger metrics use the debugger telemetry namespace" - #8257
Conversation
…try name…" This reverts commit b56da8d.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7bcb4e7c63
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| @@ -136,51 +97,3 @@ def setup_telemetry_co(self): | |||
| @slow | |||
| def test_telemetry_co(self): | |||
| self._assert(required_telemetry=["code_origin_for_spans_enabled"]) | |||
There was a problem hiding this comment.
With Test_Debugger_Telemetry_Metrics deleted and its declarations removed from all seven library manifests, the downstream easy-win process has no irrelevant record and can incorrectly treat this coverage as passing. Retain the test node and deactivate it with irrelevant manifest entries rather than removing both the test and its activation metadata. .cursor/rules/pr-review.mdcL49-L53
Useful? React with 👍 / 👎.
* u/main: (82 commits) Auto-activate nodejs easy wins for asm-libraries (#8265) Auto-activate nodejs easy wins for apm-sdk-capabilities (#8264) Auto-activate rust easy wins for apm-sdk-capabilities (#8217) Auto-activate golang easy wins for apm-sdk-capabilities (#8263) Auto-activate dotnet easy wins for apm-sdk-capabilities (#8262) test(ffe): cover Go and Java customer exposure hooks (#8094) Move the debugger scenarios to the mocked backend, with remote config sent through it (#8253) test(otel): observe the SDK's default OTLP protocol instead of hardcoding it (#8256) Revert "[debugger] Test that debugger metrics use the debugger telemetry namespace" (#8257) Check the mocked backend network aliases on GitLab (#8212) Agent on the mocked backend: set DD_SITE instead of each intake URL (#8254) [debugger] Test that debugger metrics use the debugger telemetry namespace (#8052) Fail SSI installs when component installation fails (#8246) Collect HotSpot hs_err logs from Java AWS SSI weblogs (#8249) FFE direct shutdown: detect the priming capture without the watchdog latency (#8250) Move DEBUGGER_TELEMETRY to the mocked backend, which serves remote config (#8239) PHP parametric base image (#8172) AI Guard: tests for backend-provided extra_tags on the ai_guard span (#8130) Cbeauchesne/rename dead and legacy features (#8240) Retry AWS SSI jobs when the installer cannot update apt sources (#8245) ...
Reverts #8052