Skip to content

feat(python): update RC gunicorn behavior #932

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
avara1986 merged 1 commit into from
Mar 6, 2023
Merged

feat(python): update RC gunicorn behavior #932

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion tests/remote_config/test_remote_configuration.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,6 +190,7 @@ class Test_RemoteConfigurationUpdateSequenceFeatures(RemoteConfigurationFieldsBa
"""Tests that over a sequence of related updates, tracers follow the RFC for the Features product"""

request_number = 0
python_request_number = 0

@bug(context.weblog_variant == "spring-boot-openliberty", reason="APPSEC-6721")
@bug(
Expand All @@ -207,7 +208,15 @@ def validate(data):

rc_check_request(data, ASM_FEATURES_EXPECTED_REQUESTS[self.request_number], caching=True)

self.request_number += 1
# TODO(Python). Gunicorn creates 2 process (main gunicorn process + X child workers). It generates two payloads
# for each request number. We're working to update this behavior in this propossal
# https://docs.google.com/document/d/1zeh7g_c_4Oj9EUuf8kQEW_qbZl9PCH4hJHiVYnoLy6I/edit
self.python_request_number += 1
if context.library == "python" and context.weblog_variant != "uwsgi-poc":
if self.python_request_number % 2 == 0:
self.request_number += 1
else:
self.request_number += 1

return False

Expand Down