Skip to content

Supervised index wrapper bypasses its documented gate #1118

Open

Description

@lzl51230

Problem

cbm_mcp_index_run_supervised_path() directly invokes the private supervisor path, but its public header says it returns NULL when the kill switch is set or the process is not a supervisor host. Current production callers pre-gate it, while direct callers and tests can bypass the documented contract.

Found during review of the SVN auto-watch work in #1113.

Suggested fix

Enforce cbm_index_supervisor_should_wrap() inside the public wrapper and add direct tests for unmarked host, kill switch, spawn failure, contained failure response, and success.

Activity

  1. added
    bugSomething isn't working
    stability/performanceServer crashes, OOM, hangs, high CPU/memory
    priority/normalStandard review queue; useful PR with ordinary maintainer urgency.
    on Jul 16, 2026
  2. added this to the 0.9.1-rc milestone on Jul 16, 2026
  3. DeusData commented on Jul 16, 2026

    @DeusData
    Owner

    Thanks for isolating the contract mismatch. This is a scoped 0.9.1-rc stability bug: the public supervised-index wrapper should enforce its own documented gate rather than rely on every caller to remember a precondition. The regression should call the wrapper directly for the unmarked-host and kill-switch cases before the implementation change, then cover spawn failure, contained failure, and success without changing the public contract.

  4. added
    priority/highNeeds near-term maintainer attention; high-impact bug, regression, safety issue, or release blocker.
    and removed
    priority/normalStandard review queue; useful PR with ordinary maintainer urgency.
    on Sep 5, 2026
  5. DeusData commented on Oct 19, 2026

    @DeusData
    Owner

    Thank you for isolating the public-wrapper contract mismatch. I have no new direct-wrapper gate test or resolution to report; caller preconditions alone do not settle the documented wrapper behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workingpriority/highNeeds near-term maintainer attention; high-impact bug, regression, safety issue, or release blocker.stability/performanceServer crashes, OOM, hangs, high CPU/memory

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions