Repository navigation
feat: add Visual Basic .NET support - #2885
jorgeluisblanco wants to merge 1 commit into
Conversation
|
Thanks for opening this — it has been seen, and it is queued. This note is automated, but it is not a brush-off: it exists so you know where your PR stands instead of having to guess from silence. Current review status: working through a backlog. What that means for this PR, concretely:
Things that will genuinely speed it up whenever review does happen:
If this fixes a bug, a reproduction we can run is worth more than a description of the symptom. Thanks for contributing, and sorry in advance for the wait. |
Signed-off-by: jorge blanco <jorge.luis.blanco@hotmail.com>
9822399 to
7d6982c
Compare
|
Thank you, @jorgeluisblanco, for this VB.NET contribution, and welcome! This is a careful piece of work. The language wiring follows the existing C# and .NET patterns closely. The Inherits/Implements, field, import and constructor extraction is easy to follow. You updated every registration tripwire (call-node manifest, capability ledger, label goldens) consistently. The grammar provenance is written down clearly: the upstream pin, the byte-identical MIT LICENSE, and credit for the patch you built on. That makes our side of the review much easier. I want to be upfront about how grammar changes work here, so nothing in this comment comes as a surprise later. We vendor third-party grammar code ourselves: we pin the upstream source, verify the licenses, regenerate the parser and do the vendoring in-house, rather than merging generated parser output from a pull request. That is the same note we left on #1178 for the earlier VB.NET work. The files involved here are everything under There is also an older open pull request for the same language, #1179, and both touch the same language slot. We would like to look at the VB.NET grammar choice and the open VB-family pull requests together instead of deciding them one at a time. Some questions are still open on our side, such as which grammar to use, how VB.NET and VB6 share aliases like Nothing is needed from you right now. We will come back to you here once we have decided how the grammar side will proceed. For when you next touch the branch: the only red CI check is Thanks again for putting this much care into it, and sorry in advance for the wait while we sort out the grammar side. |
Summary
.vb) language discovery and configurationValidation
Fixes #1178
AI assistance
This contribution was prepared with OpenAI Codex under the contributor's direction. The contributor reviewed and tested the changes and accepts responsibility for them.