Devextreme: move to nx executors bundle-config tasks from gulp pipeline - #34290
Merged
vorobey merged 6 commits intoJul 14, 2026
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR migrates the DevExtreme “bundler-config” build/watch flow from a custom Gulp pipeline to Nx targets backed by the devextreme-nx-infra-plugin:concatenate-files executor, extending that executor to support multi-pass outputs and watch mode.
Changes:
- Added
additionalPassessupport so one concatenation output can feed derived outputs in the same executor run. - Added
watch/watchPathssupport toconcatenate-filesusingchokidar, plus e2e coverage for both features. - Rewired
bundler-configandbundler-config-watchGulp tasks to delegate to Nx targets.
Reviewed changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| pnpm-lock.yaml | Locks newly added chokidar dependency. |
| packages/nx-infra-plugin/src/executors/concatenate-files/schema.ts | Refactors options into a reusable ConcatenatePass and adds watch/multi-pass fields. |
| packages/nx-infra-plugin/src/executors/concatenate-files/schema.json | Extends executor schema with additionalPasses, watch, and watchPaths + pass definition. |
| packages/nx-infra-plugin/src/executors/concatenate-files/executor.e2e.spec.ts | Adds e2e tests for multi-pass execution and watch rebuild behavior. |
| packages/nx-infra-plugin/src/executors/concatenate-files/concatenate-files.impl.ts | Implements multi-pass runtime resolution and watch mode via chokidar. |
| packages/nx-infra-plugin/AGENTS.md | Documents the migrated gulp tasks and the new Nx watch target. |
| packages/devextreme/project.json | Adds build:devextreme-bundler-config:watch Nx target; uses additionalPasses to generate derived config. |
| packages/devextreme/package.json | Adds chokidar dependency required for the new watch-mode executor behavior. |
| packages/devextreme/build/gulp/bundler-config.js | Replaces Gulp stream logic with Nx delegation via gulp-shell. |
Files not reviewed (1)
- pnpm-lock.yaml: Generated file
vorobey
commented
Jul 14, 2026
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Signed-off-by: Andrey Vorobev <dobriy.kaa@gmail.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Signed-off-by: Andrey Vorobev <dobriy.kaa@gmail.com>
GoodDayForSurf
approved these changes
Jul 14, 2026
vorobey
merged commit Jul 14, 2026
d69fa58
into
DevExpress:feature/gulp-to-nx-migration
120 of 122 checks passed
vorobey
added a commit
that referenced
this pull request
Jul 14, 2026
vorobey
added a commit
that referenced
this pull request
Jul 15, 2026
vorobey
added a commit
that referenced
this pull request
Jul 15, 2026
vorobey
added a commit
that referenced
this pull request
Jul 16, 2026
vorobey
added a commit
that referenced
this pull request
Jul 17, 2026
vorobey
added a commit
that referenced
this pull request
Jul 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.