Skip to content

[FEATURE REQUEST] Different treatment for packages with denied upgrades #1812

Open

Description

Please confirm these before moving forward

  • I have searched for my feature proposal and not found a work-in-progress/duplicate/resolved/discarded issue.
  • This proposal is a completely new feature. If you want to suggest an improvement or an enhancement, please use this template

Describe the new feature

In scheme 1.6, the "deny" option was added to UpgradeBehavior to specify that WinGet shouldn't attempt to upgrade the package. It'd be nice if such packages weren't attempted by WingetUI to upgrade every day (such as an auto-skip along with it being pinned, perhaps?) along with a "skipped" icon being displayed for it.

Describe how this new feature could help users.

It would be helpful to automatically

Activity

  1. marticliment commented on Feb 23, 2024

    @marticliment
    Collaborator

    I don't really undertstand what you mean. Could you please give an example?

  2. aaronliu0130 commented on Feb 23, 2024

    @aaronliu0130
    ContributorAuthor

    Sorry, I meant schema 1.6.
    For example, if I have an old version of https://github.com/PckgrBot/winget-pkgs/blob/master/manifests/d/Discord/Discord/1.0.9034/Discord.Discord.installer.yaml installed and do winget upgrade Discord.Discord, winget will say

    The package cannot be upgraded using winget. Please use the method provided by the publisher for upgrading this package.
    

    WingetUI reports that as an error during updating, and replaces the package's icon with a yellow circle that has something in it. I think Winget should automatically skip that version of the package, replace the package's icon with the skip icon, send an appropriate notification, and persist the bottom status bar for that package (even across reboots) until the package is at the latest version or the user dismisses it.

  3. marticliment commented on Feb 23, 2024

    @marticliment
    Collaborator

    I see what you mean now. In my opinion, what I'd do is showing a custom error message, in the same way in which when a hash check fails or when the system requires a reboot the user gets warned about it, a custom error message explainig the issue could be shown, explaining to the user the situation and what should be done.

  4. aaronfilarca commented on Mar 8, 2024

    @aaronfilarca

    Would be nice if WingetUI will "Skip this version" when it receives ANY kind of error during upgrades

  5. aaronliu0130 commented on Mar 8, 2024

    @aaronliu0130
    ContributorAuthor

    I disagree. Errors usually need user intervention, and just ignoring it could make everything look up-to-date already

  6. aaronfilarca commented on Mar 8, 2024

    @aaronfilarca

    What I mean is- WingetUI should not retry to upgrade it again without user intervention. Not "Skip this version", but something similar.

  7. aaronliu0130 commented on Mar 8, 2024

    @aaronliu0130
    ContributorAuthor

    It might be environmental factors, such as having the application open, that can be eradicated on retry

  8. marticliment commented on Mar 8, 2024

    @marticliment
    Collaborator

    I agree with Aaron Liu (@aaronliu0130) about this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

new-featureA new feature that could be useful in WingetUIready-to-go

Type

No type

Projects

No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions