Skip to content

Time stamper cron - #1479

Merged
Alexj9837 merged 36 commits into
DiamondLightSource:time-stamper-cronfrom
Alexj9837:time-stamper-cron
Apr 9, 2026
Merged

Time stamper cron#1479
Alexj9837 merged 36 commits into
DiamondLightSource:time-stamper-cronfrom
Alexj9837:time-stamper-cron

Conversation

@Alexj9837

Copy link
Copy Markdown
Contributor

No description provided.

Alexj9837 and others added 30 commits April 1, 2026 13:29
* extra comment

* adding the bash script to config map, and pointing to it via the cronjob

* updating release tag

* was calling bin/bash not bin/sh and bitnami/kubectl doesn't have full bash

* updating version
* extra comment

* adding the bash script to config map, and pointing to it via the cronjob

* updating release tag

* was calling bin/bash not bin/sh and bitnami/kubectl doesn't have full bash

* updating version

* changing default mode as hitting perm errors

* update chart version
Alexj9837 and others added 6 commits April 9, 2026 09:14
* extra comment

* adding the bash script to config map, and pointing to it via the cronjob

* updating release tag

* was calling bin/bash not bin/sh and bitnami/kubectl doesn't have full bash

* updating version
* extra comment

* adding the bash script to config map, and pointing to it via the cronjob

* updating release tag

* was calling bin/bash not bin/sh and bitnami/kubectl doesn't have full bash

* updating version

* changing default mode as hitting perm errors

* update chart version
@Alexj9837
Alexj9837 requested a review from a team as a code owner April 9, 2026 09:55
@Alexj9837
Alexj9837 merged commit a88fa5d into DiamondLightSource:time-stamper-cron Apr 9, 2026
10 of 11 checks passed
@Alexj9837
Alexj9837 deleted the time-stamper-cron branch April 9, 2026 09:56
@codecov

codecov Bot commented Apr 9, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (time-stamper-cron@33726a6). Learn more about missing BASE report.

Additional details and impacted files
@@                 Coverage Diff                  @@
##             time-stamper-cron    #1479   +/-   ##
====================================================
  Coverage                     ?   95.21%           
====================================================
  Files                        ?       43           
  Lines                        ?     3132           
  Branches                     ?        0           
====================================================
  Hits                         ?     2982           
  Misses                       ?      150           
  Partials                     ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Alexj9837 added a commit that referenced this pull request May 1, 2026
merging personal branch to a new branch.

Add conditional cronjob and increase backoff limit

Refactor time-stamper.sh script inclusion in ConfigMap

Time stamper cron (#1479)

Change chart version from 1.13.0 to 0.1.0

removing not fit for purpose test

Update time-stamper.sh

removing the logic for if the pvc wasn't mounted. now only annotates mounted pvcs.

Base logic for pvc auto deletion

Sorting out the weekly cronjob for pvc auto deletion, also adding someting to value yaml to turn it off

Added Del perm

del s

changing name to be more readable

fix: if there isn't a last_used check if not null

Fix for time-stamper.sh as it was annotating all PVCs

pvc deletion test fix

removing test yaml

added affinity and tolerations to cronjobs

added an affinity to the cronjob.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant