Repository navigation
fix: upgrade tauri to 2.12 so a second dot x launch always exits - #277
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Everything below this line was written by AI. Agent: Claude Code. Model: Claude Opus 5.5.
Problem
Two copies of Dot X started in the same second at login, and both stayed running. The second copy couldn't create its webview, started its plugins anyway ("Frontend not ready after 10s; auto-starting plugins anyway"), and ran a second MQTT Publisher with the same client ID. The broker drops one session whenever the other connects, so MQTT reconnected every 5 seconds.
The cause is in
tauri-plugin-single-instance2.3.6 on Windows. The first instance creates its named mutex slightly before its message window. A second instance that starts in that gap sees the mutex, fails to find the window, and then neither exits nor takes the lock. On the affected machine, only the first process owned thecom.dot-x.dev-sicwindow. The second had no window and kept running.Solution
Upgrade to
tauri-plugin-single-instance2.5.5, which fixes this race (tauri-apps/plugins-workspace#3704): the second instance waits up to 1 s for the window and then always exits. 2.5.5 needs Tauri 2.12, so this also upgrades:taurito 2.12.5 andtauri-buildto 2.7.4@tauri-apps/apiand@tauri-apps/clito 2.12.4, so the CLI version check still passestauri-plugin-mcp-bridge(debug builds only) from 0.11 to 0.13.2, because 0.11 doesn't compile against thewebview2-comthat wry 0.57 usesVerification
cargo test --locked: 43 passed. The 11 warnings are existing dead-code and deprecation warnings.yarn check:capabilities,yarn typecheck,yarn build:web,yarn test:emulatorandyarn test:releasepass.yarn test:build-envfails withERR_LOAD_URLfor a tempprobe.ts. It fails the same way onmainon this Windows machine, so it's unrelated to this change.TAURI_CONFIG='{"identifier":"com.dot-x.racetest"}') so it couldn't touch the installed app. Launched three copies at once, 15 times. Every round, exactly one stayed running and the other two exited with code 0.yarn build, becausecargo-licenseisn't installed, sorust_licenses.jsonhasn't been regenerated for the new crates.🤖 Generated with Claude Code