Repository navigation
Add toggle to mute/maximize/do nothing when Decker is disconnected - #35
Merged
Andreas-Froyland merged 12 commits intoDec 10, 2023
Merged
Conversation
…ly volume after reconnecting decekr
… potentially happening when an app was set to max volume
Member
|
Sickkk it works perfectly! Awesome QOL improvement, at least for me. Great job on the frontend as well, it looks great🔥 |
Andreas-Froyland
approved these changes
Dec 10, 2023
Andreas-Froyland
deleted the
7-add-toggle-to-mute-channels-on-decker-disconect
branch
December 10, 2023 19:47
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This feature allows the user to change behavior for every slider when the Decker device is disconnected from Dot X.
The different actions available are:
When reconnecting the device, all volumes will be set to zero, before ramping up to the current slider value.
The reason the volumes are reset to zero before reverted to the correct value depending on the slider is because if you have selected the volume to maximize on decker disconnect, it will take a little while for it to get the correct values when reconnecting and there could be a small window of time where the volume is very loud. For example if you've set Spotify to maximize and master to mute, depending on how the sliders are positioned when reconnecting the device, you might experience a short screech. We don't want to scare our users.
However, if you haven't enabled the "Act when Decker disconnects", it will just set the volumes directly, because it's likely still synchronized with the computer.
This means that where you would previously have to move the sliders after reconnecting the device, it will now loop through the sliders when reconnecting and set it to the values of the sliders.
This feature is not available for MIDI outputs yet, tracked in #36
Side note: During testing I found a bug where the .init() call in the Decker singleton class created an endless amount of connect-change listeners when connecting and disconnecting the Decker device. This created issues in such a capacity that I decided to fix it in this PR.
Feel free to tweak, change text, layout, styling etc if you see anything you'd like to change @Andreas-Froyland.