Skip to content

Add toggle to mute/maximize/do nothing when Decker is disconnected - #35

Merged
Andreas-Froyland merged 12 commits into
mainfrom
7-add-toggle-to-mute-channels-on-decker-disconect
Dec 10, 2023
Merged

Andreas-Froyland merged 12 commits into
mainfrom
7-add-toggle-to-mute-channels-on-decker-disconect

Conversation

@RubenLarsen

@RubenLarsen RubenLarsen commented Dec 9, 2023 •

Copy link
Copy Markdown
Contributor

This feature allows the user to change behavior for every slider when the Decker device is disconnected from Dot X.

The different actions available are:

  • Do nothing - Volume stays whatever the last value is
  • Mute - Mute this channel
  • Maximize Volume - Set this channel volume to 100%

When reconnecting the device, all volumes will be set to zero, before ramping up to the current slider value.

The reason the volumes are reset to zero before reverted to the correct value depending on the slider is because if you have selected the volume to maximize on decker disconnect, it will take a little while for it to get the correct values when reconnecting and there could be a small window of time where the volume is very loud. For example if you've set Spotify to maximize and master to mute, depending on how the sliders are positioned when reconnecting the device, you might experience a short screech. We don't want to scare our users.

However, if you haven't enabled the "Act when Decker disconnects", it will just set the volumes directly, because it's likely still synchronized with the computer.

This means that where you would previously have to move the sliders after reconnecting the device, it will now loop through the sliders when reconnecting and set it to the values of the sliders.

This feature is not available for MIDI outputs yet, tracked in #36

Side note: During testing I found a bug where the .init() call in the Decker singleton class created an endless amount of connect-change listeners when connecting and disconnecting the Decker device. This created issues in such a capacity that I decided to fix it in this PR.

Feel free to tweak, change text, layout, styling etc if you see anything you'd like to change @Andreas-Froyland.

@Andreas-Froyland

Copy link
Copy Markdown
Member

Sickkk it works perfectly! Awesome QOL improvement, at least for me. Great job on the frontend as well, it looks great🔥

@Andreas-Froyland
Andreas-Froyland merged commit 7456724 into main Dec 10, 2023
@Andreas-Froyland
Andreas-Froyland deleted the 7-add-toggle-to-mute-channels-on-decker-disconect branch December 10, 2023 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add toggle to mute channel main on decker disconnect

2 participants