Fix repro-build fetch and dstack-mr cargo#74
Open
kvinwang wants to merge 2 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the meta-virtualization layer revision to pick up a fix for docker-compose builds where fetching github.com/moby/buildkit Go modules via proxy.golang.org can lead to do_fetch timeouts/failures in repro-build contexts. The intended outcome is more reliable module fetching by switching those BuildKit module downloads to a git-based approach (hybrid mode).
Changes:
- Bump the
meta-virtualizationsubmodule to a newer commit containing the docker-compose BuildKit fetch fix. - Adjust BuildKit Go module fetching behavior for
docker-composeto use git/hybrid mode instead ofproxy.golang.org.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
0000489 to
7d47fad
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
meta-virtualizationto include a docker-compose fetch fixgithubproxy.fjygbaifeng.eu.org/moby/buildkitGo modules via git in hybrid mode instead ofproxy.golang.orgmkimage.shcan builddstack-mrdstacksubmodule to the SEV-SNP branch containingdstack-mr sev-os-image-hashTesting
git -C meta-virtualization diff --checkgit ls-remote https://github.com/moby/buildkit.git refs/tags/v0.26.2^{} refs/tags/v0.27.1^{}docker build --platform linux/amd64 -t dstack-build-rustup-test -f repro-build/Dockerfile.repro repro-build/.dummydocker run --rm --userns=host --user $(id -u):$(id -g) dstack-build-rustup-test bash -lc 'cargo --version; rustc --version'docker run --rm --userns=host --user $(id -u):$(id -g) -v /home/kvin/src/meta-dstack:/meta-dstack -w /meta-dstack/dstack dstack-build-rustup-test bash -lc 'cargo build --release -p dstack-mr --target-dir /tmp/dstack-mr-target && /tmp/dstack-mr-target/release/dstack-mr --help'