Repository navigation
Improve generated code detection to look for <auto-generated> comments at top of file - #31
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Try this: string.Compare(s, startIndex, value, 0, value.Length, StringComparison.Ordinal) == 0
Contributor
|
👍 |
Owner
Author
|
@CyrusNajmabadi might also be interested in reviewing |
Contributor
There was a problem hiding this comment.
This check is redundant because string.Compare will do it too.
Owner
Author
There was a problem hiding this comment.
Sigh... thanks Paul. 😞
Contributor
|
👍 |
1. Fix unit tests that were written incorrectly and would always pass. 2. Use string.Compare rather than a custom Matches helper method.
DustinCampbell
force-pushed
the
issue-16
branch
from
August 25, 2015 22:38
ee9cfcd to
aee5744
Compare
DustinCampbell
added a commit
that referenced
this pull request
Aug 26, 2015
Improve generated code detection to look for <auto-generated> comments at top of file
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #16