Repository navigation
Conversation
Contributor
There was a problem hiding this comment.
Unnecessary newlines here
…he GeneratedCode attribute applied to a property, method, indexer, struct or event as well as classes & methods.
…tors & conversions.
Author
There was a problem hiding this comment.
Are there any other syntax kinds we need to check?
Owner
There was a problem hiding this comment.
Yup. You missed at least EventFieldDeclarations. Getting this right is hard. You might just try simple 'as' checks to BaseMethodDeclarationSyntax, BasePropertyDeclarationSyntax, BaseTypeDeclarationSyntax, etc. AttributeLists should be declared on those base types.
…s that may contain attributes.
…e is exactly System.CodeDom.Compiler.GeneratedCodeAttribute rather than a crude string Contains check.
Conflicts: Source/CSharpEssentials/Extensions.cs Source/CSharpEssentials/GetterOnlyAutoProperty/UseGetterOnlyAutoPropertyAnalyzer.cs Source/CSharpEssentials/UseExpressionBodiedMember/UseExpressionBodiedMemberAnalyzer.cs Source/CSharpEssentials/UseNameOf/UseNameOfAnalyzer.cs
…axNode, context) as it can be retreived from SyntaxNodeAnalysisContext.
…te for ExpressionBodiedMember & GetterOnlyAutoProperty analysers.
…GeneratedCodeAttribute.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #26.