Repository navigation
fix: default recurrenceUnit on team notification - #35
Merged
Eduardojvr merged 1 commit intoOct 15, 2026
Merged
Eduardojvr merged 1 commit into
Eduardojvr merged 1 commit into
Conversation
…validation error The enum mixin treats any enum field as required when undefined, so creating a non-recurring notification (recurrenceUnit omitted) failed with "recurrenceUnit is blank". Give it the same kind of default the severity field already has.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Same fix as #34, targeting homologacao directly since it's ahead of dev and already has the team notification feature.
recurrenceUnithas anenum, and the generic enum-validation mixin treats any enum field as required whenever its value is undefined — so creating a non-recurring team notification (whererecurrenceUnitis intentionally omitted) failed with "recurrenceUnit is blank".default: "h"the same wayseverityalready has one, so the field is never left undefined.Test plan
recurrenceUnitstill saves/behaves as selected.