Skip to content

fix(chart): authz deny-rate alert needs real traffic - #8

Merged
Mtze merged 1 commit into
mainfrom
fix/authz-deny-alert-volume
Nov 19, 2026
Merged

Mtze merged 1 commit into
mainfrom
fix/authz-deny-alert-volume

Conversation

@Mtze

@Mtze Mtze commented Nov 19, 2026 •

Copy link
Copy Markdown
Member

EduIDEAuthzDenyRateHigh fired on test3 ("Authz denies 100% of its decisions"). Cause: two browser tabs with IDEs of already deleted test sessions polled socket.io every 10 s and were denied as unknown-instance, about 200 times in 30 min, while nobody else used test3. No user was affected and authz worked correctly.

The same happens in production when a student leaves a tab open after the idle timeout at night. The alert now also requires more than 0.5 checks per second (and sum(rate(...)) > 0.5). The expression was checked in the test3 Prometheus: with the stale-tab volume (0.27/s) it returns nothing.

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Bug Fixes
    • Reduced false alerts for elevated authorization denials by requiring both a high denial ratio and a minimum decision rate.

Two stale IDE tabs of deleted sessions on test3 polled every 10 s, were denied
as unknown-instance and made 100% of the decisions, so EduIDEAuthzDenyRateHigh
fired with no user affected. The same happens in production when a student
leaves a tab open after the idle timeout at night. The alert now also needs
more than 0.5 checks per second.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Nov 19, 2026 •

Copy link
Copy Markdown

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The EduIDEAuthzDenyRateHigh alert now requires both a deny-decision ratio above 20% and a total decision rate above 0.5 per second over five minutes. Comments describe how polling from stale IDE tabs can skew the ratio.

Changes: Authorization alert

Layer / File(s) Summary
Deny-rate alert condition
charts/eduide-control-plane/files/alerts.yaml
The alert condition adds a total decision-rate threshold above 0.5 per second alongside the existing deny-ratio threshold above 20%. Comments describe stale-tab polling.

Estimated code review effort: 2 (Simple) | ~5 minutes

Change: Bug fix

Merge Risk: Minimal · up to b541a

The alert now ignores low-volume traffic, including stale-tab polling, while retaining detection above 0.5 checks per second. No conflicting detection requirement or actionable defect was established; the change is ready for normal checks.

Pre-merge checks: Passed 4

Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title names the main change: the authz deny-rate alert now needs real traffic. The raw summary confirms that EduIDEAuthzDenyRateHigh now also requires a total decision rate above 0.5 per second, a…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title names the main change: the authz deny-rate alert now needs real traffic. The raw summary confirms that EduIDEAuthzDenyRateHigh now also requires a total decision rate above 0.5 per second, and the PR objectives describe the same minimum traffic requirement. The title uses the conventional fix(chart) prefix and is specific enough for a teammate scanning history.

Finishing Touches

Generate unit tests (beta)

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: d6c05389-5592-4ac5-b6b9-48009aa68e00
Commits

Reviewing files that changed from the base of the PR and between 770716a and b541a3f.

Files selected for processing: 1

  • charts/eduide-control-plane/files/alerts.yaml

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

@Mtze
Mtze merged commit 507632c into main Nov 19, 2026
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant