Repository navigation
Conversation
This fixes VULN-001 reported in Egonex-AI#656. When `getChangedFiles()` executed `git diff ${lastCommitHash}..HEAD --name-only`, a malicious `lastCommitHash` containing git options could result in arbitrary file overwrite (e.g. using `--output=<file>`). This patch safely resolves and validates the revision using `git rev-parse --verify --end-of-options ${requestedGraphCommitHash}^{commit}` before running `git diff` with `--end-of-options` separation. Closes Egonex-AI#656
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #656
Description
This fixes the [VULN-001] Git Flag / Argument Injection in getChangedFiles vulnerability reported in #656.
The
getChangedFiles()function inunderstand-anything-plugin/packages/core/src/staleness.tsexecutedgit diff ${lastCommitHash}..HEAD --name-onlyviaexecFileSyncwithout revision verification or--end-of-optionsseparation. A malicious graph metadata file could setgitCommitHashto a value starting with--output=to trigger arbitrary file creation or overwriting.This patch resolves the commit hash first using
git rev-parse --verify --end-of-options ${lastCommitHash}^{commit}and then uses--end-of-optionsduring thegit diffcommand.(Note: VULN-002 mentioned in the same issue report has already been addressed by the maintainer in the plugin prompts).