Add Loadout Manager (InstanceGearSwap) as a packaged sibling addon - #1663
Open
dfrisone wants to merge 1 commit into
Open
Add Loadout Manager (InstanceGearSwap) as a packaged sibling addon#1663dfrisone wants to merge 1 commit into
dfrisone wants to merge 1 commit into
Conversation
Standalone gear/talent auto-swap addon by Isaac, integrated with the EllesmereUI skinning facade (SKINNING_API). Folder and SavedVariables keep the InstanceGearSwap name so existing user data carries over. Review fixes on top of the submitted build: ASCII bullets in the Saved Mappings text, TOC author/Interface (12.0.7/12.1), trimmed an over-budget comment block, neutral wording in /lm gc output.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds Isaac's Loadout Manager (folder
InstanceGearSwap) as a packaged sibling addon: spec-aware Blizzard gear-set and talent-loadout auto-swapping per instance/difficulty/content type, skinned through the public SKINNING_API facade. Folder and SavedVariables keep the InstanceGearSwap name so existing user data carries over.Review: style gate clean after fixes (ASCII bullets, comment budget, TOC author, Interface 120007/120100). No OnUpdate polling, event work coalesced, zero cost unless the addon is installed. All C_ClassTalents/C_EquipmentSet APIs and LoadConfigResult fallbacks verified against 12.1 source.
Taint: the one area worth an in-game pass is SyncTalentUI, which writes selection state into Blizzard's talent frame after LoadConfig; benign out of combat, but verify the talent window still behaves after an auto-swap with it open.
Left alone: GameTooltip-based rich tooltips (addon must run standalone without EUI, suppressed with reason); "Copy from..." replaces rather than merges the destination scope; window has no Escape-to-close.
Test: assign a gear set + loadout to a dungeon in /lm, zone in, confirm both swap and the equip verification message; /lm now re-runs it manually.