Nameplates: recognise Rogue Shiv as an Enrage dispel (fixes #1299) - #1705
Open
Laxxzz wants to merge 1 commit into
Open
Nameplates: recognise Rogue Shiv as an Enrage dispel (fixes #1299)#1705Laxxzz wants to merge 1 commit into
Laxxzz wants to merge 1 commit into
Conversation
The enemy-nameplate dispel indicator did not treat a Rogue's Shiv as an Enrage removal, so a Rogue got no dispel glow on a removable Enrage and the buff was filtered out when "Show All Enemy Buffs" was off. Shiv (5938) carries a Dispel (Enrage) effect but was missing from OFFENSIVE_DISPEL_SPELLS, leaving canDispelEnrage false for every Rogue. The third field is left nil rather than "ROGUE". A non-nil third field without a fourth routes the lookup to the PET spellbook, which is what Devour Magic needs and what Shiv must not have; "ROGUE" would search the pet bank and never resolve. The player-bank lookup is already class-safe, since no other class knows 5938 - the same shape Soothe, Purge and Spellsteal use. Both consumers read this one table through ns.GetOffensiveDispelTypes, so the capability-based aura path and the aura-container purge glow are fixed together. Fixes EllesmereGaming#1299 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Rogues now get the enemy-nameplate dispel indicator on removable Enrage effects.
Previously a Rogue saw no dispel glow on an Enrage, and with "Show All Enemy Buffs"
off the buff was filtered out of the nameplate entirely, because the addon did not
consider Shiv an Enrage removal.
Shiv (5938) carries a Dispel (Enrage) effect but was absent from
OFFENSIVE_DISPEL_SPELLS, socanDispelEnragestayed false for every Rogue. Onetable entry.
Note on the third field: it is left
nilrather than"ROGUE". A non-nil thirdfield with no fourth routes the lookup to the pet spellbook (what Devour Magic
needs), so
"ROGUE"would search the pet bank and never resolve. The player-banklookup is already class-safe, since no other class knows 5938 - the same shape
Soothe, Purge and Spellsteal use.
Both consumers read this table through
ns.GetOffensiveDispelTypes, so thecapability-based aura path and the aura-container purge glow are fixed together.
Separately, and deliberately not changed here: the table's header comment documents
field 3 as
requiredClass or nil, which does not describe the pet-bank behavior.That mismatch is what led the issue reporter to suggest
"ROGUE". Might be worth acomment fix in a separate pass.
Fixes #1299
How was it tested?
Live 12.1 client, deployed over the installed build. Verified on a Rogue with Shiv
that a removable Enrage on an enemy now shows on the nameplate and carries the
configured dispel glow, with Dispel Glow on and Show All Enemy Buffs off. Confirmed
working in game before opening this PR.
Screenshots
Before:
After:
Checklist
hooks, frames or allocations
SPELLS_CHANGED / UNIT_PET / TRAIT_CONFIG_UPDATED rebuild