Honor HasConversion<T>() for non-key reference properties in source-generated mappers

[Copilot]

HasConversion<T>() was not reliably applied to non-ID reference-type properties (e.g., SmartEnum-style types), so values could be serialized/deserialized through nested-object logic instead of the configured converter. This caused incorrect round-trips for properties like Gender.

• Generator fix: converter precedence

  • Updated source-generator mapper emission so non-key properties with ConverterTypeName are handled before nested-object/primitive branches.
  • Applied this precedence in both write and read paths:
    • GenerateWriteProperty(...)
    • GenerateReadPropertyToLocal(...)
  • Result: explicit fluent conversion now consistently controls persistence for supported provider types.

• Regression coverage for SmartEnum-like scenario

  • Added a focused non-ID reference-type converter case:
    • DeviceWithSmartStatus
    • SmartStatus + SmartStatusConverter : ValueConverter<SmartStatus, string>
  • Wired model config through fluent API:
    • .Property(x => x.Status).HasConversion<SmartStatusConverter>()
  • Added round-trip assertion ensuring canonical value restoration (SmartStatus.Active) rather than nested-object materialization behavior.

modelBuilder.Entity<DeviceWithSmartStatus>()
    .ToCollection("devices_with_smart_status")
    .Property(x => x.Status)
    .HasConversion<SmartStatusConverter>();

• Fixes the ValueConverter isn't work #145

[mrdevrobot]

@copilot I'd rather update the unit test with a SmartEnum more similar to the one presented by the issue opener.

[Copilot]

@copilot I'd rather update the unit test with a SmartEnum more similar to the one presented by the issue opener.

Updated in commit b160aa4. The regression now uses Ardalis.SmartEnum with a Gender : SmartEnum<Gender> model (Male=3, Female=5) and GenderValueConverter, matching the issue opener’s pattern more closely.

[Copilot]

🟡 Changes recommended

Unresolved converter ordering, null-handling, and numeric-cast issues remain in generated mapper code.

Get a fresh assessment by requesting another Copilot review.

Pull request overview

This PR updates source-generated mappers so explicit HasConversion<T>() takes precedence for non-key reference properties, with SmartEnum-style regression coverage.

Changes:

• Reorders converter handling in write/read generation.
• Adds SmartEnum fixtures, configuration, and round-trip testing.
• Adds the supporting test dependency.

File summaries

File	Description
tests/BLite.Tests/SourceGeneratorFeaturesTests.cs	Adds SmartEnum round-trip coverage.
tests/BLite.Shared/TestDbContext.cs	Registers the test collection and converter.
tests/BLite.Shared/MockEntities.cs	Adds SmartEnum test models and converter.
tests/BLite.Shared/BLite.Shared.csproj	Adds the SmartEnum package dependency.
src/BLite.SourceGenerators/CodeGenerator.cs	Updates converter precedence and generated mapper emission.

Review details

Suppressed comments (1)

src/BLite.SourceGenerators/CodeGenerator.cs:860

• The read path has the same nullability mismatch for nonnullable-declared reference properties. If the stored value is BSON null, it calls ReadString()/the provider reader without a null check; ReadString expects a string length and throws. Mirror the write-side reference-type guard here.

                     if (prop.IsNullable)

• Files reviewed: 5/5 changed files
• Comments generated: 3
• Review effort level: Lite

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.