Skip to content

Add offline browser policy and PDF device emulation - #435

Merged
PrzemyslawKlys merged 5 commits into
v2-speedygonzalesfrom
feature/browser-pdf-device-emulation
Aug 24, 2026
Merged

PrzemyslawKlys merged 5 commits into
v2-speedygonzalesfrom
feature/browser-pdf-device-emulation

Conversation

@PrzemyslawKlys

@PrzemyslawKlys PrzemyslawKlys commented Aug 24, 2026 •

Copy link
Copy Markdown
Member

Summary

  • add device-scale, mobile-layout, and touch emulation to each isolated browser PDF context without breaking the released constructor contract
  • add a fail-closed offline policy that owns Chromium network isolation, blocks DNS and bypass transports, and still supports locally fulfilled HTML documents at an HTTP origin
  • preserve URI-credential enforcement and keep header, popup, worker, and subsequent-resource paths inside the same network boundary
  • document the public contracts, add contract and live Chromium coverage, and prepare HtmlTinkerX and PSParseHTML 3.0.1

Validation

  • full HtmlTinkerX net8.0 suite: 1,240 passed
  • affected offline/header contract and live tests: 6 passed on each of net472, net8.0, and net10.0
  • canonical PowerForge build completed with signed package payload verification and publishing disabled
  • generated HtmlTinkerX 3.0.1 NuGet and PSParseHTML 3.0.1 module artifacts are provenance-bound to commit 0aa2919

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 165aa40c2f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread Sources/HtmlTinkerX/Models/HtmlBrowserNetworkPolicy.cs
Comment thread Sources/HtmlTinkerX/Models/HtmlBrowserPdfRendererOptions.cs Outdated
Comment thread Sources/HtmlTinkerX/Models/HtmlBrowserNetworkPolicy.cs Outdated
@codecov

codecov Bot commented Aug 24, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 96.26866% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 54.22%. Comparing base (25acf67) to head (0aa2919).

Files with missing lines Patch % Lines
...rX/Playwright/HtmlBrowserNetworkPolicyEvaluator.cs 50.00% 0 Missing and 3 partials ⚠️
...tmlTinkerX/Models/HtmlBrowserPdfRendererOptions.cs 97.29% 0 Missing and 1 partial ⚠️
...X/Playwright/HtmlBrowserScopedHeaderInterceptor.cs 85.71% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@                  Coverage Diff                  @@
##           v2-speedygonzales     #435      +/-   ##
=====================================================
+ Coverage              54.07%   54.22%   +0.14%     
=====================================================
  Files                    461      462       +1     
  Lines                  34808    34913     +105     
  Branches                6999     7009      +10     
=====================================================
+ Hits                   18824    18930     +106     
+ Misses                 13755    13753       -2     
- Partials                2229     2230       +1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 08647c5a31

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread Sources/HtmlTinkerX/Playwright/HtmlBrowserPdfRenderer.Capture.cs Outdated
Comment thread Sources/HtmlTinkerX/Playwright/HtmlBrowserPdfRenderer.Capture.cs Outdated
@PrzemyslawKlys
PrzemyslawKlys merged commit 211dc6f into v2-speedygonzales Aug 24, 2026
17 checks passed
@PrzemyslawKlys
PrzemyslawKlys deleted the feature/browser-pdf-device-emulation branch August 24, 2026 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant