You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
No page count when expense is submitted from self DM and receipt is added on confirm page #100375
Version Number: 9.4.72-0 Reproducible in staging?: Yes Reproducible in production?: N/A - new feature, doesn't exist in prod If this was caught during regression testing, add the test name, ID and link from BrowserStack:#97813 Email or phone of affected tester (no customers):jsdoijnodsdisojo@gmail.com Issue reported by: Applause Internal Team Bug source: Exploratory - Significant User Experience Deterioration Device used: Mac 26.5 / Chrome App Component: Money Requests
Action Performed:
Go to staging.new.expensify.com
Go to self DM.
Create a manual expense without receipt.
Click Submit to a friend.
Select workspace chat.
On confirm page, add a multi page PDF receipt.
Click Create expense.
Open the expense.
Expected Result:
Page count will appear on receipt preview when expense is submitted from self DM and receipt is added on confirm page.
Actual Result:
Page count does not appear on receipt preview when expense is submitted from self DM and receipt is added on confirm page.
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Classification: Frontend bug Causing PR: #97813 - "Show a page count badge on multi-page PDF receipts" by @ishpaul777 (High confidence) Related Issues: #100350, #100336, #100342 — three other open blockers on this same checklist, all from #97813
Recommendation: REVERT
The page count badge shipped wired up for a single expense-creation path, and this is the fourth deploy blocker on 9.4.72-0 from that one PR; patching each remaining flow individually needs backend work too and keeps growing under deploy-blocker time pressure. Reverting #97813 removes a badge that never existed in production, so nothing regresses, and it clears #100336, #100342, #100350 and this issue at once.
Assigned: @ishpaul777 (PR author), @MonilBhavsar and @abzokhattab (approving reviewers) from the causing PR — already assigned by melvin-bot, no change made. Labels: No changes. DeployBlockerCash stays (an App PR caused this); DeployBlocker was not present and was not added.
gh pr view 97813 --json files confirms the PR modifies the first two and not the last two — which is precisely the gap.
Root Cause
The badge only renders when transaction.receipt.pageCount > 1. The client never computes that value; it is backend-provided (as #97813's own description says, the badge is inert until its backend dependencies ship). #97813 plumbed it for the ordinary "upload a receipt onto an expense" path only, so every other way an expense can acquire a receipt drops it:
A latent second copy of the bug on the same flow. Even when a page count is already present, the conversion discards it client-side: buildOptimisticTransaction rebuilds receipt as {source, filename, state, isTestDriveReceipt}, and that rebuilt transaction is written with Onyx.METHOD.SET at MoneyRequestBuilder.ts#L605-L608, replacing the stored receipt wholesale. Prediction worth testing: create the self-DM expense with the multi-page PDF (badge shows), then submit it to a workspace chat — the badge should disappear.
Rolling forward means fixing both halves, on this flow and on every other creation path, with backend changes for each. Given the feature is brand new, cosmetic, and invisible in production, reverting #97813 and relanding it once the count survives all creation paths is the lower-risk option.
Activity
applause-bot commentedon Sep 4, 2026
While Applause doesn't embed attachments for this bug, here are the links for quick view:
https://platform.applause.com/services/links/v1/external/3401afb1baa5d63335b5d0181957a558eabbbce1bd69ce78f289c3066519a30c
melvin-bot commentedon Sep 4, 2026
You have been assigned to this deploy blocker because you recently merged this PR: #97813
melvin-bot commentedon Sep 4, 2026
@MonilBhavsar @abzokhattab you have been assigned to this deploy blocker because you reviewed the offending PR: #97813
melvin-bot commentedon Sep 4, 2026
@ishpaul777 you have been assigned to this deploy blocker because you authored the offending PR: #97813
melvin-bot commentedon Sep 4, 2026
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Sep 4, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
MelvinBot commentedon Sep 4, 2026
🔍 Investigation Summary
Classification: Frontend bug
Causing PR: #97813 - "Show a page count badge on multi-page PDF receipts" by @ishpaul777 (High confidence)
Related Issues: #100350, #100336, #100342 — three other open blockers on this same checklist, all from #97813
Recommendation: REVERT
The page count badge shipped wired up for a single expense-creation path, and this is the fourth deploy blocker on
9.4.72-0from that one PR; patching each remaining flow individually needs backend work too and keeps growing under deploy-blocker time pressure. Reverting #97813 removes a badge that never existed in production, so nothing regresses, and it clears #100336, #100342, #100350 and this issue at once.Assigned: @ishpaul777 (PR author), @MonilBhavsar and @abzokhattab (approving reviewers) from the causing PR — already assigned by melvin-bot, no change made.
Labels: No changes.
DeployBlockerCashstays (an App PR caused this);DeployBlockerwas not present and was not added.📋 Detailed Analysis
Evidence
2026-09-03 18:04 UTCand is on the9.4.72-0checklist (Deploy Checklist: New Expensify 2026-09-03 #100332); this bug was filed ~11h later against that exact version. Not reproducible in production because the badge does not exist there — consistent with "N/A - new feature".grep -rn "receipt.*pageCount" srcreturns exactly one consumer:MoneyRequestReceiptView.tsx#L203, gated at#L559-L560and rendered at#L718-L723. No other PR on this checklist touches receipts, transactions orpageCount.MoneyRequestReceiptView.tsxsince 2026-09-01, so the revert is clean. The only follow-up, Show receipt page count badge for split expenses #100361, is still open and scoped to the split flow (it does not fix these repro steps).Verification
Affected files, all confirmed against
ae9d6a6:src/components/ReportActionItem/MoneyRequestReceiptView.tsx— added by [Payment due @abzokhattab] Show a page count badge on multi-page PDF receipts #97813, the sole render site of the badge.src/types/onyx/Transaction.ts#L273-L278—receipt.pageCountadded by [Payment due @abzokhattab] Show a page count badge on multi-page PDF receipts #97813.src/libs/TransactionUtils/index.ts#L563-L565—buildOptimisticTransactionrebuildsreceiptfrom a four-field whitelist that [Payment due @abzokhattab] Show a page count badge on multi-page PDF receipts #97813 never updated.src/libs/actions/IOU/TrackExpense.ts#L1816-L1824— the path these repro steps take: the confirm-page receipt is attached to the tracked-expense conversion, not to a normal receipt upload.gh pr view 97813 --json filesconfirms the PR modifies the first two and not the last two — which is precisely the gap.Root Cause
The badge only renders when
transaction.receipt.pageCount > 1. The client never computes that value; it is backend-provided (as #97813's own description says, the badge is inert until its backend dependencies ship). #97813 plumbed it for the ordinary "upload a receipt onto an expense" path only, so every other way an expense can acquire a receipt drops it:TrackExpense.ts#L1816-L1824) rather than through the standard receipt-upload path, so the created expense comes back without a page count and the> 1gate atMoneyRequestReceiptView.tsx#L560never passes. This is the same class of gap @ishpaul777 already found for split bills in [Due for payment 2026-09-30] Expense - No page count on multi page PDF receipt when created from split scan expense #100350, on a different command.buildOptimisticTransactionrebuildsreceiptas{source, filename, state, isTestDriveReceipt}, and that rebuilt transaction is written withOnyx.METHOD.SETatMoneyRequestBuilder.ts#L605-L608, replacing the stored receipt wholesale. Prediction worth testing: create the self-DM expense with the multi-page PDF (badge shows), then submit it to a workspace chat — the badge should disappear.Rolling forward means fixing both halves, on this flow and on every other creation path, with backend changes for each. Given the feature is brand new, cosmetic, and invisible in production, reverting #97813 and relanding it once the count survives all creation paths is the lower-risk option.
view run
MonilBhavsar commentedon Sep 4, 2026
New feature, so demoting
ishpaul777 commentedon Sep 5, 2026
https://github.com/Expensify/Web-Expensify/pull/55918 raised PR to fix this
MonilBhavsar commentedon Sep 8, 2026
Thanks!
PR was merged
melvin-bot commentedon Sep 15, 2026
@MonilBhavsar, @abzokhattab, @ishpaul777 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
melvin-bot commentedon Sep 17, 2026
@MonilBhavsar, @abzokhattab, @ishpaul777 Huh... This is 4 days overdue. Who can take care of this?
melvin-bot commentedon Sep 21, 2026
@MonilBhavsar, @abzokhattab, @ishpaul777 8 days overdue is a lot. Should this be a Weekly issue? If so, feel free to change it!
ishpaul777 commentedon Sep 22, 2026
this was fixed, closing