Skip to content

Getting Started footer link opens a second RHP instead of focusing the open Concierge Side Panel #100388

Closed

Description

@MelvinBot

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Sign up and complete onboarding with an intent that creates Getting Started tasks.
  2. Open Concierge in the RHP using the conci button in the top right corner.
  3. On the home page, click Need help? Talk to Concierge for guided setup. in the Getting Started section footer.

Expected Result:

It should focus the existing RHP with Concierge.

Actual Result:

It opens a second RHP with Concierge.

Platforms:

Web (wide layout / Side Panel surface).

Image

Analysis (medium confidence — from reading the code, not a repro)

Root cause: the Getting Started footer link navigates with the router instead of reusing the already-open Side Panel, so you end up with two panes showing the same conversation.

The footer's onPress calls openAdminsRoom, which on wide screens always runs Navigation.navigate(ROUTES.SEARCH_REPORT…) — src/pages/home/GettingStartedSection/index.tsx:35-49. It never checks whether the Side Panel (the conci button pane) is already open.

The Side Panel shows the #admins room for the rhpAdminsRoom / rhpHomePage onboarding variants and the Concierge DM otherwise — src/components/SidePanel/SidePanelContextProvider.tsx:96. So in this flow the link re-opens the exact chat that is already on screen, as a separate RHP.

The pattern that already handles this correctly is useOpenConciergeAnywhere, which bails out when shouldHideSidePanel is false rather than pushing a new screen.

Suggested fix: in GettingStartedSection, read useSidePanelState() and useSidePanelReportID(). If the Side Panel is open and already showing the target reportID, call openSidePanel() (a no-op focus) instead of Navigation.navigate. Narrow-layout behavior can stay as-is.

Reported by @garrettmknight via DM with MelvinBot.

Issue OwnerCurrent Issue Owner: @QichenZhu

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    ExternalAdded to denote the issue can be worked on by a contributor
    on Sep 4, 2026
  2. melvin-bot commented on Sep 4, 2026

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @QichenZhu (External)

  3. melvin-bot commented on Sep 4, 2026

    @melvin-bot

    Unable to auto-create job on Upwork. The BZ team member should create it manually for this issue.

  4. QichenZhu commented on Sep 4, 2026

    @QichenZhu
    Contributor

    @MelvinBot please post a proposal.

  5. MelvinBot commented on Sep 4, 2026

    @MelvinBot
    ContributorAuthor

    Updated 2026-09-04: Corrected based on feedback from QichenZhu.

    Proposal

    What is the root cause of that problem?

    The Getting Started footer link has no awareness of the Side Panel.

    openAdminsRoom on a wide layout unconditionally pushes a new navigator screen — src/pages/home/GettingStartedSection/index.tsx:43-48. The Side Panel that the conci button opens is a separate surface rendered outside that navigator, so nothing dedupes the two. You end up with the navigator RHP and the Side Panel on screen at once, both showing the same conversation.

    They are the same conversation because the section only renders for workspace admins, and the Side Panel resolves to that same #admins room for the rhpAdminsRoom / rhpHomePage onboarding variants — src/components/SidePanel/SidePanelContextProvider.tsx:94.

    Supporting evidence
    • The admin gate on the section: useGettingStartedItems.ts:157.
    • The Side Panel is only mounted as a sibling of the navigator content, keyed off shouldHideSidePanel — src/components/SidePanel/index.tsx. Nothing in the router consults it.
    • Every other "talk to help" entry point already routes through useOpenConciergeAnywhere instead of pushing a screen. This link is the only one that doesn't.
    • Second symptom from the same cause: for any other onboarding variant the Side Panel resolves to the Concierge DM while this link still opens #admins. Then the two panes show two different chats.

    What changes do you think we should make in order to solve the problem?

    Make the footer link use the Side Panel as its help surface on wide layouts, instead of the router. In GettingStartedSection, replace the Navigation.navigate(ROUTES.SEARCH_REPORT…) branch with two cases:

    • Side Panel closed → openSidePanel().
    • Side Panel already open on the target report → focus its composer via ReportActionComposeFocusManager.sidePanelComposerRef, the ref the Side Panel composer registers itself into at ComposerWithSuggestions.tsx:812-818 — but only when canFocusInputOnScreenFocus() is true. On mobile and any touch device the click stays a no-op, so the soft keyboard never pops open.

    Leave the shouldUseNarrowLayout branch untouched. Native never reaches the wide branch, so no platform-specific work is needed.

    Why the already-open case needs an explicit focus call

    Reusing useOpenConciergeAnywhere unchanged is not enough. It returns early when shouldHideSidePanel is false, so the click would become a complete no-op — no focus, no scroll, no state change. Even without that early return, openSidePanel only merges {open: true} into the NVP (SidePanel.ts:10-12), which is already true when the panel is open. There is no "focus the Side Panel" behavior anywhere today; the only composer-focus call in the Side Panel code runs on close and targets the main composer (SidePanelContextProvider.tsx:148).

    Three implementation caveats:

    • Never focus on mobile. canFocusInputOnScreenFocus() is false on native and !canUseTouchScreen() on web, and it is the same gate the composer's own shouldAutoFocus already uses (ComposerWithSuggestions.tsx:399). Reuse it rather than checking the layout, so a tablet in landscape or a touchscreen laptop — wide layout, touch input — is covered too.
    • sidePanelComposerRef is populated from the composer's own onFocus handler (handleFocus), so it is null until the user has focused that composer at least once. Handle that case rather than assuming the ref is set.
    • ReportActionComposeFocusManager.focus() is not usable here — it bails when the focused route isn't a report screen (ReportActionComposeFocusManager.ts:52-56), and on Home it isn't.

    The openSidePanel() branch needs no extra guard: the Side Panel composer decides its own auto-focus through that same shouldAutoFocus, so opening the panel already does not raise the keyboard on mobile.

    One consequence worth confirming with the issue owner: because the Side Panel chooses the report, users on onboarding variants other than rhpAdminsRoom / rhpHomePage would land on Concierge rather than #admins. That matches the link's own copy ("Talk to Concierge"), and it removes the mismatched-pane symptom above — but it is a behavior change, not just a de-duplication.

    What alternative solutions did you explore? (Optional)

    Guard the navigate instead of replacing it. Read useSidePanelState() and useSidePanelReportID() in GettingStartedSection, and skip Navigation.navigate when the panel is open and already showing adminsRoomReportID — the pattern useAskConcierge uses. Smaller and preserves today's target report exactly, but it only fixes the duplicate-pane case and leaves the mismatch case (panel on Concierge, link on #admins) still opening a second pane.

    Close the Side Panel before navigating. Fixes the visual duplication but is worse UX — it tears down the pane the user just opened and moves the conversation to a different surface.

    I could not reproduce this live, so this is based on reading the code rather than on a repro. The confidence on the root cause is high: the Navigation.navigate call at line 48 has no Side Panel condition of any kind.


    Next Steps for Contributor+ team:
    To accept: @MelvinBot implement [this](https://github.com/Expensify/App/issues/100388#issuecomment-5541533618) to create a draft PR.
    To refine: @MelvinBot <your feedback>
    To reject: Explain why you are rejecting Melvin's proposal.

  6. QichenZhu commented on Sep 4, 2026

    @QichenZhu
    Contributor

    so the open pane simply stays focused

    @MelvinBot it's not accurate.

  7. MelvinBot commented on Sep 4, 2026

    @MelvinBot
    ContributorAuthor

    You're right, that wording is wrong. Nothing gets focused — the click becomes a complete no-op.

    useOpenConciergeAnywhere returns early when shouldHideSidePanel is false — useOpenConciergeAnywhere/index.tsx:17-19. No focus call, no scroll, no state change. And even without that early return it still wouldn't focus anything: openSidePanel only merges {open: true} into the NVP — SidePanel.ts:10-12 — and that is already true when the panel is open.

    There is no "focus the Side Panel" behavior anywhere today. The only composer-focus call in the Side Panel code runs on close, and it targets the main composer — SidePanelContextProvider.tsx:148.

    That matters for this issue, because the Expected Result is "focus the existing RHP". Dropping in useOpenConciergeAnywhere unchanged removes the duplicate pane but leaves the link doing literally nothing when the panel is already open — no feedback at all.

    Corrected solution

    Same shape as before, but the already-open branch has to focus explicitly rather than return:

    • Panel closed → openSidePanel().
    • Panel already open on the target report → focus its composer via ReportActionComposeFocusManager.sidePanelComposerRef, the ref the Side Panel composer registers itself into at ComposerWithSuggestions.tsx:812-818.
    • Never Navigation.navigate on wide layouts.

    One caveat on that ref: it is populated from the composer's own onFocus handler (handleFocus), so it is null until the user has focused that composer at least once. The implementation needs to handle that case rather than assume the ref is set.

    ReportActionComposeFocusManager.focus() is not usable here — it bails when the focused route isn't a report screen (ReportActionComposeFocusManager.ts:52-56), and on Home it isn't.

    The root cause in the proposal is unchanged. I have edited the original comment so the inaccurate sentence isn't left standing.


    Next Steps for Contributor+ team:
    To accept: @MelvinBot implement [this](https://github.com/Expensify/App/issues/100388#issuecomment-5541533618) to create a draft PR.
    To refine: @MelvinBot <your feedback>
    To reject: Explain why you are rejecting Melvin's proposal.


    view run · view recording

  8. QichenZhu commented on Sep 4, 2026

    @QichenZhu
    Contributor

    @MelvinBot we don't want to focus the composer on mobile.

  9. MelvinBot commented on Sep 4, 2026

    @MelvinBot
    ContributorAuthor

    Agreed — the focus call has to be gated on canFocusInputOnScreenFocus(). On mobile the already-open click stays a no-op.

    That is the same gate the composer already uses for exactly this reason — shouldAutoFocus at ComposerWithSuggestions.tsx:399, guarding the block whose own comment says the software keyboard popping open "creates a jarring and broken UX" (lines 938-941). It returns false on native and !canUseTouchScreen() on web, so reusing it also covers a tablet in landscape or a touchscreen laptop — wide layout, touch input — which a plain shouldUseNarrowLayout check would miss.

    Worth noting the mobile path is doubly safe here: native always reports shouldUseNarrowLayout, so it never reaches the wide branch at all, and on a narrow layout the Side Panel renders full-width (SidePanelContextProvider.tsx:69), so the footer link isn't even reachable while the panel is open. The guard still belongs in the code for the touch-in-wide-layout case.

    The openSidePanel() branch needs nothing extra — the Side Panel composer decides its own auto-focus through that same shouldAutoFocus, so opening the panel already doesn't raise the keyboard on mobile.

    I have updated the proposal above with this gate.


    Next Steps for Contributor+ team:
    To accept: @MelvinBot implement [this](https://github.com/Expensify/App/issues/100388#issuecomment-5541533618) to create a draft PR.
    To refine: @MelvinBot <your feedback>
    To reject: Explain why you are rejecting Melvin's proposal.


    view run · view recording

  10. QichenZhu commented on Sep 4, 2026

    @QichenZhu
    Contributor

    @MelvinBot should the link go to Concierge or #admin?

  11. MelvinBot commented on Sep 4, 2026

    @MelvinBot
    ContributorAuthor

    Neither — it should go wherever the Side Panel is pointing, because the app already has an answer to this question and it isn't a constant.

    SidePanelContextProvider.tsx:94 resolves #admins for the rhpAdminsRoom / rhpHomePage onboarding variants when the user is an admin of an active policy, and Concierge for everyone else. That split is a live A/B experiment over where the guided-setup conversation lives (ONBOARDING_RHP_VARIANT). Hardcoding the footer link to either room fights that experiment and is exactly what produces this bug.

    Today the link hardcodes #admins — Expensify/App#94698 says so outright ("the help link opens the #admins room in the RHP"). So a user on rhpConciergeDm or trackExpensesWithConcierge gets the panel on Concierge and the link on #admins: two panes, two different chats.

    The copy points the same way. The link reads "Talk to Concierge" by default (index.tsx:51); nothing in it mentions #admins.

    So openConciergeAnywhere() gives the right target for free. Versus today: rhpAdminsRoom / rhpHomePage admins keep #admins, everyone else moves to Concierge — which is what the copy already promises them.

    One thing I can't answer from the code

    When a Guide is assigned the copy switches to "Talk to your account executive", but the Side Panel never targets the Guide DM — it only ever picks #admins or Concierge. The Settings → Help page does DM the Guide directly for its equivalent row (HelpPage.tsx:105).

    Whether Guides are reachable in #admins is a backend/ops question I can't verify from the App repo. If the intent is a direct line to the Guide, that's a separate product decision from this bug.


    Next Steps for Contributor+ team:
    To accept: @MelvinBot implement [this](https://github.com/Expensify/App/issues/100388#issuecomment-5541533618) to create a draft PR.
    To refine: @MelvinBot <your feedback>
    To reject: Explain why you are rejecting Melvin's proposal.


    view run · view recording

  12. QichenZhu commented on Sep 4, 2026

    @QichenZhu
    Contributor

    @MelvinBot but from the OP's screenshot, the Concierge button goes to Concierge, and the link goes to #admin.

  13. 9 remaining items

  14. QichenZhu commented on Sep 12, 2026

    @QichenZhu
    Contributor

    @Expensify/product @Expensify/design, would love your thoughts on these questions:

    1. The link says Talk to Concierge, but it opens #admins. Is the text wrong, or is the destination wrong?

      100388.mov
    2. Is it a bug to have two side panels, for example, if I open #admins first and then click Concierge (the opposite of the OP's steps)?

      100388b.mov

    Thanks!

  15. dubielzyk-expensify commented on Sep 14, 2026

    @dubielzyk-expensify
    Contributor

    The link says Talk to Concierge, but it opens #admins. Is the text wrong, or is the destination wrong?

    Good shout. If we can know what thread it's gonna pull up then it'd be nice to signal that or maybe even better is to just make it generic, something like:
    Need help? _Get help_ for guided setup

    Is it a bug to have two side panels, for example, if I open #admins first and then click Concierge (the opposite of the OP's steps)?

    I think this is technically correct even though it feels super unpolished. Curious what the others think. I dunno how we'd reliably remove the Conci icon in the admins room for the RHP only though

  16. shawnborton commented on Sep 14, 2026

    @shawnborton
    Contributor

    If we can know what thread it's gonna pull up then it'd be nice to signal that or maybe even better is to just make it generic, something like:

    Agree, thoughts on that @flaviadefaria ?

    I think this is technically correct even though it feels super unpolished.

    Agree. I guess given that you can easily summon Concierge in #admins room, we could consider just never showing the Concierge icon when in the #admins room. Curious what other product folks think about that though.

  17. flaviadefaria commented on Sep 14, 2026

    @flaviadefaria
    Contributor

    Agree, thoughts on that @flaviadefaria ?

    Generic is fine with me, though the current distinction between Concierge and Account Executive is based on the customer’s intent/size. We only display “Account Executive” when the customer has been assigned to a Guide.

    Agree. I guess given that you can easily summon Concierge in #admins room, we could consider just never showing the Concierge icon when in the #admins room. Curious what other product folks think about that though.

    Personally, I’d just close this issue for now. I think it’s fairly edge-casey for a user to open Concierge and then also click that link, so while not the most polished experience, I don’t think it’s worth prioritizing at this point.

  18. melvin-bot commented on Sep 15, 2026

    @melvin-bot

    @QichenZhu Whoops! This issue is 2 days overdue. Let's get this updated quick!

  19. melvin-bot commented on Sep 17, 2026

    @melvin-bot

    @QichenZhu Eep! 4 days overdue now. Issues have feelings too...

  20. melvin-bot commented on Sep 18, 2026

    @melvin-bot

    @QichenZhu this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

  21. flaviadefaria commented on Sep 21, 2026

    @flaviadefaria
    Contributor

    @shawnborton @dubielzyk-expensify do you have any concerns with just closing this?

  22. shawnborton commented on Sep 21, 2026

    @shawnborton
    Contributor

    No strong feelings on my end.

  23. melvin-bot commented on Sep 21, 2026

    @melvin-bot

    @QichenZhu 8 days overdue is a lot. Should this be a Weekly issue? If so, feel free to change it!

  24. dubielzyk-expensify commented on Sep 22, 2026

    @dubielzyk-expensify
    Contributor

    Go for it 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions