Repository navigation
Android - New Chat and New Group is broken - list of users is blank #10079
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Action Performed:
- Launch the app
- Log in with expensifail account
- Tap on Fub menu
Additional information:
Expected Result:
New Chat and New Group is broken - list of users should appear
Actual Result:
New Chat and New Group is broken - list of users is blank
Workaround:
Unknown
Platform:
Where is this issue occurring?
- Android
Version Number: 1.1.86.0
Reproducible in staging?: Yes
Reproducible in production?: No
Email or phone of affected tester (no customers): expensifail account
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Screen_Recording_20220725-135928_New.Expensify.mp4
Screen_Recording_20220725-135330_New.Expensify.mp4
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
Activity
OSBotify commentedon Jul 25, 2022
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open
StagingDeployCashdeploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:melvin-bot commentedon Jul 25, 2022
Triggered auto assignment to @pecanoro (
Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.pecanoro commentedon Jul 25, 2022
This happens when the keyboard is open but if the keyboard is closed, you can see the member list.
pecanoro commentedon Jul 25, 2022
I think this PR might have broken this when changing the KeyboardAvoidingView. cc/ @jasperhuangg @marcaaron @iwiznia @arosiclair
jasperhuangg commentedon Jul 25, 2022
Ahh, the missing options list under new chat must be because of how views and flexbox are platform dependent; the view that contains the options list probably isn't growing to fill the flex container.
As for the missing FAB options I don't think they would be affected by my PR.
I tested this on the Android emulator and it worked fine, I'm assuming it's only reproducible on a physical device.
I'm OOO today, any chance we could deploy without this? Retesting after fixing is probably going to take a while given all the different views that this feature touches.
iwiznia commentedon Jul 25, 2022
Let's revert the PR then?
pecanoro commentedon Jul 26, 2022
There are no missing FAB options, the problem is only the keyboard opening, I tried on my phone and I was able to reproduce so unless we want all phones with the bug I am with Ioni, we should revert the PR until we get to fix it.
luacmartins commentedon Jul 26, 2022
@jasperhuangg can we revert this PR since it seems to be causing this issue?
[-]Android - Missing Request, Split and New Room options under Fub menu, New Chat and New Group is broken - list of users is blank[/-][+]Android - New Chat and New Group is broken - list of users is blank[/+]luacmartins commentedon Jul 26, 2022
@kbecciv we reverted the PR that may have caused this issue. Can we retest and close this issue if it's a pass? Thank you!
luacmartins commentedon Jul 26, 2022
This seems to have been fixed by the revert. Closing!
kbecciv commentedon Aug 2, 2022
@luacmartins Issue is still exist in Android app on build 1.1.86.8
luacmartins commentedon Aug 2, 2022
Hmm I'll reopen it to investigate then, but I don't think it's a blocker anymore
jasperhuangg commentedon Aug 5, 2022
@kbecciv @pecanoro mentioned that there aren't any missing FAB options, the main bug here is the problem with displaying the list of users in the New Chat and New Group pages, which both have been resolved in #10140
Therefore I'm going to close this out.