Skip to content

[Due for payment 2026-11-14] Add a Save button when a user is no longer on the default view of a search #101216

Closed

Description

@JS00001

Coming from this thread in slack: https://expensify.slack.com/archives/C07NMDKEFMH/p1783455998482029

Now that we've completed our sticky search filters implementation, let's support the following flow.

  1. A user is on a suggested search (expenses, statements, etc)
  2. The user changes any of the filters to no longer be the default set of filters for that view
  3. Let's show the 'Save' button next to the 'Reset' button, to allow the user to save that view as a new saved search. We will no longer permanently show the 'Save' button

UI Changes

Normal view

The save search button doesnt show up with the default filters, but it shows up when the filters for the view are modified. This will follow the same logic as the reset button

Image

Saved searches

Saved searches will behave a bit different. They will also show the 'save' button when the filters are modified, however, the save button will perform a different action. When clicked, it will open a modal asking if the user wants to create a new saved search with the current filters, or if the user wants to update the existing saved search.

If the user clicks Create new, they will be taken to the creation screen:

Image

Otherwise, we will update the current search:

Image Image
Issue OwnerCurrent Issue Owner: @bernhardoj

Activity

  1. JS00001 commented on Sep 15, 2026

    @JS00001
    ContributorAuthor

    @bernhardoj would you want to help us with this one once it is ready for implementation?

  2. bernhardoj commented on Sep 16, 2026

    @bernhardoj
    Contributor

    @JS00001 sure, I'd be happy

  3. dannymcclain commented on Sep 17, 2026

    @dannymcclain
    Contributor

    @JS00001 @Expensify/design Ok I think I've got all the mocks in a good place here in Figma.

    I think y'all have basically already seen them, and there's really nothing surprising in there, but @JS00001 I wasn't sure how many of these mocks we wanted to include in the issue (vs just linking to Figma).

    Everything feels pretty straight-forward to me though: the save button uses the same style as the reset button (and should just fall into that same section of filter pills like the reset button does) and it kicks off the pre-existing save view flow (except in the case of saving while on a previously saved view, then we'll pop the modal to ask what the user wants to do).

  4. JS00001 commented on Sep 17, 2026

    @JS00001
    ContributorAuthor

    That looks great to me! @bernhardoj I'll add the flows to this issue, then could you get started on this one?

  5. JS00001 commented on Sep 17, 2026

    @JS00001
    ContributorAuthor

    Added to the OP

  6. bernhardoj commented on Sep 18, 2026

    @bernhardoj
    Contributor

    They will also show the 'save' button when the filters are modified

    @JS00001 for saved search specifically, we currently always show the Reset button because there are no "default filters" for saved search.

    Image

    Should we also alway show the Save button?

  7. JS00001 commented on Sep 18, 2026

    @JS00001
    ContributorAuthor

    @bernhardoj good question, I'd think so, yes. @flaviadefaria do you agree?

  8. dannymcclain commented on Sep 18, 2026

    @dannymcclain
    Contributor

    @JS00001 for saved search specifically, we currently always show the Reset button because there are no "default filters" for saved search.

    I think I disagree with this behavior. I think saving a view should make those filters default filters for the view, just like we have default filters for our Accounting views (for example). IMO the having the reset behavior here is weird, because when I reset, I'm still "on" the view, but I'm also not on the view at all anymore because all the filters are blasted away. This feels broken to me:

    CleanShot.2026-09-18.at.07.44.28.mp4
  9. trjExpensify commented on Sep 18, 2026

    @trjExpensify
    Contributor

    I think that's probably fine, but if you want to remove a filter of your existing saved search, you won't be able to do it easily if it's treated like a "default" filter.

  10. dannymcclain commented on Sep 18, 2026

    @dannymcclain
    Contributor

    but if you want to remove a filter of your existing saved search, you won't be able to do it easily if it's treated like a "default" filter.

    I kinda thought that was the point 🤷

  11. 77 remaining items

  12. changed the title [-][Due for payment 2026-10-14] Add a `Save` button when a user is no longer on the default view of a search[/-] [+][Due for payment 2026-11-14] Add a `Save` button when a user is no longer on the default view of a search[/+] on Nov 7, 2026
  13. melvin-bot commented on Nov 7, 2026

    @melvin-bot

    @bernhardoj / @aimane-chnaif @mallenexpensify

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.5.33-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2026-11-14. 🎊

    The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the Contributor+ Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]

  14. bernhardoj commented on Nov 8, 2026

    @bernhardoj
    Contributor

    Are we going to create a separate issue for this?
    cc: @JS00001

  15. flaviadefaria commented on Nov 9, 2026

    @flaviadefaria
    Contributor

    Approved: @bernhardoj due $500 via NewDot

  16. JS00001 commented on Nov 11, 2026

    @JS00001
    ContributorAuthor

    Created an issue here @bernhardoj #106629

  17. melvin-bot commented on Nov 11, 2026

    @melvin-bot

    @bernhardoj Whoops! This issue is 2 days overdue. Let's get this updated quick!

  18. aimane-chnaif commented on Nov 12, 2026

    @aimane-chnaif
    Contributor

    Contributor+ Checklist:

    • [Contributor] The offending PR and associated issue have been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to the comment on the PR: new feature
      Link to the comment on the Issue:

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion:

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

    Regression Test Proposal

    Test:

    1. Open Spend
    2. Change the Display option
    3. Verify it shows a number next to the Display label text to show how many displays are changed
    4. Verify there is a Save button
    5. Verify a Reset button is shown on the Display popup
    6. Press the Reset button
    7. Verify the Display is reset

    Do we agree 👍 or 👎


    The only remaining payment is for the work on #104589

  19. mallenexpensify commented on Nov 15, 2026

    @mallenexpensify
    Contributor

    Think we're good to close

  20. aimane-chnaif commented on Nov 15, 2026

    @aimane-chnaif
    Contributor

    @mallenexpensify the payment is remaining for the work on #104589

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionDailyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions