Skip to content

Upgrade react-native-safe-area-context before RN 0.88 bump #101446

Description

@MelvinBot

Parent issue

Part of #101427 — must land before the main React Native 0.88 / Expo SDK 58 bump PR.

Background

Expo SDK 58 bundles react-native-safe-area-context ~5.9.1. main is on 5.6.2. Safe Area Context declares react-native: *, so it is not gated on the RN bump and can land on the current RN 0.86 / Expo SDK 57 stack. This is a minor bump with no known breaking API changes.

Scope

  • Bump react-native-safe-area-context 5.6.2~5.9.1 in App (and Mobile-Expensify if required for HybridApp parity)
  • Rebase or remove the existing patch under patches/react-native-safe-area-context/, pinned to 5.6.2 in its filename: react-native-safe-area-context+5.6.2+001+fix-removechild-crash-on-unmount.patch — check whether the upstream fix landed between 5.7 and 5.9 so the patch can be dropped rather than rebased

Target

  • react-native-safe-area-context@~5.9.1 (Expo SDK 58 bundled version)

Acceptance criteria

  • App builds on iOS, Android, and web
  • HybridApp builds if Mobile-Expensify changes are needed
  • Safe area insets are correct on notched iOS devices, Android with gesture navigation, and in landscape
  • No removeChild crash regression on unmount (the behavior the patch guards)
  • Patch audit documented: keep, update, or remove
  • No new JS console errors

Notes

  • Keep this PR focused — do not include the RN / Expo version bump here
Issue OwnerCurrent Issue Owner: @war-in

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

EngineeringInternalRequires API changes or must be handled by Expensify staffReviewingHas a PR in reviewTaskWeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions