Skip to content

[$250] mWeb - Sign out on the Account page is covered by the debug indicator banner and cannot be scrolled into view. #102072

Open

Description

@m-natarajan

If you haven’t already, check out our contributing guidelines for onboarding. To join our Slack channel, fill out this form.


Version Number: 9.4.92-2
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from BrowserStack:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @abzokhattab
Slack conversation (hyperlinked to channel name): #Expensify Bugs

Action Performed:

Prerequisite:

  • Account has a billing problem (Subscription shows a red indicator).
  1. Open the app on Android/iOS Chrome (mweb), signed in.
  2. Go to Account → Troubleshoot and turn on Debug mode.
  3. Go back to Account and scroll to the bottom

Expected Result:

Sign out stays the last General item and remains fully visible/tappable. If the debug banner is showing, the list should leave space for it so Sign out is not covered.

Actual Result:

The debug banner (“There's a billing problem with your subscription”) sits on top of Sign out making it impossible to click on the Sign out button

Workaround:

Unknown

Platforms:

Select the officially supported platforms where the issue was reproduced:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari

Screenshots/Videos

Screen.Recording.2026-09-21.at.15.32.08.mov
ScreenRecording_09-23-2026.09-40-16_1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
Issue OwnerCurrent Issue Owner: @yusufdeveloper2903

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Sep 23, 2026
  2. MelvinBot commented on Sep 23, 2026

    @MelvinBot
    Contributor

    Proposal

    ⚠️ Medium confidence. I could not drive NewDot in a browser on this run, so the pixel-level mechanism below is from static analysis only. The structural defect is confirmed; the exact overlap geometry needs a real mWeb repro to settle.

    What is the root cause of that problem?

    On narrow layout the bottom stack is drawn as debug banner + tab bar, but the space reserved for it inside the page is only tab bar. Nothing on the Account page reserves the banner's height, so the banner lands over the end of the scroll content — where Sign out is.

    Two facts produce the gap:

    1. The Account page's scroll container has no bottom padding at all — src/pages/settings/InitialSettingsPage.tsx:178 is contentContainerStyle={[styles.w100]}. All bottom space comes from ScreenWrapper's bottomContent, which is a second copy of the tab bar rendered deliberately without the banner (TabBarBottomContent/index.tsx:16-21 passes shouldShowFloatingButtons={false}, which gates the banner off at NavigationTabBar/index.tsx:74). So the page reserves bottomTabHeight (72) + safe area and nothing more.

    2. The narrow tab-bar offset also ignores the banner — getTabBarNarrowStyle in src/styles/utils/index.ts:2518-2523 subtracts only bottomTabHeight + safeAreaPaddingBottom, while the container it offsets holds the banner too.

    The reason the existing fix for the same bug doesn't help here: useDebugTabViewHeight hard-returns 0 on narrow layout, and WorkspaceListLayout is its only consumer anywhere in src/. So there is currently no narrow-layout surface in the app that reserves banner height.

    What changes do you think we should make in order to solve the problem?

    Make the reserved bottom space on narrow layout match what is actually drawn.

    Preferred (page-scoped, low risk): add a narrow-aware banner height to the Account page's scroll content — either a bottom padding on contentContainerStyle at InitialSettingsPage.tsx:178, or a spacer View after {generalMenuItems} mirroring WorkspaceListLayout.tsx:136-141. This needs a narrow-capable height source — add a sibling hook (or an option) rather than removing the shouldUseNarrowLayout early return from useDebugTabViewHeight, so the Workspaces/Domains behaviour and its test stay untouched.

    Root cause (fixes Inbox and Workspaces on narrow too): have the bottomContent copy of the tab bar reserve the banner's height with an invisible spacer, so the in-flow reservation always equals the drawn stack. One change, every narrow tab root covered.

    Two things to get right either way:

    • Don't reserve a constant. The banner is getMinimumHeight(variables.debugTabViewHeight) (DebugTabView.tsx:265, debugTabViewHeight: 64), so on a phone the message wraps and the real banner exceeds 64px. Measure with onLayout instead of reserving the constant, or Sign out stays partly covered on small widths.
    • Measure before choosing. Reading the flexbox math literally, the narrow container should shrink the scene rather than overlap it, which contradicts the report. So confirm the real geometry first — if the scene already shrinks, adding a second reservation creates a dead gap instead of fixing anything.

    What alternative solutions did you explore? (Optional)

    Alternative explanation considered, and why the missing shouldEnableMaxHeight is worth checking

    Since this reproduces on mWeb Chrome but the boxes for native Android/iOS are unchecked, and both platforms share this exact React tree, a web-only viewport effect is a live second hypothesis.

    InitialSettingsPage does not pass shouldEnableMaxHeight (InitialSettingsPage.tsx:155-161), while WorkspaceListLayout does (WorkspaceListLayout.tsx:119). That prop is documented as "use the maxHeight (true) or use the 100% of the height (false)" and clamps to windowHeight — it exists precisely because 100% height on mobile browsers resolves against the layout viewport, not the visible one. Worth testing whether adding it alone resolves the symptom.

    How to settle it: open the Account page on mWeb at narrow width with debug mode on and a subscription error, then read the computed boxes of DebugTabViewContainer, both NavigationTabBar copies, and the settings ScrollView. If the scene does not shrink by the banner height, the fix belongs in getTabBarNarrowStyle / the bottomContent copy; if it does, the mWeb viewport path is the culprit.

    Why this is not a regression from the Workspaces fix

    Fix debug banner overlap on Workspaces and Domains wide layouts (merged 2026-09-14) fixed [Due for payment 2026-09-22] The payment method error badge overlaps and covers the last workspace in the Workspaces list — the same class of bug, one screen over. It is wide-layout only by construction, and its own test plan assumed narrow was already fine. The narrow-layout gap predates it, so no code-review rule is proposed here.

    Related issue

    [Due for payment 2026-09-22] The payment method error badge overlaps and covers the last workspace in the Workspaces list — same debug banner overlapping list content, Workspaces list, wide layout. Already fixed; useful as the reference pattern.


    Next Steps for Contributor+ team:
    To accept: @MelvinBot implement [this](https://github.com/Expensify/App/issues/102072) to create a draft PR.
    To refine: @MelvinBot <your feedback>
    To reject: Explain why you are rejecting Melvin's proposal.


    view run

  3. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Sep 23, 2026
  4. melvin-bot commented on Sep 23, 2026

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @FitseTLT (External)

  5. melvin-bot commented on Sep 23, 2026

    @melvin-bot

    Unable to auto-create job on Upwork. The BZ team member should create it manually for this issue.

  6. FitseTLT commented on Sep 25, 2026

    @FitseTLT
    Contributor

    Will review on Monday

  7. ashusatyarthi-wq commented on Sep 27, 2026

    @ashusatyarthi-wq

    Proposal

    Problem

    On narrow / mWeb viewports, when debug mode is enabled and a subscription/billing indicator is present, the debug indicator banner ("There's a billing problem with your subscription") covers the Sign out button at the bottom of the Account (InitialSettingsPage) screen, making it impossible to scroll Sign out fully into view or click it.

    Root Cause

    1. On narrow layouts, NavigationTabBar renders <DebugTabView selectedTab={selectedTab} /> directly above the 72px tab bar when shouldShowFloatingButtons is true.
    2. In InitialSettingsPage, the in-flow bottom spacing is provided via ScreenWrapper's bottomContent={<TabBarBottomContent selectedTab={NAVIGATION_TABS.SETTINGS} />}.
    3. In src/components/Navigation/TabBarBottomContent/index.tsx, NavigationTabBar is invoked with shouldShowFloatingButtons={false}. In NavigationTabBar/index.tsx:
      const shouldShowDebugTabView = !!isDebugModeEnabled && shouldShowFloatingButtons;
      Because shouldShowFloatingButtons is false in TabBarBottomContent, DebugTabView is omitted entirely from the in-flow spacer. Thus, TabBarBottomContent only reserves variables.bottomTabHeight (72px) + safe area padding.
    4. Meanwhile, TabNavigatorBar.tsx renders the actual overlay NavigationTabBar with shouldShowFloatingButtons={!isHidden} (true), which renders DebugTabView (height >= 64px) on top of the 72px tab bar.
    5. Because the bottom spacer inside InitialSettingsPage only accounts for 72px, the debug banner extends 64px upwards directly over the scroll container's bottom edge, permanently occluding the Sign out button.

    Proposed Changes

    1. Update TabBarBottomContent/index.tsx:
      Have TabBarBottomContent reserve the debug banner height when debug mode is active and an indicator message is present.

      import {useOnyx} from 'react-native-onyx';
      import ONYXKEYS from '@src/ONYXKEYS';
      import useIndicatorStatus from '@hooks/useIndicatorStatus';
      import {getSettingsMessage} from '@components/Navigation/DebugTabView';
      import variables from '@styles/variables';
      import useStyleUtils from '@hooks/useStyleUtils';

      Check if the debug banner is active:

      const [isDebugModeEnabled] = useOnyx(ONYXKEYS.IS_DEBUG_MODE_ENABLED);
      const {status} = useIndicatorStatus();
      const shouldShowDebugBanner = !!isDebugModeEnabled && !!getSettingsMessage(status);

      Render an invisible spacer of variables.debugTabViewHeight above NavigationTabBar inside TabBarBottomContent when shouldShowDebugBanner is true:

      return (
          <>
              {shouldShowDebugBanner && <View style={StyleUtils.getHeight(variables.debugTabViewHeight)} />}
              <NavigationTabBar
                  selectedTab={selectedTab}
                  shouldShowFloatingButtons={false}
              />
          </>
      );

      (Alternatively, export a narrow-aware spacer hook from DebugTabView.tsx and consume it in TabBarBottomContent.)

    2. This guarantees that all narrow tab-root screens utilizing TabBarBottomContent (InitialSettingsPage, WorkspaceListLayout, SearchPageNarrow, DomainInitialPage, etc.) automatically reserve the exact space needed for the debug banner, ensuring zero layout overlap and full scroll accessibility for Sign out.

    Test Plan

    1. Launch the app on mobile web / narrow layout signed in.
    2. Ensure the account has a billing/subscription issue or mock indicator status.
    3. Navigate to Account -> Troubleshoot and toggle Debug mode ON.
    4. Navigate back to Account (InitialSettingsPage) and scroll to the bottom.
    5. Verify that the debug banner ("There's a billing problem with your subscription") is visible above the bottom tab bar.
    6. Verify that the Sign out button can be scrolled completely into view above the debug banner and is fully interactive.
  8. melvin-bot commented on Sep 29, 2026

    @melvin-bot

    @FitseTLT Whoops! This issue is 2 days overdue. Let's get this updated quick!

  9. FitseTLT commented on Sep 29, 2026

    @FitseTLT
    Contributor

    Reviewing tomorrow

  10. FitseTLT commented on Oct 1, 2026

    @FitseTLT
    Contributor

    @MelvinBot doesn't fix it

  11. 120 remaining items

  12. melvin-bot commented on Oct 19, 2026

    @melvin-bot

    Triggered auto assignment to @AndrewGable, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

  13. FitseTLT commented on Oct 19, 2026

    @FitseTLT
    Contributor

    Reassigning as there is no response from the previous engineer and might be busy.

  14. KFC-19 commented on Oct 19, 2026

    @KFC-19

    @FitseTLT, I noticed that the selected proposal introduces a regression. Could you please review my comment and reconsider my proposal in light of this? I'd really appreciate it. Thanks!

    cc @AndrewGable

  15. FitseTLT commented on Oct 19, 2026

    @FitseTLT
    Contributor

    I already gave you my reponse here @KFC-19 and rendering two copies is not a new solution we are introducing here we are just following the same approach to fix similar bug in the main code base.

  16. removed
    Help WantedApply this label when an issue is open to proposals by contributors
    on Oct 19, 2026
  17. melvin-bot commented on Oct 19, 2026

    @melvin-bot

    📣 @yusufdeveloper2903 You have been assigned to this job!
    Please apply to the Upwork job and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
    Once you apply to this job, your Upwork ID will be stored and you will be automatically hired for future jobs!
    Keep in mind: Code of Conduct | Contributing 📖

  18. jasperhuangg commented on Oct 19, 2026

    @jasperhuangg
    Contributor

    Sorry for missing the pings, assigning @yusufdeveloper2903 to the issue

  19. yusufdeveloper2903 commented on Oct 22, 2026

    @yusufdeveloper2903
    Contributor

    The PR is ready for review. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.ExternalAdded to denote the issue can be worked on by a contributorReviewingHas a PR in reviewWeeklyKSv2

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions