Skip to content

Android & iOS - Spend - Unable to scroll down Describe your search page in landscape #102186

Closed

Description

@applause-bot

If you haven’t already, check out our contributing guidelines for onboarding. To join our Slack channel, fill out this form.


Version Number: 9.4.93-0
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from BrowserStack: -
Email or phone of affected tester (no customers): jsdoijnodsdisojo@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Samsung Galaxy S25 FE / Android 16
App Component: Search

Action Performed:

  1. Launch Expensify app.
  2. Go to Spend > Expenses.
  3. Open Filters > Describe your search.
  4. Rotate device to landscape.
  5. Tap on the search field.
  6. Scroll down the page.

Expected Result:

Describe your search page will be scrollable when keyboard is opened in landscape mode.

Actual Result:

Describe your search page is not scrollable when keyboard is opened in landscape mode

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome Safari

Screenshots/Videos

Bug7268224_1790255127109.Screen_Recording_20260924_210300_Expensify.mp4

View all open jobs on GitHub

Applause Internal Information
Exported by: Mita Rachim
Bug ID: 7268224

Activity

  1. applause-bot commented on Sep 24, 2026

    @applause-bot
    Author

    While Applause doesn't embed attachments for this bug, here are the links for quick view:
    https://platform.applause.com/services/links/v1/external/5f09d54f3211196eb920325aeae685156917ca02ffec16ffa4b5fb22deb9b83d

  2. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Sep 24, 2026
  3. melvin-bot commented on Sep 24, 2026

    @melvin-bot

    Triggered auto assignment to @stitesExpensify (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  4. melvin-bot commented on Sep 24, 2026

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  5. github-actions commented on Sep 24, 2026

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  6. MelvinBot commented on Sep 24, 2026

    @MelvinBot
    Contributor

    Proposal

    Causing PR: [Payment due @truph01] Add natural language filter entry point to Spend page (merged 2026-09-24 12:08 UTC, first entry in Deploy Checklist: New Expensify 2026-09-24). Confidence: high. Recommendation: roll forward with a ~10 line fix.

    What is the root cause of that problem?

    The "Describe your search" content has no ScrollView. Its body is a plain View tree with the Apply button pinned to the bottom via mtAuto: src/components/Search/FilterComponents/AdvancedFilters/SearchNLFilterContent.tsx:82-119.

    ScreenWrapper defaults to keyboard avoidance with behavior='padding', and the page sets shouldEnableMaxHeight, so the content box is clamped to the window height and then shrunk by the keyboard. In landscape with the keyboard up, roughly 150-200dp remain — not enough for the description text, the auto-growing textarea, and the bottom-pinned button. The content is clipped and nothing can scroll to reach it. Native-only, because mWeb and desktop get browser-level scrolling and a different keyboard model. That matches the reported platform matrix exactly.

    Both files are new in #94217 and do not exist on production, which matches "N/A - new feature, doesn't exist in prod".

    What changes do you think we should make in order to solve the problem?

    Apply the pattern that every sibling filter component already uses. In SearchNLFilterContent.tsx:

    1. Call useShouldFooterBeInsideList from @hooks/useShouldFooterBeInsideList.
    2. Wrap the description and text input in a ScrollView (from @components/ScrollView) with keyboardShouldPersistTaps="handled" and a flexGrow1 content container.
    3. Extract the button block into a variable and render it inside the ScrollView when the hook returns true, outside it otherwise.

    Reference implementation to copy: src/components/Search/FilterComponents/AdvancedFilters/TextInputFilterContent.tsx:68-98.

    This is safe for the wide-screen filters popup too, since that path already renders TextInputFilterContent with the identical structure.

    What alternative solutions did you explore? (Optional)

    Revert #94217. Viable, but heavier: 26 files including a new ParseExpenseFilters API command, 11 language files, navigation config, and the Spend page entry point. Reverting all of that for a landscape-plus-keyboard scroll bug on a brand-new page is more risk than a one-component fix. Fall back to revert only if the author is unavailable inside the deploy window.

    Demote the blocker. Defensible — landscape plus keyboard, native only, non-core flow. I'd keep the blocker since the fix is cheap.

    Why this is a clear miss, not an unknown

    Fix inputs hidden by keyboard using new filters in landscape mode (merged 2026-09-22, already in production) added useShouldFooterBeInsideList, whose doc comment describes this exact failure:

    In landscape mode the open keyboard leaves very little vertical space, so a footer fixed to the bottom eats most of what is left … the footer is moved into the list, so it scrolls with the data instead.

    That PR applied the pattern to TextInputFilterContent, AmountFilterContent, ReportFieldFilterContent, MultiSelect, SingleSelect, UserSelector, CardSelector, WorkspaceSelector, InSelector, and BankAccountSelector.

    #94217 was developed on a long-lived branch with commits back to 2026-06-15 and merged two days after #93935, so the new page never picked up the pattern. No other checklist PR touches these files.

    Not verified by running the app — this is native-only behavior and no emulator was available. Confirmation on a 9.4.93-0 Android or iOS build: open Filters > Describe your search in landscape, focus the input, and observe the description and Apply button clipped with no scroll response.

    Suggested assignees: marcaaron (author), truph01 and carlosmiceli (reviewers).

    Suggested code review rule amendment

    App already has rule UI-2 "New pages must be scrollable" in App/.claude/skills/app-coding-standards/rules/ui-2-new-page-scrollview.md, which #94217 violates — so no new rule, but the existing one has a gap worth closing.

    UI-2's "Flag ONLY when" clause requires that the new page's content is laid out directly in Views. It misses the shape here, where a new src/pages/** page delegates its whole body to a newly added src/components/** content component. Suggested amendment: follow the page's single content child when the page body is one newly added component, and add the landscape-plus-keyboard footer case (useShouldFooterBeInsideList + ScrollView) as the fix pattern for filter-style pages with a bottom-pinned button.

    No coding-standards file was modified.


    Next Steps for Contributor+ team:
    To accept: @MelvinBot implement [this](https://github.com/Expensify/App/issues/102186) to create a draft PR.
    To refine: @MelvinBot <your feedback>
    To reject: Explain why you are rejecting Melvin's proposal.


    view run

  7. stitesExpensify commented on Sep 24, 2026

    @stitesExpensify
    Contributor

    @MelvinBot implement this

  8. melvin-bot commented on Sep 24, 2026

    @melvin-bot

    ⚠️ Looks like this issue was linked to a Deploy Blocker here

    If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

    If a regression has occurred and you are the assigned CM follow the instructions here.

    If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

  9. MelvinBot commented on Sep 24, 2026

    @MelvinBot
    Contributor

    🤖 Draft PR created: Make Describe your search scrollable when the keyboard is open in landscape

    Please mark it as "Ready for review" when it is ready for review.

    What changed: src/components/Search/FilterComponents/AdvancedFilters/SearchNLFilterContent.tsx — one file, +48/-35. It now wraps the description and text input in a ScrollView and moves the Apply button inside that ScrollView when useShouldFooterBeInsideList is true, matching TextInputFilterContent.tsx exactly. The wide-screen filters popup keeps its current layout because it renders the same structure the other filter contents already use.

    AI tests run: ESLint, typecheck, React Compiler compliance, cspell, and the Search Jest suites (tests/ui/SearchPageTest.tsx + tests/unit/components/Search, 55 tests) all pass.

    ⚠️ Not verified on a device. This is native-only landscape-plus-keyboard behavior and no Android emulator or iOS simulator was available in this run, so the fix was reasoned from code and the existing pattern — not observed working. Someone should confirm on a 9.4.93 Android or iOS build before merging: open Filters > Describe your search in landscape, focus the input, and check the page scrolls and the Apply button stays reachable.

    The Tests and QA sections of the PR are left as TODOs for a human co-author.


    Next Steps: Reply with @MelvinBot <your feedback> to refine this.

  10. stitesExpensify commented on Sep 24, 2026

    @stitesExpensify
    Contributor

    Revert pr #102203

  11. 15 remaining items

  12. melvin-bot commented on Sep 30, 2026

    @melvin-bot

    @marcaaron Huh... This is 4 days overdue. Who can take care of this?

  13. melvin-bot commented on Oct 2, 2026

    @melvin-bot

    @marcaaron 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

  14. melvin-bot commented on Oct 3, 2026

    @melvin-bot

    @marcaaron 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

  15. melvin-bot commented on Oct 6, 2026

    @melvin-bot

    @marcaaron 10 days overdue. I'm getting more depressed than Marvin.

  16. melvin-bot commented on Oct 8, 2026

    @melvin-bot

    @marcaaron this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

  17. melvin-bot commented on Oct 8, 2026

    @melvin-bot

    @marcaaron 12 days overdue. Walking. Toward. The. Light...

  18. melvin-bot commented on Oct 12, 2026

    @melvin-bot

    This issue has not been updated in over 14 days. @marcaaron eroding to Weekly issue.

  19. marcaaron commented on Nov 3, 2026

    @marcaaron
    Contributor

    Working on the fix for this...

  20. marcaaron commented on Nov 3, 2026

    @marcaaron
    Contributor

    Retested on production with the keyboard open in landscape. The page scrolls now, and the input and Apply are both reachable. It's a tight fit because the keyboard takes up most of the screen in landscape, but that's the keyboard and not this page, so I'm closing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

BugSomething is broken. Auto assigns a BugZero manager.EngineeringWeeklyKSv2

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions