You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Android & iOS - Spend - Unable to scroll down Describe your search page in landscape #102186
Version Number: 9.4.93-0 Reproducible in staging?: Yes Reproducible in production?: N/A - new feature, doesn't exist in prod If this was caught during regression testing, add the test name, ID and link from BrowserStack: - Email or phone of affected tester (no customers):jsdoijnodsdisojo@gmail.com Issue reported by: Applause Internal Team Bug source: Exploratory - Significant User Experience Deterioration Device used: Samsung Galaxy S25 FE / Android 16 App Component: Search
Action Performed:
Launch Expensify app.
Go to Spend > Expenses.
Open Filters > Describe your search.
Rotate device to landscape.
Tap on the search field.
Scroll down the page.
Expected Result:
Describe your search page will be scrollable when keyboard is opened in landscape mode.
Actual Result:
Describe your search page is not scrollable when keyboard is opened in landscape mode
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
ScreenWrapper defaults to keyboard avoidance with behavior='padding', and the page sets shouldEnableMaxHeight, so the content box is clamped to the window height and then shrunk by the keyboard. In landscape with the keyboard up, roughly 150-200dp remain — not enough for the description text, the auto-growing textarea, and the bottom-pinned button. The content is clipped and nothing can scroll to reach it. Native-only, because mWeb and desktop get browser-level scrolling and a different keyboard model. That matches the reported platform matrix exactly.
Both files are new in #94217 and do not exist on production, which matches "N/A - new feature, doesn't exist in prod".
What changes do you think we should make in order to solve the problem?
Apply the pattern that every sibling filter component already uses. In SearchNLFilterContent.tsx:
Call useShouldFooterBeInsideList from @hooks/useShouldFooterBeInsideList.
Wrap the description and text input in a ScrollView (from @components/ScrollView) with keyboardShouldPersistTaps="handled" and a flexGrow1 content container.
Extract the button block into a variable and render it inside the ScrollView when the hook returns true, outside it otherwise.
This is safe for the wide-screen filters popup too, since that path already renders TextInputFilterContent with the identical structure.
What alternative solutions did you explore? (Optional)
Revert #94217. Viable, but heavier: 26 files including a new ParseExpenseFilters API command, 11 language files, navigation config, and the Spend page entry point. Reverting all of that for a landscape-plus-keyboard scroll bug on a brand-new page is more risk than a one-component fix. Fall back to revert only if the author is unavailable inside the deploy window.
Demote the blocker. Defensible — landscape plus keyboard, native only, non-core flow. I'd keep the blocker since the fix is cheap.
In landscape mode the open keyboard leaves very little vertical space, so a footer fixed to the bottom eats most of what is left … the footer is moved into the list, so it scrolls with the data instead.
That PR applied the pattern to TextInputFilterContent, AmountFilterContent, ReportFieldFilterContent, MultiSelect, SingleSelect, UserSelector, CardSelector, WorkspaceSelector, InSelector, and BankAccountSelector.
#94217 was developed on a long-lived branch with commits back to 2026-06-15 and merged two days after #93935, so the new page never picked up the pattern. No other checklist PR touches these files.
Not verified by running the app — this is native-only behavior and no emulator was available. Confirmation on a 9.4.93-0 Android or iOS build: open Filters > Describe your search in landscape, focus the input, and observe the description and Apply button clipped with no scroll response.
Suggested assignees:marcaaron (author), truph01 and carlosmiceli (reviewers).
Suggested code review rule amendment
App already has rule UI-2 "New pages must be scrollable" in App/.claude/skills/app-coding-standards/rules/ui-2-new-page-scrollview.md, which #94217 violates — so no new rule, but the existing one has a gap worth closing.
UI-2's "Flag ONLY when" clause requires that the new page's content is laid out directly in Views. It misses the shape here, where a new src/pages/** page delegates its whole body to a newly added src/components/** content component. Suggested amendment: follow the page's single content child when the page body is one newly added component, and add the landscape-plus-keyboard footer case (useShouldFooterBeInsideList + ScrollView) as the fix pattern for filter-style pages with a bottom-pinned button.
No coding-standards file was modified.
Next Steps for Contributor+ team: To accept:@MelvinBot implement [this](https://github.com/Expensify/App/issues/102186) to create a draft PR. To refine:@MelvinBot <your feedback> To reject: Explain why you are rejecting Melvin's proposal.
Please mark it as "Ready for review" when it is ready for review.
What changed:src/components/Search/FilterComponents/AdvancedFilters/SearchNLFilterContent.tsx — one file, +48/-35. It now wraps the description and text input in a ScrollView and moves the Apply button inside that ScrollView when useShouldFooterBeInsideList is true, matching TextInputFilterContent.tsx exactly. The wide-screen filters popup keeps its current layout because it renders the same structure the other filter contents already use.
AI tests run: ESLint, typecheck, React Compiler compliance, cspell, and the Search Jest suites (tests/ui/SearchPageTest.tsx + tests/unit/components/Search, 55 tests) all pass.
⚠️Not verified on a device. This is native-only landscape-plus-keyboard behavior and no Android emulator or iOS simulator was available in this run, so the fix was reasoned from code and the existing pattern — not observed working. Someone should confirm on a 9.4.93 Android or iOS build before merging: open Filters > Describe your search in landscape, focus the input, and check the page scrolls and the Apply button stays reachable.
The Tests and QA sections of the PR are left as TODOs for a human co-author.
Next Steps: Reply with @MelvinBot <your feedback> to refine this.
@marcaaron this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!
Retested on production with the keyboard open in landscape. The page scrolls now, and the input and Apply are both reachable. It's a tight fit because the keyboard takes up most of the screen in landscape, but that's the keyboard and not this page, so I'm closing this.
Activity
applause-bot commentedon Sep 24, 2026
While Applause doesn't embed attachments for this bug, here are the links for quick view:
https://platform.applause.com/services/links/v1/external/5f09d54f3211196eb920325aeae685156917ca02ffec16ffa4b5fb22deb9b83d
melvin-bot commentedon Sep 24, 2026
Triggered auto assignment to @stitesExpensify (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.melvin-bot commentedon Sep 24, 2026
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Sep 24, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
MelvinBot commentedon Sep 24, 2026
Proposal
Causing PR: [Payment due @truph01] Add natural language filter entry point to Spend page (merged 2026-09-24 12:08 UTC, first entry in Deploy Checklist: New Expensify 2026-09-24). Confidence: high. Recommendation: roll forward with a ~10 line fix.
What is the root cause of that problem?
The "Describe your search" content has no
ScrollView. Its body is a plainViewtree with the Apply button pinned to the bottom viamtAuto:src/components/Search/FilterComponents/AdvancedFilters/SearchNLFilterContent.tsx:82-119.ScreenWrapperdefaults to keyboard avoidance withbehavior='padding', and the page setsshouldEnableMaxHeight, so the content box is clamped to the window height and then shrunk by the keyboard. In landscape with the keyboard up, roughly 150-200dp remain — not enough for the description text, the auto-growing textarea, and the bottom-pinned button. The content is clipped and nothing can scroll to reach it. Native-only, because mWeb and desktop get browser-level scrolling and a different keyboard model. That matches the reported platform matrix exactly.Both files are new in #94217 and do not exist on
production, which matches "N/A - new feature, doesn't exist in prod".What changes do you think we should make in order to solve the problem?
Apply the pattern that every sibling filter component already uses. In
SearchNLFilterContent.tsx:useShouldFooterBeInsideListfrom@hooks/useShouldFooterBeInsideList.ScrollView(from@components/ScrollView) withkeyboardShouldPersistTaps="handled"and aflexGrow1content container.ScrollViewwhen the hook returns true, outside it otherwise.Reference implementation to copy:
src/components/Search/FilterComponents/AdvancedFilters/TextInputFilterContent.tsx:68-98.This is safe for the wide-screen filters popup too, since that path already renders
TextInputFilterContentwith the identical structure.What alternative solutions did you explore? (Optional)
Revert #94217. Viable, but heavier: 26 files including a new
ParseExpenseFiltersAPI command, 11 language files, navigation config, and the Spend page entry point. Reverting all of that for a landscape-plus-keyboard scroll bug on a brand-new page is more risk than a one-component fix. Fall back to revert only if the author is unavailable inside the deploy window.Demote the blocker. Defensible — landscape plus keyboard, native only, non-core flow. I'd keep the blocker since the fix is cheap.
Why this is a clear miss, not an unknown
Fix inputs hidden by keyboard using new filters in landscape mode (merged 2026-09-22, already in production) added
useShouldFooterBeInsideList, whose doc comment describes this exact failure:That PR applied the pattern to
TextInputFilterContent,AmountFilterContent,ReportFieldFilterContent,MultiSelect,SingleSelect,UserSelector,CardSelector,WorkspaceSelector,InSelector, andBankAccountSelector.#94217 was developed on a long-lived branch with commits back to 2026-06-15 and merged two days after #93935, so the new page never picked up the pattern. No other checklist PR touches these files.
Not verified by running the app — this is native-only behavior and no emulator was available. Confirmation on a 9.4.93-0 Android or iOS build: open Filters > Describe your search in landscape, focus the input, and observe the description and Apply button clipped with no scroll response.
Suggested assignees:
marcaaron(author),truph01andcarlosmiceli(reviewers).Suggested code review rule amendment
App already has rule UI-2 "New pages must be scrollable" in
App/.claude/skills/app-coding-standards/rules/ui-2-new-page-scrollview.md, which #94217 violates — so no new rule, but the existing one has a gap worth closing.UI-2's "Flag ONLY when" clause requires that the new page's content is laid out directly in
Views. It misses the shape here, where a newsrc/pages/**page delegates its whole body to a newly addedsrc/components/**content component. Suggested amendment: follow the page's single content child when the page body is one newly added component, and add the landscape-plus-keyboard footer case (useShouldFooterBeInsideList+ScrollView) as the fix pattern for filter-style pages with a bottom-pinned button.No coding-standards file was modified.
Next Steps for Contributor+ team:
To accept:
@MelvinBot implement [this](https://github.com/Expensify/App/issues/102186)to create a draft PR.To refine:
@MelvinBot <your feedback>To reject: Explain why you are rejecting Melvin's proposal.
view run
stitesExpensify commentedon Sep 24, 2026
@MelvinBot implement this
melvin-bot commentedon Sep 24, 2026
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
MelvinBot commentedon Sep 24, 2026
🤖 Draft PR created: Make Describe your search scrollable when the keyboard is open in landscape
Please mark it as "Ready for review" when it is ready for review.
What changed:
src/components/Search/FilterComponents/AdvancedFilters/SearchNLFilterContent.tsx— one file, +48/-35. It now wraps the description and text input in aScrollViewand moves the Apply button inside thatScrollViewwhenuseShouldFooterBeInsideListis true, matchingTextInputFilterContent.tsxexactly. The wide-screen filters popup keeps its current layout because it renders the same structure the other filter contents already use.AI tests run: ESLint,
typecheck, React Compiler compliance, cspell, and the Search Jest suites (tests/ui/SearchPageTest.tsx+tests/unit/components/Search, 55 tests) all pass.The
TestsandQAsections of the PR are left as TODOs for a human co-author.Next Steps: Reply with
@MelvinBot <your feedback>to refine this.stitesExpensify commentedon Sep 24, 2026
Revert pr #102203
15 remaining items
melvin-bot commentedon Sep 30, 2026
@marcaaron Huh... This is 4 days overdue. Who can take care of this?
melvin-bot commentedon Oct 2, 2026
@marcaaron 6 days overdue. This is scarier than being forced to listen to Vogon poetry!
melvin-bot commentedon Oct 3, 2026
@marcaaron 6 days overdue. This is scarier than being forced to listen to Vogon poetry!
melvin-bot commentedon Oct 6, 2026
@marcaaron 10 days overdue. I'm getting more depressed than Marvin.
melvin-bot commentedon Oct 8, 2026
@marcaaron this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!
melvin-bot commentedon Oct 8, 2026
@marcaaron 12 days overdue. Walking. Toward. The. Light...
melvin-bot commentedon Oct 12, 2026
This issue has not been updated in over 14 days. @marcaaron eroding to Weekly issue.
marcaaron commentedon Nov 3, 2026
Working on the fix for this...
marcaaron commentedon Nov 3, 2026
Retested on production with the keyboard open in landscape. The page scrolls now, and the input and Apply are both reachable. It's a tight fit because the keyboard takes up most of the screen in landscape, but that's the keyboard and not this page, so I'm closing this.