Skip to content

[Due for payment 2026-10-02] Payment issue for E/App PR#101907 #102289

Closed

Description

@melvin-bot

Issue created to compensate the Contributor+ member for their work on #101907
E/E issue linked to the PR - https://www.github.com/Expensify/Expensify/issues/680784.
Contributor+ member who reviewed the PR - @daledah.

Wait 7 days after the PR is deployed to production before issuing payment in case there are regressions.

Issue OwnerCurrent Issue Owner: @mallenexpensify

Activity

  1. melvin-bot commented on Sep 25, 2026

    @melvin-bot
    Author

    @daledah The PR you reviewed has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the Contributor+ Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]

  2. daledah commented on Sep 28, 2026

    @daledah
    Contributor

    BugZero Checklist:

    • [Contributor] The offending PR and associated issue have been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to the comment on the PR: N/A

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion:

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

    • [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

      Link to issue: https://github.com/Expensify/Expensify/issues/688393

    Regression Test Proposal

    Precondition:

    • Needs a QuickBooks Desktop workspace whose chart of accounts contains two credit card accounts with the same display name (QBD allows this when they sit under different parents), and a company card on that workspace.

    Test:

    1. Sign in as an admin of that workspace.
    2. Go to Workspace settings > Company cards and open a card's details page.
    3. Under Accounting, tap the export account row.
    4. Verify both same-named accounts are listed and neither the list nor the screen errors out.
    5. Select each of them in turn and verify the card details page shows the one you picked.
    6. Repeat on a QuickBooks Online workspace and verify selection still works.

    Do we agree 👍 or 👎

    Zapier Logs Run ID: 00040eee-20a6-ac2c-35a1-15c0480cfcf4
  3. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Sep 28, 2026
  4. melvin-bot commented on Oct 1, 2026

    @melvin-bot
    Author

    Triggered auto assignment to @mallenexpensify (Awaiting Payment)

  5. melvin-bot commented on Oct 1, 2026

    @melvin-bot
    Author

    Payment Summary

    • Reviewer: @daledah owed $175 via NewDot

    BugZero Checklist (@mallenexpensify)

    • I have confirmed assignees, roles, and Upwork contracts look correct
    • I have paid out Upwork contracts / manual NewDot requests
    • [BugZero Assignee] I have created a GH issue for creating/updating the regression test once above steps have been agreed upon
  6. mallenexpensify commented on Oct 3, 2026

    @mallenexpensify
    Contributor

    Payment Summary

    Contributor+: @daledah due $175 via NewDot

  7. quinthar commented on Oct 27, 2026

    @quinthar
    Contributor

    Approved $175 to @daledah

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionDailyKSv2Task

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions