[HOLD for payment 2022-11-02] [$250] Unable to enter valid name on enable payments page

@neil-marcellini

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Action Performed:

The account already has a bank account added.
Hit green plus button
Send money
Enter amount
Enter email
Pay with Expensify
Fill out additional details and hit Save & continue

Expected Result:

Form submits without error

Actual Result:

Please enter valid first / last name errors appear

Workaround:

unknown

Platform:

Where is this issue occurring?

Web
iOS
Android
Desktop App
Mobile Web

Version Number: 1.1.86-5
Reproducible in staging?: Y
Reproducible in production?: Y
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Expensify/Expensify Issue URL:
Issue reported by: @neil-marcellini
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1659562084924539

View all open jobs on GitHub

@iwiznia

Triggered auto assignment to @iwiznia (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@dylanexpensify

Triggered auto assignment to @dylanexpensify (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

@mvtglobally

This is weird, isn't this flow tested in QA @mvtglobally?

Proposal

This only happens when the first, last name gets added from the personal details.

App/src/pages/EnablePayments/AdditionalDetailsStep.js

Line 273 in 787f3a8

    
           const {firstName, lastName} = PersonalDetails.extractFirstAndLastNameFromAvailableDetails(this.props.currentUserPersonalDetails);

App/src/pages/EnablePayments/AdditionalDetailsStep.js

Line 298 in 787f3a8

value={this.props.walletAdditionalDetailsDraft.legalFirstName || firstName}

In validation we are only checking if walletAdditionalDetailsDraft.legalFirstName walletAdditionalDetailsDraft.legalLastName is empty or not, so if the first name/last name is pre-filled, we will see the error because the walletAdditionalDetailsDraft.legalFirstName/legalLastName will be empty

To fix this we can update the details directly on the first render and we can remove the firstName from line 298 (same for lastName) This will also fix another issue here

    componentDidMount() {
        const {firstName, lastName} = PersonalDetails.extractFirstAndLastNameFromAvailableDetails(this.props.currentUserPersonalDetails);
        Wallet.updateAdditionalDetailsDraft({legalFirstName: firstName, legalLastName: lastName});
    }

@iwiznia

@iwiznia we are blocked currently from wallet and bank validation on NewDot due to PROD KYC wall. This flow is not QAed E2E. (KI 10084)

Internal: https://www.upwork.com/ab/applicants/1557310230097203200/job-details
External: https://www.upwork.com/jobs/~01f43869eb83e9e0b2

@rushatgabhane

upwork job: https://www.upwork.com/jobs/~0143304008c18576d5 cc @rushatgabhane @thesahindia !

@dylanexpensify

Current assignee @dylanexpensify is eligible for the External assigner, not assigning anyone new.

@rushatgabhane

Current assignees @rushatgabhane and @thesahindia are eligible for the External assigner, not assigning anyone new.

@sketchydroide

Triggered auto assignment to @sketchydroide (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

Applied!

@rushatgabhane

@rushatgabhane ^

@dylanexpensify

@dylanexpensify applied

@rushatgabhane

@rushatgabhane offer sent!

payments sent, role closed, contracts ended, thanks yall!

Navigation Menu

Repository navigation

[HOLD for payment 2022-11-02] [$250] Unable to enter valid name on enable payments page #10240

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platform:

Proposal

44 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

[HOLD for payment 2022-11-02] [$250] Unable to enter valid name on enable payments page #10240

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platform:

Activity

melvin-bot commented on Aug 4, 2022

melvin-bot commented on Aug 8, 2022

iwiznia commented on Aug 8, 2022

thesahindia commented on Aug 9, 2022

Proposal

mvtglobally commented on Aug 10, 2022

dylanexpensify commented on Aug 10, 2022

44 remaining items

dylanexpensify commented on Nov 2, 2022

melvin-bot commented on Nov 2, 2022

melvin-bot commented on Nov 2, 2022

melvin-bot commented on Nov 2, 2022

thesahindia commented on Nov 2, 2022

dylanexpensify commented on Nov 3, 2022

rushatgabhane commented on Nov 3, 2022

dylanexpensify commented on Nov 4, 2022

dylanexpensify commented on Nov 4, 2022

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions