You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Android - Expense - Inconsistent behavior after deleting expense opened via growl. #102845
Version Number: 9.5.1-0 Reproducible in staging?: Yes Reproducible in production?: N/A - new feature, doesn't exist in prod If this was caught during regression testing, add the test name, ID and link from BrowserStack:#100015 Email or phone of affected tester (no customers):ibellicotest+3215@gmail.com Issue reported by: Applause Internal Team Bug source: Exploratory - Significant User Experience Deterioration Device used: Motorola MotoG60 / Android 12 (Hybrid app) App Component: Money Requests
Action Performed:
Prerequisite: Account has at least one workspace.
Open the Expensify app.
Create a manual expense via FAB and submit it to workspace chat.
Return to "Inbox"
Create a second manual expense via FAB and submit it to workspace.
Tap on "View" on the displayed growl.
Once expense was opened, tap on "More" > "Delete" > "Delete"
Note that you land on chat, instead of landing on parent report.
Return to "Inbox" one more time.
Create another manual expense via FAB and submit it to workspace.
Tap on "View" on the displayed growl.
Tap on expense header to navigate to details page.
Delete the expense.
Note that you land on parent report.
Expected Result:
After opening an expense via growl and deleting it, user should return to parent report if there are more expenses.
Actual Result:
Behavior after deleting expense opened via growl is inconsistent if there are more expenses on report. If expense is deleted via "More" menu, user lands on chat, and if expense is deleted via details page, user lands on parent report.
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Recommendation: Demote and fix forward. Do not revert. This is a navigation inconsistency in an unreleased feature on narrow layout only. The expense is still deleted correctly, and no data is lost.
Root Cause: On narrow layout, the growl's "View" opens the expense thread directly on top of the workspace chat, with backTo set to the chat. It skips the parent expense report. More > Delete then calls goBack(backTo), so the user lands on the chat. The details-page delete works out the parent report on its own, so it lands correctly.
Recommended Fix: In navigateToCreatedExpense.ts, make the narrow branch match the wide branch. When the report has several expenses, open the expense report first, then stack the thread on it. A smaller option is to pass the expense report route as the thread's backTo. Add a narrow, multi-expense case to tests/unit/navigateToCreatedExpenseTest.ts.
navigateToCreatedExpense (new in this PR) sets backTo to the active route, which is the chat (L55). The narrow branch returns before the iouReportID handling. The wide branch stacks report → thread for multi-expense reports (L67-L84), so wide layouts are not affected.
Other checklist PRs: I checked the other App PRs in this deploy against the delete, navigation, header, and growl code. None of them change this navigation.
Not a regression: More > Delete works in the existing chat → report → thread flow. Only the new "View" entry point leaves the report out of the stack.
Next Steps: Reply with @MelvinBot implement this to create a draft PR, or @MelvinBot <your feedback> to refine this analysis.
Activity
applause-bot commentedon Oct 2, 2026
While Applause doesn't embed attachments for this bug, here are the links for quick view:
https://platform.applause.com/services/links/v1/external/e1600df90f52bb124ff7c440ac1b9f007bcb445d4824c12fdf51b95a2b8123af
melvin-bot commentedon Oct 2, 2026
You have been assigned to this deploy blocker because you recently merged this PR: #100015
melvin-bot commentedon Oct 2, 2026
@mountiny @situchan you have been assigned to this deploy blocker because you reviewed the offending PR: #100015
github-actions commentedon Oct 2, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
melvin-bot commentedon Oct 2, 2026
@mhawryluk you have been assigned to this deploy blocker because you authored the offending PR: #100015
melvin-bot commentedon Oct 2, 2026
💬 A slack conversation has been started in #expensify-open-source
MelvinBot commentedon Oct 2, 2026
Deploy Blocker Analysis
Causing PR: Confirm new expenses with a “View” toast instead of scrolling to and highlighting the row v2 (high confidence).
Recommendation: Demote and fix forward. Do not revert. This is a navigation inconsistency in an unreleased feature on narrow layout only. The expense is still deleted correctly, and no data is lost.
Root Cause: On narrow layout, the growl's "View" opens the expense thread directly on top of the workspace chat, with
backToset to the chat. It skips the parent expense report. More > Delete then callsgoBack(backTo), so the user lands on the chat. The details-page delete works out the parent report on its own, so it lands correctly.route.params.backTo: MoneyRequestHeaderSecondaryActions.tsx:572-573Recommended Fix: In
navigateToCreatedExpense.ts, make the narrow branch match the wide branch. When the report has several expenses, open the expense report first, then stack the thread on it. A smaller option is to pass the expense report route as the thread'sbackTo. Add a narrow, multi-expense case totests/unit/navigateToCreatedExpenseTest.ts.Investigation details
navigateToCreatedExpense(new in this PR) setsbackToto the active route, which is the chat (L55). The narrow branch returns before theiouReportIDhandling. The wide branch stacks report → thread for multi-expense reports (L67-L84), so wide layouts are not affected.onBackButtonPress(MoneyRequestHeaderSecondaryActions.tsx:629), which resolves toNavigation.goBack(backTo)(ReportHeader.tsx:68-70).getNavigationUrlOnMoneyRequestDelete(DynamicReportDetailsPage/index.tsx:890-907). That function returns the expense report route when the report survives (DeleteMoneyRequest.ts:374-376).Other checklist PRs: I checked the other App PRs in this deploy against the delete, navigation, header, and growl code. None of them change this navigation.
Not a regression: More > Delete works in the existing chat → report → thread flow. Only the new "View" entry point leaves the report out of the stack.
Next Steps: Reply with
@MelvinBot implement thisto create a draft PR, or@MelvinBot <your feedback>to refine this analysis.view run
mhawryluk commentedon Oct 2, 2026
I agree with Melvin that we should demote it and fix later, nothing is actually broken, it's just a little inconsistent
melvin-bot commentedon Oct 2, 2026
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
melvin-bot commentedon Oct 2, 2026
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
mhawryluk commentedon Oct 2, 2026
actually, I think this PR should fix this issue too: #102854
mountiny commentedon Oct 2, 2026
I think we can demote this one
situchan commentedon Oct 4, 2026
This is not a regression from #100015. The production app already has two different mechanisms.
The More menu uses:
App/src/hooks/useExpenseActions.ts
Lines 572 to 573 in 285ed64
while the details page uses
navigateBackOnDeleteTransactionunconditionally.The prod app also already produces a no-backTo arrival at the expense report:
App/src/components/ParentNavigationSubtitle.tsx
Line 164 in 285ed64
App/src/libs/Navigation/helpers/dismissModalAndOpenReportInInboxTab.ts
Line 52 in 285ed64
Repro step:
backTo.Or just update step 5, 10 in OP:
to: Tao on the created expense in report preview
bug.mp4
melvin-bot commentedon Oct 5, 2026
@mhawryluk Whoops! This issue is 2 days overdue. Let's get this updated quick!
mhawryluk commentedon Oct 6, 2026
it has been fixed by this PR: #102854. now in both cases we are back to the parent report instead of chat.
Nagranie.z.ekranu.2026-10-6.o.14.14.43.mov
may I ask for a retest?
mountiny commentedon Oct 7, 2026
Asked for a retest.