Skip to content

[Due for payment 2026-10-15] [$175] [Performance] Skip empty-report scans while create menus are closed #103343

Closed

Description

@rlinoz

Problem

Opening a report triggers repeated empty-report checks even while the Create report menus are closed. Each check iterates through the account’s expenses, and several mounted screens run their own copy on expense updates.

On an account with approximately 52,000 expenses, the check took about 80ms per invocation, adding unnecessary work to report loading.

Solution

Skip the empty-report check while the relevant menu is closed, and run it when the user opens:

  • The report composer’s + menu.
  • The Search page header’s Create menu.

Preserve the existing confirmation behavior when an empty report exists.

Performance

As reported in the PR, opening a report in a development build with 4× CPU slowdown improved from approximately 3982ms to 3491ms on average (roughly 12%).

Verification

Verify that Create report shows the confirmation when an empty report exists, and creates a report without confirmation when none exists, from both menus. Repeat offline.

PR

#103340

Parent

#77173

Issue OwnerCurrent Issue Owner: @mallenexpensify
Upwork Automation - Do Not Edit

Activity

  1. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Oct 7, 2026
  2. melvin-bot commented on Oct 7, 2026

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @situchan (External)

  3. changed the title [-][Performance] Skip empty-report scans while create menus are closed[/-] [+][$175] [Performance] Skip empty-report scans while create menus are closed[/+] on Oct 7, 2026
  4. melvin-bot commented on Oct 7, 2026

    @melvin-bot
  5. changed the title [-][$175] [Performance] Skip empty-report scans while create menus are closed[/-] [+][Due for payment 2026-10-15] [$175] [Performance] Skip empty-report scans while create menus are closed[/+] on Oct 8, 2026
  6. melvin-bot commented on Oct 8, 2026

    @melvin-bot

    @situchan

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.5.5-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2026-10-15. 🎊

    The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the Contributor+ Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]

  7. melvin-bot commented on Oct 12, 2026

    @melvin-bot

    @situchan Eep! 4 days overdue now. Issues have feelings too...

  8. situchan commented on Oct 14, 2026

    @situchan
    Contributor

    Perf issue. No need checklist

  9. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Oct 14, 2026
  10. melvin-bot commented on Oct 14, 2026

    @melvin-bot

    Triggered auto assignment to @mallenexpensify (Awaiting Payment)

  11. melvin-bot commented on Oct 14, 2026

    @melvin-bot

    Payment Summary

    Resolving PRs:

    BugZero Checklist (@mallenexpensify)

    • I have confirmed assignees, roles, and Upwork contracts look correct
    • I have paid out Upwork contracts / manual NewDot requests
    • [BugZero Assignee] I have created a GH issue for creating/updating the regression test once above steps have been agreed upon
  12. mallenexpensify commented on Oct 17, 2026

    @mallenexpensify
    Contributor

    Payment Summary

    Contributor+: @situchan due $175 via NewDot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionDailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions